kenmirrors/ente
1
0
Fork 0
mirror of https://github.com/ente-io/ente.git synced 2025-08-13 17:57:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

err 1

Browse Source
This commit is contained in:
Manav Rathi
2025-02-28 13:33:50 +05:30
parent cea88b91d2
commit ffc1db7369
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/packages/gallery/components/viewer/FileViewer.tsx
View File

@@ -15,6 +15,7 @@ if (process.env.NEXT_PUBLIC_ENTE_WIP_PS5) {
import { isDesktop } from "@/base/app"; import { isDesktop } from "@/base/app";
import { type ModalVisibilityProps } from "@/base/components/utils/modal"; import { type ModalVisibilityProps } from "@/base/components/utils/modal";
import { useBaseContext } from "@/base/context";
import { lowercaseExtension } from "@/base/file-name"; import { lowercaseExtension } from "@/base/file-name";
import type { LocalUser } from "@/base/local-user"; import type { LocalUser } from "@/base/local-user";
import log from "@/base/log"; import log from "@/base/log";
@@ -159,6 +160,8 @@ const FileViewer: React.FC<FileViewerProps> = ({
onSelectPerson, onSelectPerson,
onSaveEditedImageCopy, onSaveEditedImageCopy,
}) => { }) => {
const { onGenericError } = useBaseContext();
// There are 3 things involved in this dance: // There are 3 things involved in this dance:
// //
// 1. Us, "FileViewer". We're a React component. // 1. Us, "FileViewer". We're a React component.
@@ -306,7 +309,12 @@ const FileViewer: React.FC<FileViewerProps> = ({
if (!showModifyActions || !favoriteFileIDs) if (!showModifyActions || !favoriteFileIDs)
throw new Error("Unexpected invocation"); throw new Error("Unexpected invocation");
await new Promise((r) => setTimeout(r, 7000)); try {
await new Promise((r) => setTimeout(r, 3000));
throw new Error("test");
} catch (e) {
onGenericError(e);
}
console.log({ file, annotation }); console.log({ file, annotation });
// TODO // TODO
// const isFavorite = annotation.isFavorite; // const isFavorite = annotation.isFavorite;
@@ -323,7 +331,7 @@ const FileViewer: React.FC<FileViewerProps> = ({
// onMarkUnsyncedFavoriteUpdate(file.id, undefined); // onMarkUnsyncedFavoriteUpdate(file.id, undefined);
// }); // });
}, },
[showModifyActions, favoriteFileIDs], [showModifyActions, onGenericError, favoriteFileIDs],
); );
// Initial value of delegate. // Initial value of delegate.

6
web/packages/gallery/components/viewer/photoswipe.ts
View File

@@ -90,7 +90,11 @@ export interface FileViewerPhotoSwipeDelegate {
* Called when the user activates the toggle favorite action on a file. * Called when the user activates the toggle favorite action on a file.
* *
* The toggle favorite button will be disabled for the file until the * The toggle favorite button will be disabled for the file until the
* promise returned by this function returns settles. * promise returned by this function returns fulfills.
*
* > Note: The caller is expected to handle any errors that occur, and
* > should not reject for foreseeable failures, otherwise the button will
* > remain in the disabled state (until the file viewer is closed).
*/ */
toggleFavorite: (annotatedFile: FileViewerAnnotatedFile) => Promise<void>; toggleFavorite: (annotatedFile: FileViewerAnnotatedFile) => Promise<void>;
} }