kenmirrors/ente
1
0
Fork 0
mirror of https://github.com/ente-io/ente.git synced 2025-08-13 09:47:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup

Browse Source
This commit is contained in:
Manav Rathi
2025-02-18 20:15:16 +05:30
parent 13752654cd
commit fcf06cff57
3 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
web/packages/gallery/components/viewer/FileViewer.tsx
View File

@@ -112,7 +112,20 @@ const FileViewer: React.FC<FileViewerProps> = ({
pswpRef.current?.closeIfNeeded();
pswpRef.current = undefined;
};
// TODO(PS): This is missing files, initialIndex, disableDownload,
// The hook is missing dependencies; this is intentional - we don't want
// to recreate the PhotoSwipe dialog when these dependencies change.
//
// - Updates to initialIndex can be safely ignored: they don't matter,
// only their initial value at the time of open mattered.
//
// - Updates to disableDownload are not expected after open. We could've
// also added it to the dependencies array, not adding it was a more
// conservative choice to be on the safer side and trigger too few
// instead of too many updates.
//
// - Updates to files matter, but these are conveyed separately.
// TODO(PS):
//
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [open, onClose, handleViewInfo]);