From f15851e6de523e4f869b1b23f5083584d30c3f13 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Sat, 20 Jul 2024 13:44:01 +0530 Subject: [PATCH] Remove unused code path --- web/apps/photos/src/services/export/index.ts | 43 +++++--------------- web/packages/shared/events/index.ts | 12 ------ 2 files changed, 11 insertions(+), 44 deletions(-) delete mode 100644 web/packages/shared/events/index.ts diff --git a/web/apps/photos/src/services/export/index.ts b/web/apps/photos/src/services/export/index.ts index ffe1d43d65..394dbf8805 100644 --- a/web/apps/photos/src/services/export/index.ts +++ b/web/apps/photos/src/services/export/index.ts @@ -15,7 +15,6 @@ import { safeDirectoryName, safeFileName } from "@/new/photos/utils/native-fs"; import { writeStream } from "@/new/photos/utils/native-stream"; import { wait } from "@/utils/promise"; import { CustomError } from "@ente/shared/error"; -import { Events, eventBus } from "@ente/shared/events"; import { LS_KEYS, getData, setData } from "@ente/shared/storage/localStorage"; import { formatDateTimeShort } from "@ente/shared/time/format"; import type { User } from "@ente/shared/user/types"; @@ -177,42 +176,22 @@ class ExportService { } enableContinuousExport() { - try { - if (this.continuousExportEventHandler) { - log.info("continuous export already enabled"); - return; - } - log.info("enabling continuous export"); - this.continuousExportEventHandler = () => { - this.scheduleExport({ resync: this.resyncOnce() }); - }; - this.continuousExportEventHandler(); - eventBus.addListener( - Events.LOCAL_FILES_UPDATED, - this.continuousExportEventHandler, - ); - } catch (e) { - log.error("failed to enableContinuousExport ", e); - throw e; + if (this.continuousExportEventHandler) { + log.warn("Continuous export already enabled"); + return; } + this.continuousExportEventHandler = () => { + this.scheduleExport({ resync: this.resyncOnce() }); + }; + this.continuousExportEventHandler(); } disableContinuousExport() { - try { - if (!this.continuousExportEventHandler) { - log.info("continuous export already disabled"); - return; - } - log.info("disabling continuous export"); - eventBus.removeListener( - Events.LOCAL_FILES_UPDATED, - this.continuousExportEventHandler, - ); - this.continuousExportEventHandler = null; - } catch (e) { - log.error("failed to disableContinuousExport", e); - throw e; + if (!this.continuousExportEventHandler) { + log.warn("Continuous export already disabled"); + return; } + this.continuousExportEventHandler = null; } /** diff --git a/web/packages/shared/events/index.ts b/web/packages/shared/events/index.ts deleted file mode 100644 index fa71a9de63..0000000000 --- a/web/packages/shared/events/index.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { EventEmitter } from "eventemitter3"; - -// TODO: Remove me - -// When registering event handlers, -// handle errors to avoid unhandled rejection or propagation to emit call - -export enum Events { - LOCAL_FILES_UPDATED = "localFilesUpdated", -} - -export const eventBus = new EventEmitter();