From d1e82b92618a985720b1aa1a86ca77ca5a09b1fb Mon Sep 17 00:00:00 2001
From: laurenspriem <github_uni.fishers@aleeas.com>
Date: Sat, 23 Nov 2024 15:49:26 +0530
Subject: [PATCH] [mob][photos] Store face crop as state

---
 .../search/result/person_face_widget.dart     | 54 ++++++++++---------
 1 file changed, 29 insertions(+), 25 deletions(-)

diff --git a/mobile/lib/ui/viewer/search/result/person_face_widget.dart b/mobile/lib/ui/viewer/search/result/person_face_widget.dart
index 474de83a1a..fd1ac4fc7d 100644
--- a/mobile/lib/ui/viewer/search/result/person_face_widget.dart
+++ b/mobile/lib/ui/viewer/search/result/person_face_widget.dart
@@ -14,7 +14,7 @@ import "package:photos/ui/common/loading_widget.dart";
 import "package:photos/ui/viewer/file/thumbnail_widget.dart";
 import "package:photos/utils/face/face_box_crop.dart";
 
-class PersonFaceWidget extends StatelessWidget {
+class PersonFaceWidget extends StatefulWidget {
   final EnteFile file;
   final String? personId;
   final String? clusterID;
@@ -39,21 +39,25 @@ class PersonFaceWidget extends StatelessWidget {
           "PersonFaceWidget requires either personId or clusterID to be non-null",
         );
 
+  @override
+  State<PersonFaceWidget> createState() => _PersonFaceWidgetState();
+}
+
+class _PersonFaceWidgetState extends State<PersonFaceWidget> {
+  Future<Uint8List?>? faceCropFuture;
+
+  @override
+  void initState() {
+    super.initState();
+    faceCropFuture = widget.faceCrop != null
+        ? Future.value(widget.faceCrop)
+        : _getFaceCrop();
+  }
+
   @override
   Widget build(BuildContext context) {
-    if (faceCrop != null) {
-      return Stack(
-        fit: StackFit.expand,
-        children: [
-          Image(
-            image: MemoryImage(faceCrop!),
-            fit: BoxFit.cover,
-          ),
-        ],
-      );
-    }
     return FutureBuilder<Uint8List?>(
-      future: _getFaceCrop(),
+      future: faceCropFuture,
       builder: (context, snapshot) {
         if (snapshot.hasData) {
           final ImageProvider imageProvider = MemoryImage(snapshot.data!);
@@ -70,8 +74,8 @@ class PersonFaceWidget extends StatelessWidget {
           if (snapshot.hasError) {
             log('Error getting cover face for person: ${snapshot.error}');
           }
-          return thumbnailFallback
-              ? ThumbnailWidget(file)
+          return widget.thumbnailFallback
+              ? ThumbnailWidget(widget.file)
               : EnteLoadingWidget(
                   color: getEnteColorScheme(context).fillMuted,
                 );
@@ -82,11 +86,11 @@ class PersonFaceWidget extends StatelessWidget {
 
   Future<Uint8List?> _getFaceCrop() async {
     try {
-      EnteFile? fileForFaceCrop = file;
+      EnteFile? fileForFaceCrop = widget.file;
       String? personAvatarFaceID;
-      if (personId != null) {
+      if (widget.personId != null) {
         final PersonEntity? personEntity =
-            await PersonService.instance.getPerson(personId!);
+            await PersonService.instance.getPerson(widget.personId!);
         if (personEntity != null) {
           personAvatarFaceID = personEntity.data.avatarFaceID;
           if (personAvatarFaceID != null) {
@@ -94,9 +98,9 @@ class PersonFaceWidget extends StatelessWidget {
                 await checkGetCachedCropForFaceID(personAvatarFaceID);
             if (tryCache != null) return tryCache;
           }
-          if (personAvatarFaceID == null && cannotTrustFile) {
+          if (personAvatarFaceID == null && widget.cannotTrustFile) {
             final allFaces =
-                await MLDataDB.instance.getFaceIDsForPerson(personId!);
+                await MLDataDB.instance.getFaceIDsForPerson(widget.personId!);
             final allFileIDs = allFaces.map((e) => getFileIdFromFaceId(e));
             final fileIDToCreationTime =
                 await FilesDB.instance.getFileIDToCreationTime();
@@ -124,12 +128,12 @@ class PersonFaceWidget extends StatelessWidget {
       final Face? face = await MLDataDB.instance.getCoverFaceForPerson(
         recentFileID: fileForFaceCrop.uploadedFileID!,
         avatarFaceId: personAvatarFaceID,
-        personID: personId,
-        clusterID: clusterID,
+        personID: widget.personId,
+        clusterID: widget.clusterID,
       );
       if (face == null) {
         debugPrint(
-          "No cover face for person: $personId and cluster $clusterID and recentFile ${file.uploadedFileID}",
+          "No cover face for person: ${widget.personId} and cluster ${widget.clusterID} and recentFile ${widget.file.uploadedFileID}",
         );
         return null;
       }
@@ -141,12 +145,12 @@ class PersonFaceWidget extends StatelessWidget {
       final cropMap = await getCachedFaceCrops(
         fileForFaceCrop,
         [face],
-        useFullFile: useFullFile,
+        useFullFile: widget.useFullFile,
       );
       return cropMap?[face.faceID];
     } catch (e, s) {
       log(
-        "Error getting cover face for person: $personId and cluster $clusterID",
+        "Error getting cover face for person: ${widget.personId} and cluster ${widget.clusterID}",
         error: e,
         stackTrace: s,
       );