kenmirrors/ente
1
0
Fork 0
mirror of https://github.com/ente-io/ente.git synced 2025-08-08 07:28:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mob][photos] UX improvements on native video player

Browse Source
This commit is contained in:
ashilkn 2024-08-10 16:41:01 +05:30
parent c079ed12ca
commit c27017e77e
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
mobile/lib/ui/viewer/file/video_widget_native.dart
View File

@ -21,6 +21,7 @@ import "package:photos/ui/actions/file/file_actions.dart";
import "package:photos/ui/viewer/file/native_video_player_controls/play_pause_button.dart"; import "package:photos/ui/viewer/file/native_video_player_controls/play_pause_button.dart";
import "package:photos/ui/viewer/file/native_video_player_controls/seek_bar.dart"; import "package:photos/ui/viewer/file/native_video_player_controls/seek_bar.dart";
import "package:photos/ui/viewer/file/thumbnail_widget.dart"; import "package:photos/ui/viewer/file/thumbnail_widget.dart";
import "package:photos/utils/debouncer.dart";
import "package:photos/utils/dialog_util.dart"; import "package:photos/utils/dialog_util.dart";
import "package:photos/utils/exif_util.dart"; import "package:photos/utils/exif_util.dart";
import "package:photos/utils/file_util.dart"; import "package:photos/utils/file_util.dart";
@ -63,6 +64,7 @@ class _VideoWidgetNativeState extends State<VideoWidgetNative>
bool _isCompletelyVisible = false; bool _isCompletelyVisible = false;
final _showControls = ValueNotifier(true); final _showControls = ValueNotifier(true);
final _isSeeking = ValueNotifier(false); final _isSeeking = ValueNotifier(false);
final _debouncer = Debouncer(const Duration(milliseconds: 2000));
@override @override
void initState() { void initState() {
@ -144,8 +146,9 @@ class _VideoWidgetNativeState extends State<VideoWidgetNative>
.removeListener(_onPlaybackStatusChanged); .removeListener(_onPlaybackStatusChanged);
_isPlaybackReady.dispose(); _isPlaybackReady.dispose();
_showControls.dispose(); _showControls.dispose();
_isSeeking.removeListener(_isSeekingListener); _isSeeking.removeListener(_seekListener);
_isSeeking.dispose(); _isSeeking.dispose();
_debouncer.cancelDebounce();
super.dispose(); super.dispose();
} }
@ -395,7 +398,7 @@ class _VideoWidgetNativeState extends State<VideoWidgetNative>
controller.onPlaybackEnded.addListener(_onPlaybackEnded); controller.onPlaybackEnded.addListener(_onPlaybackEnded);
controller.onPlaybackReady.addListener(_onPlaybackReady); controller.onPlaybackReady.addListener(_onPlaybackReady);
controller.onPlaybackStatusChanged.addListener(_onPlaybackStatusChanged); controller.onPlaybackStatusChanged.addListener(_onPlaybackStatusChanged);
_isSeeking.addListener(_isSeekingListener); _isSeeking.addListener(_seekListener);
final videoSource = await VideoSource.init( final videoSource = await VideoSource.init(
path: _filePath!, path: _filePath!,
@ -407,12 +410,15 @@ class _VideoWidgetNativeState extends State<VideoWidgetNative>
} }
} }
void _isSeekingListener() { void _seekListener() {
if (!_isSeeking.value && if (!_isSeeking.value &&
_controller?.playbackInfo?.status == PlaybackStatus.playing) { _controller?.playbackInfo?.status == PlaybackStatus.playing) {
Future.delayed(const Duration(milliseconds: 2000), () { _debouncer.run(() async {
if (mounted) { if (mounted) {
if (_isSeeking.value) return; if (_isSeeking.value ||
_controller?.playbackInfo?.status != PlaybackStatus.playing) {
return;
}
_showControls.value = false; _showControls.value = false;
if (Platform.isIOS) { if (Platform.isIOS) {
widget.playbackCallback!(true); widget.playbackCallback!(true);
@ -430,9 +436,12 @@ class _VideoWidgetNativeState extends State<VideoWidgetNative>
} }
if (_controller!.playbackInfo?.status == PlaybackStatus.playing) { if (_controller!.playbackInfo?.status == PlaybackStatus.playing) {
if (widget.playbackCallback != null && mounted) { if (widget.playbackCallback != null && mounted) {
Future.delayed(const Duration(milliseconds: 2000), () { _debouncer.run(() async {
if (mounted) { if (mounted) {
if (_isSeeking.value) return; if (_isSeeking.value ||
_controller!.playbackInfo?.status != PlaybackStatus.playing) {
return;
}
_showControls.value = false; _showControls.value = false;
widget.playbackCallback!(true); widget.playbackCallback!(true);
} }