[mob][photos] Use better names to avoid potential confusion

This commit is contained in:
ashilkn
2024-11-25 18:50:08 +05:30
parent e2e2987e6e
commit 7d6688adff
8 changed files with 31 additions and 27 deletions

View File

@@ -1044,7 +1044,10 @@ class CollectionsService {
}
}
Future<Collection> getPublicCollection(BuildContext context, Uri uri) async {
Future<Collection> getCollectionFromPublicLink(
BuildContext context,
Uri uri,
) async {
final String? authToken = uri.queryParameters["t"];
final String albumKey = uri.fragment;
try {
@@ -1088,9 +1091,9 @@ class CollectionsService {
Future<bool> verifyPublicCollectionPassword(
BuildContext context,
String passwordHash,
int collectioID,
int collectionID,
) async {
final authToken = await getPublicAlbumToken(collectioID);
final authToken = await getSharedPublicAlbumToken(collectionID);
try {
final response = await _enteDio.post(
"https://api.ente.io/public-collection/verify-password",
@@ -1104,7 +1107,7 @@ class CollectionsService {
);
final jwtToken = response.data["jwtToken"];
if (response.statusCode == 200) {
await setPublicAlbumTokenJWT(collectioID, jwtToken);
await setPublicAlbumTokenJWT(collectionID, jwtToken);
return true;
}
return false;
@@ -1119,28 +1122,29 @@ class CollectionsService {
}
}
Future<String> getPublicAlbumKey(int collectionID) async {
Future<String> getSharedPublicAlbumKey(int collectionID) async {
if (_cachedPublicAlbumKey.containsKey(collectionID)) {
return _cachedPublicAlbumKey[collectionID]!;
}
return "";
}
Future<String?> getPublicAlbumToken(int collectionID) async {
Future<String?> getSharedPublicAlbumToken(int collectionID) async {
if (_cachedPublicAlbumToken.containsKey(collectionID)) {
return _cachedPublicAlbumToken[collectionID];
}
return null;
}
Future<String?> getPublicAlbumTokenJWT(int collectionID) async {
Future<String?> getSharedPublicAlbumTokenJWT(int collectionID) async {
if (_cachedPublicAlbumJWT.containsKey(collectionID)) {
return _cachedPublicAlbumJWT[collectionID];
}
return null;
}
bool isPublicCollection(int collectionID) {
/// Is a public link opened in the app
bool isSharedPublicCollection(int collectionID) {
return _cachedPublicCollectionID.contains(collectionID);
}

View File

@@ -263,8 +263,8 @@ class _HomeWidgetState extends State<HomeWidget> {
Future<void> _handlePublicAlbumLink(Uri uri) async {
try {
final Collection collection =
await CollectionsService.instance.getPublicCollection(context, uri);
final Collection collection = await CollectionsService.instance
.getCollectionFromPublicLink(context, uri);
if (collection.owner!.id! == Configuration.instance.getUserID()) {
await routeToPage(

View File

@@ -15,8 +15,8 @@ class AddedByWidget extends StatelessWidget {
if (!file.isUploaded) {
return const SizedBox.shrink();
}
final bool isPublicFile =
CollectionsService.instance.isPublicCollection(file.collectionID!);
final bool isPublicFile = CollectionsService.instance
.isSharedPublicCollection(file.collectionID!);
if (isPublicFile) {
return const SizedBox.shrink();
}

View File

@@ -40,8 +40,8 @@ class GalleryFileWidget extends StatelessWidget {
final isFileSelected = selectedFiles?.isFileSelected(file) ?? false;
bool isPublicFile = false;
if (file.collectionID != null) {
isPublicFile =
CollectionsService.instance.isPublicCollection(file.collectionID!);
isPublicFile = CollectionsService.instance
.isSharedPublicCollection(file.collectionID!);
}
Color selectionColor = Colors.white;
if (isFileSelected && file.isUploaded && file.ownerID != currentUserID) {

View File

@@ -848,9 +848,9 @@ class _GalleryAppBarWidgetState extends State<GalleryAppBarWidget> {
if (galleryType == GalleryType.sharedPublicCollection &&
collection!.isCollectEnabledForPublicLink()) {
final authToken = await CollectionsService.instance
.getPublicAlbumToken(collection.id);
final albumKey =
await CollectionsService.instance.getPublicAlbumKey(authToken!);
.getSharedPublicAlbumToken(collection.id);
final albumKey = await CollectionsService.instance
.getSharedPublicAlbumKey(collection.id);
final res = await showChoiceDialog(
context,

View File

@@ -23,10 +23,10 @@ class DiffFetcher {
int collectionID,
) async {
try {
final authToken =
await CollectionsService.instance.getPublicAlbumToken(collectionID);
final authToken = await CollectionsService.instance
.getSharedPublicAlbumToken(collectionID);
final authJWTToken = await CollectionsService.instance
.getPublicAlbumTokenJWT(collectionID);
.getSharedPublicAlbumTokenJWT(collectionID);
final headers = {
"X-Auth-Access-Token": authToken,

View File

@@ -39,7 +39,7 @@ Future<File?> downloadAndDecryptPublicFile(
try {
final authJWTToken = await CollectionsService.instance
.getPublicAlbumTokenJWT(file.collectionID!);
.getSharedPublicAlbumTokenJWT(file.collectionID!);
final headers = {
"X-Auth-Access-Token": authToken,
@@ -98,9 +98,9 @@ Future<File?> downloadAndDecrypt(
ProgressCallback? progressCallback,
}) async {
if (await CollectionsService.instance
.isPublicCollection(file.collectionID!)) {
.isSharedPublicCollection(file.collectionID!)) {
final authToken = await CollectionsService.instance
.getPublicAlbumToken(file.collectionID!);
.getSharedPublicAlbumToken(file.collectionID!);
return await downloadAndDecryptPublicFile(
file,

View File

@@ -161,12 +161,12 @@ Future<void> _downloadAndDecryptThumbnail(FileDownloadItem item) async {
final file = item.file;
Uint8List encryptedThumbnail;
try {
if (await CollectionsService.instance
.isPublicCollection(file.collectionID!)) {
if (CollectionsService.instance
.isSharedPublicCollection(file.collectionID!)) {
final authToken = await CollectionsService.instance
.getPublicAlbumToken(file.collectionID!);
.getSharedPublicAlbumToken(file.collectionID!);
final authJWTToken = await CollectionsService.instance
.getPublicAlbumTokenJWT(file.collectionID!);
.getSharedPublicAlbumTokenJWT(file.collectionID!);
final headers = {
"X-Auth-Access-Token": authToken,