Scope

web/packages/accounts/components/Verify2FACodeForm.tsx

@@ -71,7 +71,7 @@ export const Verify2FACodeForm: React.FC<Verify2FACodeFormProps> = ({
 
     useEffect(() => {
         if (values.otp.length == 6 && !isSubmitting) void submitForm();
-    }, [values, isSubmitting]);
+    }, [values, isSubmitting, submitForm]);
 
     return (
         <form onSubmit={handleSubmit}>

web/packages/accounts/eslint.config.mjs

@@ -4,10 +4,7 @@ export default [
     ...config,
     {
         rules: {
-            /* TODO:
-             * "This rule requires the `strictNullChecks` compiler option to be
-             * turned on to function correctly"
-             */
+            /* TODO: */
             "@typescript-eslint/no-unnecessary-condition": "off",
             "@typescript-eslint/no-unsafe-assignment": "off",
             "@typescript-eslint/no-explicit-any": "off",
@@ -15,8 +12,6 @@ export default [
             "@typescript-eslint/no-unsafe-member-access": "off",
             "@typescript-eslint/no-unsafe-argument": "off",
             "@typescript-eslint/no-unsafe-call": "off",
-            /** TODO: Disabled as we migrate, try to prune these again */
-            "react-hooks/exhaustive-deps": "off",
         },
     },
 ];

web/packages/accounts/pages/change-email.tsx

@@ -27,7 +27,7 @@ const Page: React.FC = () => {
         if (!user?.token) {
             void router.push("/");
         }
-    }, []);
+    }, [router]);
 
     return (
         <AccountsPageContents>

web/packages/accounts/pages/change-password.tsx

@@ -50,7 +50,7 @@ const Page: React.FC = () => {
         } else {
             setToken(user.token);
         }
-    }, []);
+    }, [router]);
 
     const onSubmit: SetPasswordFormProps["callback"] = async (
         passphrase,

web/packages/accounts/pages/credentials.tsx

@@ -199,9 +199,10 @@ const Page: React.FC = () => {
             }
         };
         void main();
+        // TODO: validateSession is a dependency, but add that only after we've
+        // wrapped items from the callback (like logout) in useCallback too.
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
-    // TODO: ^ validateSession is a dependency, but add that only after we've
-    // wrapped items from the callback (like logout) in useCallback too.
 
     const getKeyAttributes: VerifyMasterPasswordFormProps["getKeyAttributes"] =
         async (kek: string) => {

web/packages/accounts/pages/generate.tsx

@@ -65,7 +65,7 @@ const Page: React.FC = () => {
             setToken(user.token);
             setLoading(false);
         }
-    }, []);
+    }, [router]);
 
     const onSubmit: SetPasswordFormProps["callback"] = async (
         passphrase,

web/packages/accounts/pages/login.tsx

@@ -20,7 +20,7 @@ const Page: React.FC = () => {
             void router.push(PAGES.VERIFY);
         }
         setLoading(false);
-    }, []);
+    }, [router]);
 
     const onSignUp = () => void router.push(PAGES.SIGNUP);
 

web/packages/accounts/pages/passkeys/finish.tsx

@@ -33,7 +33,7 @@ const Page: React.FC = () => {
         void saveCredentialsAndNavigateTo(passkeySessionID, response).then(
             (slug: string) => router.push(slug),
         );
-    }, []);
+    }, [router]);
 
     return <LoadingIndicator />;
 };

web/packages/accounts/pages/recover.tsx

@@ -59,7 +59,7 @@ const Page: React.FC = () => {
         } else {
             setKeyAttributes(keyAttributes);
         }
-    }, []);
+    }, [router]);
 
     const recover: SingleInputFormProps["callback"] = async (
         recoveryKey: string,

web/packages/accounts/pages/signup.tsx

@@ -20,7 +20,7 @@ const Page: React.FC = () => {
             void router.push(PAGES.VERIFY);
         }
         setLoading(false);
-    }, []);
+    }, [router]);
 
     const onLogin = () => void router.push(PAGES.LOGIN);
 

web/packages/accounts/pages/two-factor/recover.tsx

@@ -92,6 +92,8 @@ const Page: React.FC<RecoverPageProps> = ({ twoFactorType }) => {
             }
         };
         void main();
+        // TODO:
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
 
     const recover: SingleInputFormProps["callback"] = async (

web/packages/accounts/pages/two-factor/verify.tsx

@@ -40,7 +40,7 @@ const Page: React.FC = () => {
         } else {
             setSessionID(user.twoFactorSessionID);
         }
-    }, []);
+    }, [router]);
 
     const handleSubmit = async (otp: string) => {
         try {

web/packages/accounts/pages/verify.tsx

@@ -74,7 +74,7 @@ const Page: React.FC = () => {
             }
         };
         void main();
-    }, []);
+    }, [router]);
 
     const onSubmit: SingleInputFormProps["callback"] = async (
         ott,