kenmirrors/ente
1
0
Fork 0
mirror of https://github.com/ente-io/ente.git synced 2025-08-14 10:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tune semantics

Browse Source
This commit is contained in:
Manav Rathi
2024-10-10 16:27:00 +05:30
parent dde2b8894a
commit 151c50f7af
1 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
web/packages/base/components/MiniDialog.tsx
View File

@@ -71,22 +71,17 @@ export interface MiniDialogAttributes {
* is opened, allowing the user to confirm just by pressing ENTER.
*/
autoFocus?: boolean;
/**
* If `true`, close the dialog after {@link action} completes.
* TODO: Test/Impl/Is this needed?
*/
autoClose?: boolean;
/**
* The function to call when the user activates the button.
*
* Default is to close the dialog.
* If this function returns a promise, then an activity indicator will
* be shown on the button until the promise settles.
*
* It is passed a {@link setLoading} function that can be used to show
* or hide loading indicator or the primary action button.
* If this function is not provided, or if the function completes /
* fullfills, then then the dialog is automatically closed. Otherwise
* (that is, if the provided function throws), the dialog remains open.
*/
action?:
| (() => void | Promise<void>)
| ((setLoading: (value: boolean) => void) => void | Promise<void>);
action?: () => void | Promise<void>;
};
/**
* The string to use as the label for the cancel button.
@@ -185,8 +180,14 @@ export const AttributedMiniDialog: React.FC<
color={attributes.continue.color ?? "accent"}
autoFocus={attributes.continue.autoFocus}
onClick={async () => {
await attributes.continue?.action?.(setLoading);
onClose();
setLoading(true);
try {
await attributes.continue?.action?.();
setLoading(false);
onClose();
} catch {
setLoading(false);
}
}}
>
{attributes.continue.text ?? t("ok")}