Matthew Jordan f4fd1b2fb0 Change SHARED function to use a safe traversal when modifying a variable ...

When the SHARED function modifies a variable, it removes it from its list of
variables and reinserts the new value at the head of the list of variables.
Doing this inside a standard list traversal can be dangerous, as the
standard list traversal does not account for the list being changed.  While
the code in question should not cause a use after free violation due to its
breaking out of the loop after freeing the variable, it could lead to a
maintenance issue if the loop was modified.  This also fixes a violation
reported by a static analysis tool, which also makes this code easier to
maintain in the future. 
........

Merged revisions 361657 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 361658 from http://svn.asterisk.org/svn/asterisk/branches/10


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@361659 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2012-04-09 19:44:35 +00:00

..

func_aes.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_audiohookinherit.c

Replace direct access to channel name with accessor functions

2012-01-09 22:15:50 +00:00

func_base64.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_blacklist.c

Opaquify ast_channel structs and lists

2012-02-29 16:52:47 +00:00

func_callcompletion.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_callerid.c

Opaquify ast_channel structs and lists

2012-02-29 16:52:47 +00:00

func_cdr.c

ast_channel opaquification of pointers and integral types

2012-02-20 23:43:27 +00:00

func_channel.c

Add missing newlines to CLI logging

2012-04-06 18:19:03 +00:00

func_config.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_curl.c

func_curl: Fix leak of an ast_str in error handling code path.

2012-03-24 23:49:39 +00:00

func_cut.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_db.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_devstate.c

Make 'help devstate change' display properly (get rid of excess comma)

2012-04-04 19:32:57 +00:00

func_dialgroup.c

Remove invalid flag given to iterator in func_dialgroup.c

2011-11-03 19:57:49 +00:00

func_dialplan.c

Enable macros in 1.8 to find the next highest "h" extension in a context, like in 1.4.

2012-03-13 08:06:20 +00:00

func_enum.c

Allow ENUM query functions to report lookup errors

2011-08-09 17:08:33 +00:00

func_env.c

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-02-08 20:49:48 +00:00

func_extstate.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_frame_trace.c

Replace direct access to channel name with accessor functions

2012-01-09 22:15:50 +00:00

func_global.c

Change SHARED function to use a safe traversal when modifying a variable

2012-04-09 19:44:35 +00:00

func_groupcount.c

Replace direct access to channel name with accessor functions

2012-01-09 22:15:50 +00:00

func_iconv.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_jitterbuffer.c

ast_channel opaquification of pointers and integral types

2012-02-20 23:43:27 +00:00

func_lock.c

Fix absolute/relative time mismatch in LOCK function.

2012-01-10 22:10:18 +00:00

func_logic.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_math.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_md5.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_module.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_odbc.c

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-02-08 20:49:48 +00:00

func_pitchshift.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_rand.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_realtime.c

Add Function and Application Relationships to documentation

2011-01-30 00:22:59 +00:00

func_sha1.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_shell.c

Merged revisions 331576 via svnmerge from

2011-08-11 21:44:08 +00:00

func_speex.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_sprintf.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_srv.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_strings.c

Add missing newlines to CLI logging

2012-04-06 18:19:03 +00:00

func_sysinfo.c

Multiple revisions 361403,361412

2012-04-06 16:33:24 +00:00

func_timeout.c

Opaquify ast_channel structs and lists

2012-02-29 16:52:47 +00:00

func_uri.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_version.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_vmcount.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

func_volume.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

Makefile

Merged revisions 207647 via svnmerge from

2009-07-21 13:28:04 +00:00