mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-03 03:20:57 +00:00
This patch addresses issues during immediate shutdowns, where modules are not unloaded, but Asterisk atexit handlers are run. In the typical case, this usually isn't a big deal. But the introduction of the Stasis message bus makes it much more likely for asynchronous activity to be happening off in some thread during shutdown. During an immediate shutdown, Asterisk skips unloading modules. But while it is processing the atexit handlers, there is a window of time where some of the core message types have been cleaned up, but the message bus is still running. Specifically, it's still running module subscriptions that might be using the core message types. If a message is received by that subscription in that window, it will attempt to use a message type that has been cleaned up. To solve this problem, this patch introduces ast_register_cleanup(). This function operates identically to ast_register_atexit(), except that cleanup calls are not invoked on an immediate shutdown. All of the core message type and topic cleanup was moved from atexit handlers to cleanup handlers. This ensures that core type and topic cleanup only happens if the modules that used them are first unloaded. This patch also changes the ast_assert() when accessing a cleaned up or uninitialized message type to an error log message. Message type functions are actually NULL safe across the board, so the assert was a bit heavy handed. Especially for anyone with DO_CRASH enabled. Review: https://reviewboard.asterisk.org/r/2562/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@390122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
470 lines
12 KiB
C
470 lines
12 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2013, Digium, Inc.
|
|
*
|
|
* David M. Lee, II <dlee@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*! \file
|
|
*
|
|
* \brief Stasis Message API.
|
|
*
|
|
* \author David M. Lee, II <dlee@digium.com>
|
|
*/
|
|
|
|
/*** MODULEINFO
|
|
<support_level>core</support_level>
|
|
***/
|
|
|
|
#include "asterisk.h"
|
|
|
|
ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
|
|
|
|
#include "asterisk/astobj2.h"
|
|
#include "asterisk/hashtab.h"
|
|
#include "asterisk/stasis.h"
|
|
#include "asterisk/utils.h"
|
|
|
|
#ifdef LOW_MEMORY
|
|
#define NUM_CACHE_BUCKETS 17
|
|
#else
|
|
#define NUM_CACHE_BUCKETS 563
|
|
#endif
|
|
|
|
/*! \internal */
|
|
struct stasis_caching_topic {
|
|
struct ao2_container *cache;
|
|
struct stasis_topic *topic;
|
|
struct stasis_subscription *sub;
|
|
snapshot_get_id id_fn;
|
|
};
|
|
|
|
static void stasis_caching_topic_dtor(void *obj) {
|
|
struct stasis_caching_topic *caching_topic = obj;
|
|
ast_assert(!stasis_subscription_is_subscribed(caching_topic->sub));
|
|
ast_assert(stasis_subscription_is_done(caching_topic->sub));
|
|
ao2_cleanup(caching_topic->sub);
|
|
caching_topic->sub = NULL;
|
|
ao2_cleanup(caching_topic->cache);
|
|
caching_topic->cache = NULL;
|
|
ao2_cleanup(caching_topic->topic);
|
|
caching_topic->topic = NULL;
|
|
}
|
|
|
|
struct stasis_topic *stasis_caching_get_topic(struct stasis_caching_topic *caching_topic)
|
|
{
|
|
return caching_topic->topic;
|
|
}
|
|
|
|
struct stasis_caching_topic *stasis_caching_unsubscribe(struct stasis_caching_topic *caching_topic)
|
|
{
|
|
if (caching_topic) {
|
|
if (stasis_subscription_is_subscribed(caching_topic->sub)) {
|
|
/* Increment the reference to hold on to it past the
|
|
* unsubscribe */
|
|
ao2_ref(caching_topic->sub, +1);
|
|
stasis_unsubscribe(caching_topic->sub);
|
|
} else {
|
|
ast_log(LOG_ERROR, "stasis_caching_topic unsubscribed multiple times\n");
|
|
}
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
struct stasis_caching_topic *stasis_caching_unsubscribe_and_join(struct stasis_caching_topic *caching_topic)
|
|
{
|
|
if (!caching_topic) {
|
|
return NULL;
|
|
}
|
|
|
|
/* Hold a ref past the unsubscribe */
|
|
ao2_ref(caching_topic, +1);
|
|
stasis_caching_unsubscribe(caching_topic);
|
|
stasis_subscription_join(caching_topic->sub);
|
|
ao2_cleanup(caching_topic);
|
|
return NULL;
|
|
}
|
|
|
|
struct cache_entry {
|
|
struct stasis_message_type *type;
|
|
char *id;
|
|
struct stasis_message *snapshot;
|
|
};
|
|
|
|
static void cache_entry_dtor(void *obj)
|
|
{
|
|
struct cache_entry *entry = obj;
|
|
ao2_cleanup(entry->type);
|
|
entry->type = NULL;
|
|
ast_free(entry->id);
|
|
entry->id = NULL;
|
|
ao2_cleanup(entry->snapshot);
|
|
entry->snapshot = NULL;
|
|
}
|
|
|
|
static struct cache_entry *cache_entry_create(struct stasis_message_type *type, const char *id, struct stasis_message *snapshot)
|
|
{
|
|
RAII_VAR(struct cache_entry *, entry, NULL, ao2_cleanup);
|
|
|
|
ast_assert(type != NULL);
|
|
ast_assert(id != NULL);
|
|
|
|
entry = ao2_alloc(sizeof(*entry), cache_entry_dtor);
|
|
if (!entry) {
|
|
return NULL;
|
|
}
|
|
|
|
entry->id = ast_strdup(id);
|
|
if (!entry->id) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(type, +1);
|
|
entry->type = type;
|
|
if (snapshot != NULL) {
|
|
ao2_ref(snapshot, +1);
|
|
entry->snapshot = snapshot;
|
|
}
|
|
|
|
ao2_ref(entry, +1);
|
|
return entry;
|
|
}
|
|
|
|
static int cache_entry_hash(const void *obj, int flags)
|
|
{
|
|
const struct cache_entry *entry = obj;
|
|
int hash = 0;
|
|
|
|
ast_assert(!(flags & OBJ_KEY));
|
|
|
|
hash += ast_hashtab_hash_string(stasis_message_type_name(entry->type));
|
|
hash += ast_hashtab_hash_string(entry->id);
|
|
return hash;
|
|
}
|
|
|
|
static int cache_entry_cmp(void *obj, void *arg, int flags)
|
|
{
|
|
const struct cache_entry *left = obj;
|
|
const struct cache_entry *right = arg;
|
|
|
|
ast_assert(!(flags & OBJ_KEY));
|
|
|
|
if (left->type == right->type && strcmp(left->id, right->id) == 0) {
|
|
return CMP_MATCH | CMP_STOP;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct stasis_message *cache_put(struct stasis_caching_topic *caching_topic, struct stasis_message_type *type, const char *id, struct stasis_message *new_snapshot)
|
|
{
|
|
RAII_VAR(struct cache_entry *, new_entry, NULL, ao2_cleanup);
|
|
RAII_VAR(struct cache_entry *, cached_entry, NULL, ao2_cleanup);
|
|
struct stasis_message *old_snapshot = NULL;
|
|
|
|
ast_assert(caching_topic->cache != NULL);
|
|
|
|
new_entry = cache_entry_create(type, id, new_snapshot);
|
|
|
|
if (new_snapshot == NULL) {
|
|
/* Remove entry from cache */
|
|
cached_entry = ao2_find(caching_topic->cache, new_entry, OBJ_POINTER | OBJ_UNLINK);
|
|
if (cached_entry) {
|
|
old_snapshot = cached_entry->snapshot;
|
|
cached_entry->snapshot = NULL;
|
|
}
|
|
} else {
|
|
/* Insert/update cache */
|
|
SCOPED_AO2LOCK(lock, caching_topic->cache);
|
|
|
|
cached_entry = ao2_find(caching_topic->cache, new_entry, OBJ_POINTER | OBJ_NOLOCK);
|
|
if (cached_entry) {
|
|
/* Update cache. Because objects are moving, no need to update refcounts. */
|
|
old_snapshot = cached_entry->snapshot;
|
|
cached_entry->snapshot = new_entry->snapshot;
|
|
new_entry->snapshot = NULL;
|
|
} else {
|
|
/* Insert into the cache */
|
|
ao2_link_flags(caching_topic->cache, new_entry, OBJ_NOLOCK);
|
|
}
|
|
|
|
}
|
|
|
|
return old_snapshot;
|
|
}
|
|
|
|
struct stasis_message *stasis_cache_get(struct stasis_caching_topic *caching_topic, struct stasis_message_type *type, const char *id)
|
|
{
|
|
RAII_VAR(struct cache_entry *, search_entry, NULL, ao2_cleanup);
|
|
RAII_VAR(struct cache_entry *, cached_entry, NULL, ao2_cleanup);
|
|
|
|
ast_assert(caching_topic->cache != NULL);
|
|
|
|
search_entry = cache_entry_create(type, id, NULL);
|
|
if (search_entry == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
cached_entry = ao2_find(caching_topic->cache, search_entry, OBJ_POINTER);
|
|
if (cached_entry == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
ast_assert(cached_entry->snapshot != NULL);
|
|
ao2_ref(cached_entry->snapshot, +1);
|
|
return cached_entry->snapshot;
|
|
}
|
|
|
|
struct cache_dump_data {
|
|
struct ao2_container *cached;
|
|
struct stasis_message_type *type;
|
|
};
|
|
|
|
static int cache_dump_cb(void *obj, void *arg, int flags)
|
|
{
|
|
struct cache_dump_data *cache_dump = arg;
|
|
struct cache_entry *entry = obj;
|
|
|
|
if (!cache_dump->type || entry->type == cache_dump->type) {
|
|
ao2_link(cache_dump->cached, entry->snapshot);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct ao2_container *stasis_cache_dump(struct stasis_caching_topic *caching_topic, struct stasis_message_type *type)
|
|
{
|
|
struct cache_dump_data cache_dump;
|
|
|
|
ast_assert(caching_topic->cache != NULL);
|
|
|
|
cache_dump.type = type;
|
|
cache_dump.cached = ao2_container_alloc(1, NULL, NULL);
|
|
if (!cache_dump.cached) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_callback(caching_topic->cache, OBJ_MULTIPLE | OBJ_NODATA, cache_dump_cb, &cache_dump);
|
|
return cache_dump.cached;
|
|
}
|
|
|
|
STASIS_MESSAGE_TYPE_DEFN(stasis_cache_clear_type);
|
|
STASIS_MESSAGE_TYPE_DEFN(stasis_cache_update_type);
|
|
|
|
static void cache_clear_dtor(void *obj)
|
|
{
|
|
struct stasis_cache_clear *ev = obj;
|
|
ao2_cleanup(ev->type);
|
|
ev->type = NULL;
|
|
}
|
|
|
|
struct stasis_message *stasis_cache_clear_create(struct stasis_message_type *type, const char *id)
|
|
{
|
|
RAII_VAR(struct stasis_cache_clear *, ev, NULL, ao2_cleanup);
|
|
RAII_VAR(struct stasis_message *, msg, NULL, ao2_cleanup);
|
|
|
|
ev = ao2_alloc(sizeof(*ev) + strlen(id) + 1, cache_clear_dtor);
|
|
if (!ev) {
|
|
return NULL;
|
|
}
|
|
|
|
/* strcpy safe */
|
|
strcpy(ev->id, id);
|
|
ao2_ref(type, +1);
|
|
ev->type = type;
|
|
|
|
msg = stasis_message_create(stasis_cache_clear_type(), ev);
|
|
|
|
if (!msg) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(msg, +1);
|
|
return msg;
|
|
}
|
|
|
|
static void stasis_cache_update_dtor(void *obj)
|
|
{
|
|
struct stasis_cache_update *update = obj;
|
|
ao2_cleanup(update->topic);
|
|
update->topic = NULL;
|
|
ao2_cleanup(update->old_snapshot);
|
|
update->old_snapshot = NULL;
|
|
ao2_cleanup(update->new_snapshot);
|
|
update->new_snapshot = NULL;
|
|
ao2_cleanup(update->type);
|
|
update->type = NULL;
|
|
}
|
|
|
|
static struct stasis_message *update_create(struct stasis_topic *topic, struct stasis_message *old_snapshot, struct stasis_message *new_snapshot)
|
|
{
|
|
RAII_VAR(struct stasis_cache_update *, update, NULL, ao2_cleanup);
|
|
RAII_VAR(struct stasis_message *, msg, NULL, ao2_cleanup);
|
|
|
|
ast_assert(topic != NULL);
|
|
ast_assert(old_snapshot != NULL || new_snapshot != NULL);
|
|
|
|
update = ao2_alloc(sizeof(*update), stasis_cache_update_dtor);
|
|
if (!update) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(topic, +1);
|
|
update->topic = topic;
|
|
if (old_snapshot) {
|
|
ao2_ref(old_snapshot, +1);
|
|
update->old_snapshot = old_snapshot;
|
|
if (!new_snapshot) {
|
|
ao2_ref(stasis_message_type(old_snapshot), +1);
|
|
update->type = stasis_message_type(old_snapshot);
|
|
}
|
|
}
|
|
if (new_snapshot) {
|
|
ao2_ref(new_snapshot, +1);
|
|
update->new_snapshot = new_snapshot;
|
|
ao2_ref(stasis_message_type(new_snapshot), +1);
|
|
update->type = stasis_message_type(new_snapshot);
|
|
}
|
|
|
|
msg = stasis_message_create(stasis_cache_update_type(), update);
|
|
if (!msg) {
|
|
return NULL;
|
|
}
|
|
|
|
ao2_ref(msg, +1);
|
|
return msg;
|
|
}
|
|
|
|
static void caching_topic_exec(void *data, struct stasis_subscription *sub, struct stasis_topic *topic, struct stasis_message *message)
|
|
{
|
|
RAII_VAR(struct stasis_caching_topic *, caching_topic_needs_unref, NULL, ao2_cleanup);
|
|
struct stasis_caching_topic *caching_topic = data;
|
|
const char *id = NULL;
|
|
|
|
ast_assert(caching_topic->topic != NULL);
|
|
ast_assert(caching_topic->id_fn != NULL);
|
|
|
|
if (stasis_subscription_final_message(sub, message)) {
|
|
caching_topic_needs_unref = caching_topic;
|
|
}
|
|
|
|
/* Handle cache clear event */
|
|
if (stasis_cache_clear_type() == stasis_message_type(message)) {
|
|
RAII_VAR(struct stasis_message *, old_snapshot, NULL, ao2_cleanup);
|
|
RAII_VAR(struct stasis_message *, update, NULL, ao2_cleanup);
|
|
struct stasis_cache_clear *clear = stasis_message_data(message);
|
|
ast_assert(clear->type != NULL);
|
|
ast_assert(clear->id != NULL);
|
|
old_snapshot = cache_put(caching_topic, clear->type, clear->id, NULL);
|
|
if (old_snapshot) {
|
|
update = update_create(topic, old_snapshot, NULL);
|
|
stasis_publish(caching_topic->topic, update);
|
|
} else {
|
|
/* While this could be a problem, it's very likely to
|
|
* happen with message forwarding */
|
|
ast_debug(1,
|
|
"Attempting to remove an item from the cache that isn't there: %s %s\n",
|
|
stasis_message_type_name(clear->type), clear->id);
|
|
}
|
|
return;
|
|
}
|
|
|
|
id = caching_topic->id_fn(message);
|
|
if (id == NULL) {
|
|
/* Object isn't cached; forward */
|
|
stasis_forward_message(caching_topic->topic, topic, message);
|
|
} else {
|
|
/* Update the cache */
|
|
RAII_VAR(struct stasis_message *, old_snapshot, NULL, ao2_cleanup);
|
|
RAII_VAR(struct stasis_message *, update, NULL, ao2_cleanup);
|
|
|
|
old_snapshot = cache_put(caching_topic, stasis_message_type(message), id, message);
|
|
|
|
update = update_create(topic, old_snapshot, message);
|
|
if (update == NULL) {
|
|
return;
|
|
}
|
|
|
|
stasis_publish(caching_topic->topic, update);
|
|
}
|
|
|
|
if (stasis_subscription_final_message(sub, message)) {
|
|
ao2_cleanup(caching_topic);
|
|
}
|
|
}
|
|
|
|
struct stasis_caching_topic *stasis_caching_topic_create(struct stasis_topic *original_topic, snapshot_get_id id_fn)
|
|
{
|
|
RAII_VAR(struct stasis_caching_topic *, caching_topic, NULL, ao2_cleanup);
|
|
struct stasis_subscription *sub;
|
|
RAII_VAR(char *, new_name, NULL, free);
|
|
int ret;
|
|
|
|
ret = asprintf(&new_name, "%s-cached", stasis_topic_name(original_topic));
|
|
if (ret < 0) {
|
|
return NULL;
|
|
}
|
|
|
|
caching_topic = ao2_alloc(sizeof(*caching_topic), stasis_caching_topic_dtor);
|
|
if (caching_topic == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
caching_topic->cache = ao2_container_alloc(NUM_CACHE_BUCKETS, cache_entry_hash, cache_entry_cmp);
|
|
if (!caching_topic->cache) {
|
|
ast_log(LOG_ERROR, "Stasis cache allocation failed\n");
|
|
return NULL;
|
|
}
|
|
|
|
caching_topic->topic = stasis_topic_create(new_name);
|
|
if (caching_topic->topic == NULL) {
|
|
return NULL;
|
|
}
|
|
|
|
caching_topic->id_fn = id_fn;
|
|
|
|
sub = stasis_subscribe(original_topic, caching_topic_exec, caching_topic);
|
|
if (sub == NULL) {
|
|
return NULL;
|
|
}
|
|
/* This is for the reference contained in the subscription above */
|
|
ao2_ref(caching_topic, +1);
|
|
caching_topic->sub = sub;
|
|
|
|
ao2_ref(caching_topic, +1);
|
|
return caching_topic;
|
|
}
|
|
|
|
static void stasis_cache_cleanup(void)
|
|
{
|
|
STASIS_MESSAGE_TYPE_CLEANUP(stasis_cache_clear_type);
|
|
STASIS_MESSAGE_TYPE_CLEANUP(stasis_cache_update_type);
|
|
}
|
|
|
|
int stasis_cache_init(void)
|
|
{
|
|
ast_register_cleanup(stasis_cache_cleanup);
|
|
|
|
if (STASIS_MESSAGE_TYPE_INIT(stasis_cache_clear_type) != 0) {
|
|
return -1;
|
|
}
|
|
|
|
if (STASIS_MESSAGE_TYPE_INIT(stasis_cache_update_type) != 0) {
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|