Joshua C. Colp 8d6c2221a9 pbx: Fix hints deadlock between reload and ExtensionState. ...

When the ExtensionState AMI action is executed on a pattern matched
hint it can end up adding a new hint if one does not already exist.
This results in a locking order of contexts -> hints -> contexts.

If at the same time a reload is occurring and adding its own hint
it will have a locking order of hints -> contexts.

This results in a deadlock as one thread wants a lock on contexts
that the other has, and the other thread wants a lock on hints
that the other has.

This change enforces a hints -> contexts locking order by explicitly
locking hints in the places where a hint is added when queried for.
This matches the order seen through normal adding of hints.

ASTERISK-29046

Change-Id: I49f027f4aab5d2d50855ae937bcf5e2fd8bfc504

2020-08-28 04:32:04 -05:00

..

editline

Remove #include <sys/cdefs.h>

2020-05-05 09:22:51 -05:00

stdtime

Merge "BuildSystem: Cast any intptr_t explicitly to its proposed type." into 13

2018-03-06 11:23:50 -06:00

.gitignore

…

abstract_jb.c

abstract_jb: Remove silly usage of RAII_VAR.

2017-11-20 15:02:21 -05:00

acl.c

acl.c: Coerce a NULL pointer into the empty string

2020-07-20 09:57:52 -05:00

adsi.c

…

alaw.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

alertpipe.c

utils: Wrap socket() and pipe() to reduce syscalls

2018-12-07 08:57:02 -05:00

aoc.c

various modules: json integer overflow

2019-08-01 16:22:01 -05:00

app.c

app.c: make sure that no non-async-signal-safe syscalls are used after

2020-05-06 06:40:12 -05:00

ast_expr2.c

Remove #include <sys/cdefs.h>

2020-05-05 09:22:51 -05:00

ast_expr2.fl

…

ast_expr2.h

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

ast_expr2.y

Remove #include <sys/cdefs.h>

2020-05-05 09:22:51 -05:00

ast_expr2f.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

asterisk.c

utf8.c: Add UTF-8 validation and utility functions

2020-07-27 17:30:17 -05:00

asterisk.dynamics

…

asterisk.exports.in

stasis: Add statistics gathering in developer mode.

2018-12-12 13:14:04 -04:00

astfd.c

main/astfd: Fix GCC8 format-truncation warning.

2018-10-12 13:16:29 -04:00

astmm.c

astmm.c: Display backtrace with memory show allocations

2019-09-23 06:20:23 -06:00

astobj2_container_private.h

…

astobj2_container.c

astobj2: Comment on OBJ_NOLOCK in ao2_container_clone.

2018-10-03 12:02:35 -04:00

astobj2_global.c

core: Fix ABI mismatch of ao2_global_obj.

2019-09-24 12:24:15 -04:00

astobj2_hash.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

astobj2_private.h

…

astobj2_rbtree.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

astobj2.c

core: Fix ABI mismatch of ao2_global_obj.

2019-09-24 12:24:15 -04:00

audiohook.c

audiohook: Don't allow audiohooks to attach to hung up channels.

2020-03-13 09:56:11 -05:00

autochan.c

autochan/mixmonitor/chanspy: Fix unsafe channel locking and references.

2017-03-15 17:43:54 -05:00

autoservice.c

autoservice: Don't start channel autoservice if the thread is a user interface.

2018-06-19 14:13:07 -05:00

backtrace.c

main/backtrace: binutils-2.34 fix.

2020-04-06 10:58:11 -05:00

bridge_after.c

stasis/control: Fix possible deadlock with swap channel

2017-09-06 12:41:25 -05:00

bridge_basic.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

bridge_channel.c

bridge_channel.c: Fix Deadlock when using Local channels and fax gateway

2018-06-01 14:24:59 -06:00

bridge_roles.c

bridge_roles: Use a non-locking linked list where appropriate

2018-02-15 15:30:35 -05:00

bridge.c

stasis_bridge.c: Fixed wrong video_mode shown

2020-08-11 17:19:51 -05:00

bucket.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:32:58 -04:00

buildinfo.c

…

callerid.c

Replace direct checks of option_debug with DEBUG_ATLEAST macro.

2018-03-07 17:02:49 -05:00

ccss.c

various modules: json integer overflow

2019-08-01 16:22:01 -05:00

cdr.c

cdr.c: Set event time on party b when leaving a parking bridge

2020-01-22 11:56:38 -07:00

cel.c

cdr / cel: Use event time at event creation instead of processing.

2019-08-07 07:47:17 -03:00

channel_internal_api.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

channel.c

manager - Add Content-Type parameter to the SendText action

2020-07-06 05:23:11 -05:00

chanvars.c

Fix checks for allocation debugging.

2016-08-24 11:02:47 -05:00

cli.c

core: Add some documentation to the malloc_trim code

2018-12-03 17:47:06 -05:00

codec_builtin.c

core: Add VP9 passthrough support.

2017-07-24 18:46:28 +00:00

codec.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:32:58 -04:00

config_options.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:07 -05:00

config.c

config.c: Skip UTF-8 BOMs if present when reading config files

2019-12-19 05:48:37 -05:00

core_local.c

core_local: Local calls are always secure.

2020-04-29 13:04:55 -05:00

core_unreal.c

…

crypt.c

BuildSystem: Fix build on FreeBSD due to missing crypt.h

2017-06-08 17:36:00 +02:00

cygload.c

…

data.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:07 -05:00

datastore.c

…

db.c

db: Initialize condition primitive before use

2019-12-27 18:29:45 -05:00

devicestate.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

dial.c

dial.c: Removed dial string 80 character limitation

2020-03-31 12:07:00 -05:00

dns.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

dnsmgr.c

…

dsp.c

core: Remove non-critical cleanup from startup aborts.

2018-03-10 04:33:33 -05:00

ecdisa.h

…

endpoints.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

enum.c

Merge "enum.c: Make ast_get_txt() actually do something." into 13

2020-03-09 10:04:08 -05:00

event.c

various files - fix some alerts raised by lgtm code analysis

2019-11-11 18:11:27 -06:00

features_config.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:32:58 -04:00

features.c

features.c: Make Bridge application tolerate unspecified channel.

2020-01-05 21:17:06 -06:00

file.c

app_mixmonitor: Set MIXMONITOR_FILENAME to correct value when wav49 is used

2020-02-17 11:56:45 -05:00

fixedjitterbuf.c

abstract/fixed/adpative jitter buffer: disallow frame re-inserts

2017-01-17 17:08:36 -06:00

fixedjitterbuf.h

abstract/fixed/adpative jitter buffer: disallow frame re-inserts

2017-01-17 17:08:36 -06:00

format_cache.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:32:58 -04:00

format_cap.c

format_cap: make function parameters 'const'

2020-02-24 13:37:21 -06:00

format_compatibility.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

format.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:32:58 -04:00

frame.c

func_volume: Accept decimal number as argument

2020-04-14 09:36:54 -05:00

framehook.c

…

fskmodem_float.c

…

fskmodem_int.c

…

fskmodem.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

global_datastores.c

…

hashtab.c

hashtab: Use ast_free.

2017-10-24 17:17:53 -04:00

heap.c

heap.c: No need to calloc heap pointer array.

2017-09-28 15:47:55 -05:00

http.c

Compiler fixes for gcc 10

2020-06-10 13:56:03 -05:00

image.c

…

indications.c

various files - fix some alerts raised by lgtm code analysis

2019-11-11 18:11:27 -06:00

io.c

sd_notify (systemd status notifications) support

2016-09-20 08:00:14 -06:00

jitterbuf.c

Fix Common Typo's.

2017-12-20 12:54:13 -05:00

json.c

json: Support older jansson versions.

2019-12-17 14:11:52 +00:00

libasteriskpj.c

PJPROJECT logging: Fix detection of max supported log level.

2017-01-24 11:23:05 -06:00

libasteriskssl.c

libasteriskssl: Allow OpenSSL 1.0.2 configured with no-deprecated.

2018-05-20 13:53:19 +02:00

libasteriskssl.exports.in

…

loader.c

media_index.c: Refactored so it doesn't cache the index

2019-01-28 10:07:51 -07:00

lock.c

lock: Replace __ast_mutex_logger with private log_mutex_error.

2018-10-19 11:43:28 -05:00

logger.c

backtrace: Refactor ast_bt_get_symbols so it doesn't crash

2018-11-19 05:47:35 -07:00

Makefile

BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere.

2018-03-08 12:41:53 +01:00

manager_bridges.c

res/ari/resource_bridges: Add the ability to manipulate the video source

2016-11-14 17:02:00 -05:00

manager_channels.c

Merge "manager_channels: Fix throwing of HangupHandler manager events" into 13

2019-01-23 09:52:02 -06:00

manager_endpoints.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

manager_mwi.c

mwi core: Move core MWI functionality into its own files

2019-04-23 17:39:40 -05:00

manager_system.c

Remove constant conditionals (dead-code).

2017-12-19 08:52:33 -06:00

manager.c

manager - Add Content-Type parameter to the SendText action

2020-07-06 05:23:11 -05:00

max_forwards.c

…

md5.c

…

media_index.c

media_index.c: Refactored so it doesn't cache the index

2019-01-28 10:07:51 -07:00

message.c

manager - Add Content-Type parameter to the SendText action

2020-07-06 05:23:11 -05:00

mixmonitor.c

…

mwi.c

mwi core: Move core MWI functionality into its own files

2019-04-23 17:39:40 -05:00

named_acl.c

acl: implement a centralized ACL output mechanism for HAs and ACLs.

2020-03-31 10:45:04 -05:00

named_locks.c

core: Use macros to generate ao2_container callbacks where possible.

2018-01-01 19:17:15 -05:00

netsock2.c

Replace direct checks of option_debug with DEBUG_ATLEAST macro.

2018-03-07 17:02:49 -05:00

netsock.c

netsock.c: fix includes for HURD

2016-11-01 12:37:58 -05:00

optional_api.c

…

options.c

core: Ensure that el_end is always run when needed.

2018-11-11 09:23:04 -05:00

parking.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

pbx_app.c

cli: Enable ast_cli_completion_add on public completion generators.

2018-03-15 05:27:41 -06:00

pbx_builtins.c

core: Remove non-critical cleanup from startup aborts.

2018-03-10 04:33:33 -05:00

pbx_functions.c

Fix some doxygen and curly placement.

2018-06-19 11:46:45 -05:00

pbx_hangup_handler.c

cli: Fix various CLI documentation and completion issues

2017-02-13 10:57:16 -05:00

pbx_private.h

…

pbx_switch.c

…

pbx_timing.c

…

pbx_variables.c

Compiler fixes for gcc 10

2020-06-10 13:56:03 -05:00

pbx.c

pbx: Fix hints deadlock between reload and ExtensionState.

2020-08-28 04:32:04 -05:00

pickup.c

astobj2: Eliminate usage of legacy container allocation macros.

2018-10-19 17:32:58 -04:00

plc.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

poll.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

presencestate.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

privacy.c

…

rtp_engine.c

srtp: Fix possible race condition, and add NULL checks

2019-08-08 11:30:47 -05:00

say.c

say: Remove unused "plural" option from main/say

2020-02-25 17:09:55 +01:00

sched.c

sched: Don't allow ast_sched_del to deadlock ast_sched_runq from same thread

2019-07-18 09:20:35 +02:00

sdp_srtp.c

dialplan_functions: wrong srtp use status report of a dialplan function

2018-08-02 16:58:47 -05:00

security_events.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

sem.c

…

serializer.c

serializer: set high/low alert levels on whole pool

2019-11-18 11:06:20 -05:00

sha1.c

…

sip_api.c

…

slinfactory.c

…

smoother.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

sorcery.c

pjsip: Update ACLs on named ACL changes.

2020-02-18 13:24:32 +00:00

sounds.c

sounds: Sort 'core show sounds' output

2019-02-04 15:40:02 -05:00

srv.c

srv: Fix crash when ast_srv_lookup is used and 0 records are returned.

2017-02-07 18:12:17 +00:00

stasis_bridges.c

app_confbridge: Attended transfer event fixup

2019-06-13 14:05:12 -06:00

stasis_cache_pattern.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

stasis_cache.c

various files - fix some alerts raised by lgtm code analysis

2019-11-11 18:11:27 -06:00

stasis_channels.c

app_queue: track masquerades in app_queue to avoid leaked stasis subscriptions

2020-05-05 10:09:27 -05:00

stasis_endpoints.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

stasis_message_router.c

stasis / manager / ari: Better filter messages.

2019-01-17 14:51:11 -04:00

stasis_message.c

stasis: Allow filtering by formatter

2018-12-07 06:57:15 -07:00

stasis_system.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

stasis.c

Compiler fixes for gcc 10

2020-06-10 13:56:03 -05:00

strcompat.c

app.c: make sure that no non-async-signal-safe syscalls are used after

2020-05-06 06:40:12 -05:00

stringfields.c

…

strings.c

json.c/strings.c - Add a couple of utility functions

2019-02-19 09:43:40 -06:00

stun.c

STUN/netsock2: Fix some valgrind uninitialized memory findings.

2017-08-10 14:27:15 -05:00

syslog.c

…

taskprocessor.c

serializer: move/add asterisk serializer pool functionality

2019-10-07 16:48:26 -05:00

tcptls.c

tcptls: Fix notice when TLS is enabled but not supported.

2020-05-11 05:47:49 -05:00

tdd.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

term.c

…

test.c

stasis: Improve topic/subscription names and statistics.

2019-03-11 11:39:08 -03:00

threadpool.c

taskprocessor: Enable subsystems and overload by subsystem

2019-02-20 10:23:26 -07:00

threadstorage.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

timing.c

…

translate.c

translate.c: Fix silk 24kHz truncation in 'core show translation'

2020-01-20 15:57:58 -06:00

udptl.c

main/udptl.c: correctly handle udptl sequence wrap around

2019-08-06 08:54:36 -05:00

ulaw.c

Remove as much trailing whitespace as possible.

2017-12-22 09:14:07 -05:00

uri.c

…

utf8.c

utf8.c: Add UTF-8 validation and utility functions

2020-07-27 17:30:17 -05:00

utils.c

Merge "utils: Don't set or clear flags that don't need setting or clearing" into 13

2018-12-12 13:11:17 -06:00

uuid.c

uuid: Enable UUID in Solaris 11.

2018-06-23 00:27:06 -06:00

xml.c

xmldoc.c: Fix dump of xml document

2018-07-20 05:20:25 -06:00

xmldoc.c

astobj2: Eliminate usage of legacy ao2_container_alloc routine.

2018-11-21 09:56:07 -05:00