mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-03 03:20:57 +00:00
7300a506d0
Issues:
* The bridging core allowed multiple bridges to be created with the same
unique bridgeId at the same time. Only the last bridge created with the
duplicate name was actually saved to the core bridges container.
* The bridging core was creating a stasis topic for the bridge and saving it
in the bridge->topic field but not increasing its reference count. In the
case where two bridges were created with the same uniqueid (which is also
the topic name), the second bridge would get the _existing_ topic the first
bridge created. When the first bridge was destroyed, it would take the
topic with it so when the second bridge attempted to publish a message to
it it either FRACKed or SEGVd.
* The bridge destructor, which also destroys the bridge topic, is run from the
bridge manager thread not the caller's thread. This makes it possible for
an ARI developer to create a new one with the same uniqueid believing the
old one was destroyed when, in fact, the old one's destructor hadn't
completed. This could cause the new bridge to get the old one's topic just
before the topic was destroyed. When the new bridge attempted to publish
a message on that topic, asterisk could either FRACK or SEGV.
* The ARI bridges resource also allowed multiple bridges to be created with
the same uniqueid but it kept the duplicate bridges in its app_bridges
container. This created a situation where if you added two bridges with
the same "bridge1" uniqueid, all operations on "bridge1" were performed on
the first bridge created and the second was basically orphaned. If you
attempted to delete what you thought was the second bridge, you actually
deleted the first one created.
Changes:
* A new API `ast_bridge_topic_exists(uniqueid)` was created to determine if
a topic already exists for a bridge.
* `bridge_base_init()` in bridge.c and `ast_ari_bridges_create()` in
resource_bridges.c now call `ast_bridge_topic_exists(uniqueid)` to check
if a bridge with the requested uniqueid already exists and will fail if it
does.
* `bridge_register()` in bridges.c now checks the core bridges container to
make sure a bridge doesn't already exist with the requested uniqueid.
Although most callers of `bridge_register()` will have already called
`bridge_base_init()`, which will now fail on duplicate bridges, there
is no guarantee of this so we must check again.
* The core bridges container allocation was changed to reject duplicate
uniqueids instead of silently replacing an existing one. This is a "belt
and suspenders" check.
* A global mutex was added to bridge.c to prevent concurrent calls to
`bridge_base_init()` and `bridge_register()`.
* Even though you can no longer create multiple bridges with the same uniqueid
at the same time, it's still possible that the bridge topic might be
destroyed while a second bridge with the same uniqueid was trying to use
it. To address this, the bridging core now increments the reference count
on bridge->topic when a bridge is created and decrements it when the
bridge is destroyed.
* `bridge_create_common()` in res_stasis.c now checks the stasis app_bridges
container to make sure a bridge with the requested uniqueid doesn't already
exist. This may seem like overkill but there are so many entrypoints to
bridge creation that we need to be safe and catch issues as soon in the
process as possible.
* The stasis app_bridges container allocation was changed to reject duplicate
uniqueids instead of adding them. This is a "belt and suspenders" check.
* The `bridge show all` CLI command now shows the bridge name as well as the
bridge id.
* Response code 409 "Conflict" was added as a possible response from the ARI
bridge create resources to signal that a bridge with the requested uniqueid
already exists.
* Additional debugging was added to multiple bridging and stasis files.
Resolves: #211
(cherry picked from commit 46c9f7db8e)
400 lines
14 KiB
C
400 lines
14 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2012 - 2013, Digium, Inc.
|
|
*
|
|
* David M. Lee, II <dlee@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*! \file
|
|
*
|
|
* \brief Generated file - declares stubs to be implemented in
|
|
* res/ari/resource_bridges.c
|
|
*
|
|
* Bridge resources
|
|
*
|
|
* \author David M. Lee, II <dlee@digium.com>
|
|
*/
|
|
|
|
/*
|
|
* !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
|
|
* !!!!! DO NOT EDIT !!!!!
|
|
* !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
|
|
* This file is generated by a mustache template. Please see the original
|
|
* template in rest-api-templates/ari_resource.h.mustache
|
|
*/
|
|
|
|
#ifndef _ASTERISK_RESOURCE_BRIDGES_H
|
|
#define _ASTERISK_RESOURCE_BRIDGES_H
|
|
|
|
#include "asterisk/ari.h"
|
|
|
|
/*! Argument struct for ast_ari_bridges_list() */
|
|
struct ast_ari_bridges_list_args {
|
|
};
|
|
/*!
|
|
* \brief List all active bridges in Asterisk.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_list(struct ast_variable *headers, struct ast_ari_bridges_list_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_create() */
|
|
struct ast_ari_bridges_create_args {
|
|
/*! Comma separated list of bridge type attributes (mixing, holding, dtmf_events, proxy_media, video_sfu, video_single, sdp_label). */
|
|
const char *type;
|
|
/*! Unique ID to give to the bridge being created. */
|
|
const char *bridge_id;
|
|
/*! Name to give to the bridge being created. */
|
|
const char *name;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_create_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_create_args *args);
|
|
|
|
/*!
|
|
* \brief Create a new bridge.
|
|
*
|
|
* This bridge persists until it has been shut down, or Asterisk has been shut down.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_create(struct ast_variable *headers, struct ast_ari_bridges_create_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_create_with_id() */
|
|
struct ast_ari_bridges_create_with_id_args {
|
|
/*! Comma separated list of bridge type attributes (mixing, holding, dtmf_events, proxy_media, video_sfu, video_single, sdp_label) to set. */
|
|
const char *type;
|
|
/*! Unique ID to give to the bridge being created. */
|
|
const char *bridge_id;
|
|
/*! Set the name of the bridge. */
|
|
const char *name;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_create_with_id_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_create_with_id_args *args);
|
|
|
|
/*!
|
|
* \brief Create a new bridge.
|
|
*
|
|
* This bridge persists until it has been shut down, or Asterisk has been shut down.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_create_with_id(struct ast_variable *headers, struct ast_ari_bridges_create_with_id_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_get() */
|
|
struct ast_ari_bridges_get_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
};
|
|
/*!
|
|
* \brief Get bridge details.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_get(struct ast_variable *headers, struct ast_ari_bridges_get_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_destroy() */
|
|
struct ast_ari_bridges_destroy_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
};
|
|
/*!
|
|
* \brief Shut down a bridge.
|
|
*
|
|
* If any channels are in this bridge, they will be removed and resume whatever they were doing beforehand.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_destroy(struct ast_variable *headers, struct ast_ari_bridges_destroy_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_add_channel() */
|
|
struct ast_ari_bridges_add_channel_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Array of Ids of channels to add to bridge */
|
|
const char **channel;
|
|
/*! Length of channel array. */
|
|
size_t channel_count;
|
|
/*! Parsing context for channel. */
|
|
char *channel_parse;
|
|
/*! Channel's role in the bridge */
|
|
const char *role;
|
|
/*! Absorb DTMF coming from this channel, preventing it to pass through to the bridge */
|
|
int absorb_dtmf;
|
|
/*! Mute audio from this channel, preventing it to pass through to the bridge */
|
|
int mute;
|
|
/*! Do not present the identity of the newly connected channel to other bridge members */
|
|
int inhibit_connected_line_updates;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}/addChannel.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_add_channel_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_add_channel_args *args);
|
|
|
|
/*!
|
|
* \brief Add a channel to a bridge.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_add_channel(struct ast_variable *headers, struct ast_ari_bridges_add_channel_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_remove_channel() */
|
|
struct ast_ari_bridges_remove_channel_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Array of Ids of channels to remove from bridge */
|
|
const char **channel;
|
|
/*! Length of channel array. */
|
|
size_t channel_count;
|
|
/*! Parsing context for channel. */
|
|
char *channel_parse;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}/removeChannel.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_remove_channel_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_remove_channel_args *args);
|
|
|
|
/*!
|
|
* \brief Remove a channel from a bridge.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_remove_channel(struct ast_variable *headers, struct ast_ari_bridges_remove_channel_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_set_video_source() */
|
|
struct ast_ari_bridges_set_video_source_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Channel's id */
|
|
const char *channel_id;
|
|
};
|
|
/*!
|
|
* \brief Set a channel as the video source in a multi-party mixing bridge. This operation has no effect on bridges with two or fewer participants.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_set_video_source(struct ast_variable *headers, struct ast_ari_bridges_set_video_source_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_clear_video_source() */
|
|
struct ast_ari_bridges_clear_video_source_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
};
|
|
/*!
|
|
* \brief Removes any explicit video source in a multi-party mixing bridge. This operation has no effect on bridges with two or fewer participants. When no explicit video source is set, talk detection will be used to determine the active video stream.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_clear_video_source(struct ast_variable *headers, struct ast_ari_bridges_clear_video_source_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_start_moh() */
|
|
struct ast_ari_bridges_start_moh_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Channel's id */
|
|
const char *moh_class;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}/moh.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_start_moh_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_start_moh_args *args);
|
|
|
|
/*!
|
|
* \brief Play music on hold to a bridge or change the MOH class that is playing.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_start_moh(struct ast_variable *headers, struct ast_ari_bridges_start_moh_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_stop_moh() */
|
|
struct ast_ari_bridges_stop_moh_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
};
|
|
/*!
|
|
* \brief Stop playing music on hold to a bridge.
|
|
*
|
|
* This will only stop music on hold being played via POST bridges/{bridgeId}/moh.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_stop_moh(struct ast_variable *headers, struct ast_ari_bridges_stop_moh_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_play() */
|
|
struct ast_ari_bridges_play_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Array of Media URIs to play. */
|
|
const char **media;
|
|
/*! Length of media array. */
|
|
size_t media_count;
|
|
/*! Parsing context for media. */
|
|
char *media_parse;
|
|
/*! For sounds, selects language for sound. */
|
|
const char *lang;
|
|
/*! Number of milliseconds to skip before playing. Only applies to the first URI if multiple media URIs are specified. */
|
|
int offsetms;
|
|
/*! Number of milliseconds to skip for forward/reverse operations. */
|
|
int skipms;
|
|
/*! Playback Id. */
|
|
const char *playback_id;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}/play.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_play_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_play_args *args);
|
|
|
|
/*!
|
|
* \brief Start playback of media on a bridge.
|
|
*
|
|
* The media URI may be any of a number of URI's. Currently sound:, recording:, number:, digits:, characters:, and tone: URI's are supported. This operation creates a playback resource that can be used to control the playback of media (pause, rewind, fast forward, etc.)
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_play(struct ast_variable *headers, struct ast_ari_bridges_play_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_play_with_id() */
|
|
struct ast_ari_bridges_play_with_id_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Playback ID. */
|
|
const char *playback_id;
|
|
/*! Array of Media URIs to play. */
|
|
const char **media;
|
|
/*! Length of media array. */
|
|
size_t media_count;
|
|
/*! Parsing context for media. */
|
|
char *media_parse;
|
|
/*! For sounds, selects language for sound. */
|
|
const char *lang;
|
|
/*! Number of milliseconds to skip before playing. Only applies to the first URI if multiple media URIs are specified. */
|
|
int offsetms;
|
|
/*! Number of milliseconds to skip for forward/reverse operations. */
|
|
int skipms;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}/play/{playbackId}.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_play_with_id_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_play_with_id_args *args);
|
|
|
|
/*!
|
|
* \brief Start playback of media on a bridge.
|
|
*
|
|
* The media URI may be any of a number of URI's. Currently sound:, recording:, number:, digits:, characters:, and tone: URI's are supported. This operation creates a playback resource that can be used to control the playback of media (pause, rewind, fast forward, etc.)
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_play_with_id(struct ast_variable *headers, struct ast_ari_bridges_play_with_id_args *args, struct ast_ari_response *response);
|
|
/*! Argument struct for ast_ari_bridges_record() */
|
|
struct ast_ari_bridges_record_args {
|
|
/*! Bridge's id */
|
|
const char *bridge_id;
|
|
/*! Recording's filename */
|
|
const char *name;
|
|
/*! Format to encode audio in */
|
|
const char *format;
|
|
/*! Maximum duration of the recording, in seconds. 0 for no limit. */
|
|
int max_duration_seconds;
|
|
/*! Maximum duration of silence, in seconds. 0 for no limit. */
|
|
int max_silence_seconds;
|
|
/*! Action to take if a recording with the same name already exists. */
|
|
const char *if_exists;
|
|
/*! Play beep when recording begins */
|
|
int beep;
|
|
/*! DTMF input to terminate recording. */
|
|
const char *terminate_on;
|
|
};
|
|
/*!
|
|
* \brief Body parsing function for /bridges/{bridgeId}/record.
|
|
* \param body The JSON body from which to parse parameters.
|
|
* \param[out] args The args structure to parse into.
|
|
* \retval zero on success
|
|
* \retval non-zero on failure
|
|
*/
|
|
int ast_ari_bridges_record_parse_body(
|
|
struct ast_json *body,
|
|
struct ast_ari_bridges_record_args *args);
|
|
|
|
/*!
|
|
* \brief Start a recording.
|
|
*
|
|
* This records the mixed audio from all channels participating in this bridge.
|
|
*
|
|
* \param headers HTTP headers
|
|
* \param args Swagger parameters
|
|
* \param[out] response HTTP response
|
|
*/
|
|
void ast_ari_bridges_record(struct ast_variable *headers, struct ast_ari_bridges_record_args *args, struct ast_ari_response *response);
|
|
|
|
#endif /* _ASTERISK_RESOURCE_BRIDGES_H */
|