Files
asterisk/main/stasis_message_router.c
David M. Lee b97c71bb11 Fix shutdown assertions in stasis-core
In r388005, macros were introduced to consistently define message
types. This added an assert if a message type was used either before
it was initialized or after it had been cleaned up. It turns out that
this assertion fires during shutdown.

This actually exposed a hidden shutdown ordering problem. Since
unsubscribing is asynchronous, it's possible that the message types
used by the subscription could be freed before the final message of
the subscription was processed.

This patch adds stasis_subscription_join(), which blocks until the
last message has been processed by the subscription. Since joining was
most commonly done right after an unsubscribe, a
stasis_unsubscribe_and_join() convenience function was also added.

Similar functions were also added to the stasis_caching_topic and
stasis_message_router, since they wrap subscriptions and have similar
problems.

Other code in trunk was refactored to join() where appropriate, or at
least verify that the subscription was complete before being
destroyed.

Review: https://reviewboard.asterisk.org/r/2540


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@389011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2013-05-17 21:10:32 +00:00

267 lines
6.4 KiB
C

/*
* Asterisk -- An open source telephony toolkit.
*
* Copyright (C) 2013, Digium, Inc.
*
* David M. Lee, II <dlee@digium.com>
*
* See http://www.asterisk.org for more information about
* the Asterisk project. Please do not directly contact
* any of the maintainers of this project for assistance;
* the project provides a web site, mailing lists and IRC
* channels for your use.
*
* This program is free software, distributed under the terms of
* the GNU General Public License Version 2. See the LICENSE file
* at the top of the source tree.
*/
/*! \file
*
* \brief Stasis message router implementation.
*
* \author David M. Lee, II <dlee@digium.com>
*/
/*** MODULEINFO
<support_level>core</support_level>
***/
#include "asterisk.h"
ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
#include "asterisk/astobj2.h"
#include "asterisk/stasis_message_router.h"
#define INITIAL_ROUTES_MAX 8
/*! \internal */
struct stasis_message_route {
/*! Message type handle by this route. */
struct stasis_message_type *message_type;
/*! Callback function for incoming message processing. */
stasis_subscription_cb callback;
/*! Data pointer to be handed to the callback. */
void *data;
};
static void route_dtor(void *obj)
{
struct stasis_message_route *route = obj;
ao2_cleanup(route->message_type);
route->message_type = NULL;
}
/*! \internal */
struct stasis_message_router {
/*! Subscription to the upstream topic */
struct stasis_subscription *subscription;
/*! Variable length array of the routes */
struct stasis_message_route **routes;
/*! Route of last resort */
struct stasis_message_route *default_route;
/*! Allocated length of the routes array */
size_t num_routes_max;
/*! Current size of the routes array */
size_t num_routes_current;
};
static void router_dtor(void *obj)
{
struct stasis_message_router *router = obj;
size_t i;
ast_assert(!stasis_subscription_is_subscribed(router->subscription));
ast_assert(stasis_subscription_is_done(router->subscription));
router->subscription = NULL;
for (i = 0; i < router->num_routes_current; ++i) {
ao2_cleanup(router->routes[i]);
router->routes[i] = NULL;
}
ast_free(router->routes);
router->routes = NULL;
ao2_cleanup(router->default_route);
router->default_route = NULL;
}
static void router_dispatch(void *data,
struct stasis_subscription *sub,
struct stasis_topic *topic,
struct stasis_message *message)
{
struct stasis_message_router *router = data;
RAII_VAR(struct stasis_message_router *, router_needs_cleanup, NULL, ao2_cleanup);
RAII_VAR(struct stasis_message_route *, route, NULL, ao2_cleanup);
struct stasis_message_type *type = stasis_message_type(message);
size_t i;
{
SCOPED_AO2LOCK(lock, router);
/* We don't expect many message types, so a simple loop should
* be adequate, even if the complexity is O(n). Sorting the list
* would be an easy way to bring that down to O(log(n)). Using a
* hashtable/ao2_container could be even better. Just be sure to
* profile before you optimize!
*/
route = router->default_route;
for (i = 0; i < router->num_routes_current; ++i) {
if (router->routes[i]->message_type == type) {
route = router->routes[i];
break;
}
}
/* Ref the route before leaving the scoped lock */
if (route) {
ao2_ref(route, +1);
}
}
if (route) {
route->callback(route->data, sub, topic, message);
}
if (stasis_subscription_final_message(sub, message)) {
router_needs_cleanup = router;
return;
}
}
struct stasis_message_router *stasis_message_router_create(
struct stasis_topic *topic)
{
RAII_VAR(struct stasis_message_router *, router, NULL, ao2_cleanup);
router = ao2_alloc(sizeof(*router), router_dtor);
if (!router) {
return NULL;
}
router->num_routes_max = INITIAL_ROUTES_MAX;
router->routes = ast_calloc(router->num_routes_max,
sizeof(*router->routes));
if (!router->routes) {
return NULL;
}
router->subscription = stasis_subscribe(topic, router_dispatch, router);
if (!router->subscription) {
return NULL;
}
ao2_ref(router, +1);
return router;
}
void stasis_message_router_unsubscribe(struct stasis_message_router *router)
{
if (!router) {
return;
}
stasis_unsubscribe(router->subscription);
}
void stasis_message_router_unsubscribe_and_join(
struct stasis_message_router *router)
{
if (!router) {
return;
}
stasis_unsubscribe_and_join(router->subscription);
}
int stasis_message_router_is_done(struct stasis_message_router *router)
{
if (!router) {
/* Null router is about as done as you can get */
return 1;
}
return stasis_subscription_is_done(router->subscription);
}
static struct stasis_message_route *route_create(
struct stasis_message_type *message_type,
stasis_subscription_cb callback,
void *data)
{
RAII_VAR(struct stasis_message_route *, route, NULL, ao2_cleanup);
route = ao2_alloc(sizeof(*route), route_dtor);
if (!route) {
return NULL;
}
if (message_type) {
ao2_ref(message_type, +1);
}
route->message_type = message_type;
route->callback = callback;
route->data = data;
ao2_ref(route, +1);
return route;
}
static int add_route(struct stasis_message_router *router,
struct stasis_message_route *route)
{
struct stasis_message_route **routes;
size_t i;
SCOPED_AO2LOCK(lock, router);
/* Check for route conflicts */
for (i = 0; i < router->num_routes_current; ++i) {
if (router->routes[i]->message_type == route->message_type) {
return -1;
}
}
/* Increase list size, if needed */
if (router->num_routes_current + 1 > router->num_routes_max) {
routes = realloc(router->routes,
2 * router->num_routes_max * sizeof(*routes));
if (!routes) {
return -1;
}
router->routes = routes;
router->num_routes_max *= 2;
}
ao2_ref(route, +1);
router->routes[router->num_routes_current++] = route;
return 0;
}
int stasis_message_router_add(struct stasis_message_router *router,
struct stasis_message_type *message_type,
stasis_subscription_cb callback,
void *data)
{
RAII_VAR(struct stasis_message_route *, route, NULL, ao2_cleanup);
route = route_create(message_type, callback, data);
if (!route) {
return -1;
}
return add_route(router, route);
}
int stasis_message_router_set_default(struct stasis_message_router *router,
stasis_subscription_cb callback,
void *data)
{
SCOPED_AO2LOCK(lock, router);
ao2_cleanup(router->default_route);
router->default_route = route_create(NULL, callback, data);
return router->default_route ? 0 : -1;
}