mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-04 03:50:31 +00:00
32b3e36c68
The gist of this work ensures that when a remote SDP is received, it is merged properly with the local capabilities. The remote SDP is converted into a stream topology. That topology is then merged with the current local topology on the SDP state. That new merged topology is then used to create an SDP. Finally, adjustments are made to RTP instances based on knowledge gained from the remote SDP. There are also a battery of tests in this commit that ensure that some basic SDP merges work as expected. While this may not sound like a big change, it has the property that it caused lots of ancillary changes. * The remote SDP is no longer stored on the SDP state. Biggest reason: there's no need for it. The remote SDP is used at the time it is being set and nowhere else. * Some new SDP APIs were added in order to find attributes and convert generic SDP attributes into rtpmap structures. * Writing tests made me realize that retrieving a value from an SDP options structure, the SDP options needs to be made const. * The SDP state machine was essentially gutted by a previous commit. Initially, I attempted to reinstate it, but I found that as it had been defined, it was not all that useful. What was more useful was knowing the role we play in SDP negotiation, so the SDP state machine has been transformed into an indicator of role. * Rather than storing separate local and joint stream state capabilities, it makes more sense to keep track of current stream state and update it as things change. Change-Id: I5938c2be3c6f0a003aa88a39a59e0880f8b2df3d
107 lines
3.2 KiB
C
107 lines
3.2 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2017, Digium, Inc.
|
|
*
|
|
* Mark Michelson <mmichelson@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
#include "asterisk.h"
|
|
|
|
#include "asterisk/utils.h"
|
|
#include "asterisk/sdp_options.h"
|
|
|
|
#include "sdp_private.h"
|
|
|
|
#define DEFAULT_ICE AST_SDP_ICE_DISABLED
|
|
#define DEFAULT_TELEPHONE_EVENT 0
|
|
#define DEFAULT_IMPL AST_SDP_IMPL_STRING
|
|
#define DEFAULT_ENCRYPTION AST_SDP_ENCRYPTION_DISABLED
|
|
|
|
#define DEFINE_STRINGFIELD_GETTERS_SETTERS_FOR(field, assert_on_null) \
|
|
void ast_sdp_options_set_##field(struct ast_sdp_options *options, const char *value) \
|
|
{ \
|
|
ast_assert(options != NULL); \
|
|
if ((assert_on_null)) ast_assert(!ast_strlen_zero(value)); \
|
|
if (!strcmp(value, options->field)) return; \
|
|
ast_string_field_set(options, field, value); \
|
|
} \
|
|
const char *ast_sdp_options_get_##field(const struct ast_sdp_options *options) \
|
|
{ \
|
|
ast_assert(options != NULL); \
|
|
return options->field; \
|
|
} \
|
|
|
|
#define DEFINE_GETTERS_SETTERS_FOR(type, field) \
|
|
void ast_sdp_options_set_##field(struct ast_sdp_options *options, type value) \
|
|
{ \
|
|
ast_assert(options != NULL); \
|
|
options->field = value; \
|
|
} \
|
|
type ast_sdp_options_get_##field(const struct ast_sdp_options *options) \
|
|
{ \
|
|
ast_assert(options != NULL); \
|
|
return options->field; \
|
|
} \
|
|
|
|
DEFINE_STRINGFIELD_GETTERS_SETTERS_FOR(media_address, 0);
|
|
DEFINE_STRINGFIELD_GETTERS_SETTERS_FOR(sdpowner, 0);
|
|
DEFINE_STRINGFIELD_GETTERS_SETTERS_FOR(sdpsession, 0);
|
|
DEFINE_STRINGFIELD_GETTERS_SETTERS_FOR(rtp_engine, 0);
|
|
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, bind_rtp_to_media_address);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, rtp_symmetric);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, telephone_event);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, rtp_ipv6);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, g726_non_standard);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, rtcp_mux);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, tos_audio);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, cos_audio);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, tos_video);
|
|
DEFINE_GETTERS_SETTERS_FOR(unsigned int, cos_video);
|
|
DEFINE_GETTERS_SETTERS_FOR(enum ast_sdp_options_ice, ice);
|
|
DEFINE_GETTERS_SETTERS_FOR(enum ast_sdp_options_impl, impl);
|
|
DEFINE_GETTERS_SETTERS_FOR(enum ast_sdp_options_encryption, encryption);
|
|
|
|
static void set_defaults(struct ast_sdp_options *options)
|
|
{
|
|
options->ice = DEFAULT_ICE;
|
|
options->telephone_event = DEFAULT_TELEPHONE_EVENT;
|
|
options->impl = DEFAULT_IMPL;
|
|
options->encryption = DEFAULT_ENCRYPTION;
|
|
}
|
|
|
|
struct ast_sdp_options *ast_sdp_options_alloc(void)
|
|
{
|
|
struct ast_sdp_options *options;
|
|
|
|
options = ast_calloc(1, sizeof(*options));
|
|
if (!options) {
|
|
return NULL;
|
|
}
|
|
|
|
if (ast_string_field_init(options, 256)) {
|
|
ast_free(options);
|
|
return NULL;
|
|
}
|
|
|
|
set_defaults(options);
|
|
return options;
|
|
}
|
|
|
|
void ast_sdp_options_free(struct ast_sdp_options *options)
|
|
{
|
|
ast_string_field_free_memory(options);
|
|
ast_free(options);
|
|
}
|