mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-03 03:20:57 +00:00
https://origsvn.digium.com/svn/asterisk/branches/1.8 ................ r294278 | jpeeler | 2010-11-08 15:59:45 -0600 (Mon, 08 Nov 2010) | 23 lines Merged revisions 294277 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........ r294277 | jpeeler | 2010-11-08 15:58:13 -0600 (Mon, 08 Nov 2010) | 16 lines Fix playback failure when using IAX with the timerfd module. To fix this issue the alert pipe will now be used when the timerfd module is in use. There appeared to be a race that was not solved by adding locking in the timerfd module, but needed to be there anyway. The race was between the timer being put in non-continuous mode in ast_read on the channel thread and the IAX frame scheduler queuing a frame which would enable continuous mode before the non-continuous mode event was read. This race for now is simply avoided. (closes issue #18110) Reported by: tpanton Tested by: tpanton I put tested by tpanton because it was tested on his hardware. Thanks for the remote access to debug this issue! ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
313 lines
7.7 KiB
C
313 lines
7.7 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2008, Digium, Inc.
|
|
*
|
|
* Mark Michelson <mmichelson@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*!
|
|
* \file
|
|
* \author Mark Michelson <mmichelson@digium.com>
|
|
*
|
|
* \brief timerfd timing interface
|
|
*/
|
|
|
|
/*** MODULEINFO
|
|
<depend>timerfd</depend>
|
|
***/
|
|
|
|
#include "asterisk.h"
|
|
|
|
#include <sys/timerfd.h>
|
|
|
|
#include "asterisk/module.h"
|
|
#include "asterisk/astobj2.h"
|
|
#include "asterisk/timing.h"
|
|
#include "asterisk/logger.h"
|
|
#include "asterisk/utils.h"
|
|
#include "asterisk/time.h"
|
|
|
|
static void *timing_funcs_handle;
|
|
|
|
static int timerfd_timer_open(void);
|
|
static void timerfd_timer_close(int handle);
|
|
static int timerfd_timer_set_rate(int handle, unsigned int rate);
|
|
static void timerfd_timer_ack(int handle, unsigned int quantity);
|
|
static int timerfd_timer_enable_continuous(int handle);
|
|
static int timerfd_timer_disable_continuous(int handle);
|
|
static enum ast_timer_event timerfd_timer_get_event(int handle);
|
|
static unsigned int timerfd_timer_get_max_rate(int handle);
|
|
|
|
static struct ast_timing_interface timerfd_timing = {
|
|
.name = "timerfd",
|
|
.priority = 200,
|
|
.timer_open = timerfd_timer_open,
|
|
.timer_close = timerfd_timer_close,
|
|
.timer_set_rate = timerfd_timer_set_rate,
|
|
.timer_ack = timerfd_timer_ack,
|
|
.timer_enable_continuous = timerfd_timer_enable_continuous,
|
|
.timer_disable_continuous = timerfd_timer_disable_continuous,
|
|
.timer_get_event = timerfd_timer_get_event,
|
|
.timer_get_max_rate = timerfd_timer_get_max_rate,
|
|
};
|
|
|
|
static struct ao2_container *timerfd_timers;
|
|
|
|
#define TIMERFD_TIMER_BUCKETS 563
|
|
#define TIMERFD_MAX_RATE 1000
|
|
|
|
struct timerfd_timer {
|
|
int handle;
|
|
struct itimerspec saved_timer;
|
|
unsigned int is_continuous:1;
|
|
};
|
|
|
|
static int timerfd_timer_hash(const void *obj, const int flags)
|
|
{
|
|
const struct timerfd_timer *timer = obj;
|
|
|
|
return timer->handle;
|
|
}
|
|
|
|
static int timerfd_timer_cmp(void *obj, void *args, int flags)
|
|
{
|
|
struct timerfd_timer *timer1 = obj, *timer2 = args;
|
|
return timer1->handle == timer2->handle ? CMP_MATCH | CMP_STOP : 0;
|
|
}
|
|
|
|
static void timer_destroy(void *obj)
|
|
{
|
|
struct timerfd_timer *timer = obj;
|
|
close(timer->handle);
|
|
}
|
|
|
|
static int timerfd_timer_open(void)
|
|
{
|
|
struct timerfd_timer *timer;
|
|
int handle;
|
|
|
|
if (!(timer = ao2_alloc(sizeof(*timer), timer_destroy))) {
|
|
ast_log(LOG_ERROR, "Could not allocate memory for timerfd_timer structure\n");
|
|
return -1;
|
|
}
|
|
if ((handle = timerfd_create(CLOCK_MONOTONIC, 0)) < 0) {
|
|
ast_log(LOG_ERROR, "Failed to create timerfd timer: %s\n", strerror(errno));
|
|
ao2_ref(timer, -1);
|
|
return -1;
|
|
}
|
|
|
|
timer->handle = handle;
|
|
ao2_link(timerfd_timers, timer);
|
|
/* Get rid of the reference from the allocation */
|
|
ao2_ref(timer, -1);
|
|
return handle;
|
|
}
|
|
|
|
static void timerfd_timer_close(int handle)
|
|
{
|
|
struct timerfd_timer *our_timer, find_helper = {
|
|
.handle = handle,
|
|
};
|
|
|
|
if (!(our_timer = ao2_find(timerfd_timers, &find_helper, OBJ_POINTER))) {
|
|
ast_log(LOG_ERROR, "Couldn't find timer with handle %d\n", handle);
|
|
return;
|
|
}
|
|
|
|
ao2_unlink(timerfd_timers, our_timer);
|
|
ao2_ref(our_timer, -1);
|
|
}
|
|
|
|
static int timerfd_timer_set_rate(int handle, unsigned int rate)
|
|
{
|
|
struct timerfd_timer *our_timer, find_helper = {
|
|
.handle = handle,
|
|
};
|
|
int res = 0;
|
|
|
|
if (!(our_timer = ao2_find(timerfd_timers, &find_helper, OBJ_POINTER))) {
|
|
ast_log(LOG_ERROR, "Couldn't find timer with handle %d\n", handle);
|
|
return -1;
|
|
}
|
|
ao2_lock(our_timer);
|
|
|
|
our_timer->saved_timer.it_value.tv_sec = 0;
|
|
our_timer->saved_timer.it_value.tv_nsec = rate ? (long) (1000000000 / rate) : 0L;
|
|
our_timer->saved_timer.it_interval.tv_sec = our_timer->saved_timer.it_value.tv_sec;
|
|
our_timer->saved_timer.it_interval.tv_nsec = our_timer->saved_timer.it_value.tv_nsec;
|
|
|
|
if (!our_timer->is_continuous) {
|
|
res = timerfd_settime(handle, 0, &our_timer->saved_timer, NULL);
|
|
}
|
|
|
|
ao2_unlock(our_timer);
|
|
ao2_ref(our_timer, -1);
|
|
|
|
return res;
|
|
}
|
|
|
|
static void timerfd_timer_ack(int handle, unsigned int quantity)
|
|
{
|
|
uint64_t expirations;
|
|
int read_result = 0;
|
|
|
|
do {
|
|
read_result = read(handle, &expirations, sizeof(expirations));
|
|
if (read_result == -1) {
|
|
if (errno == EINTR) {
|
|
continue;
|
|
} else {
|
|
ast_log(LOG_ERROR, "Read error: %s\n", strerror(errno));
|
|
break;
|
|
}
|
|
}
|
|
} while (read_result != sizeof(expirations));
|
|
|
|
if (expirations != quantity) {
|
|
ast_debug(2, "Expected to acknowledge %u ticks but got %llu instead\n", quantity, (unsigned long long) expirations);
|
|
}
|
|
}
|
|
|
|
static int timerfd_timer_enable_continuous(int handle)
|
|
{
|
|
int res;
|
|
struct itimerspec continuous_timer = {
|
|
.it_value.tv_nsec = 1L,
|
|
};
|
|
struct timerfd_timer *our_timer, find_helper = {
|
|
.handle = handle,
|
|
};
|
|
|
|
if (!(our_timer = ao2_find(timerfd_timers, &find_helper, OBJ_POINTER))) {
|
|
ast_log(LOG_ERROR, "Couldn't find timer with handle %d\n", handle);
|
|
return -1;
|
|
}
|
|
ao2_lock(our_timer);
|
|
|
|
if (our_timer->is_continuous) {
|
|
/*It's already in continous mode, no need to do
|
|
* anything further
|
|
*/
|
|
ao2_unlock(our_timer);
|
|
ao2_ref(our_timer, -1);
|
|
return 0;
|
|
}
|
|
|
|
res = timerfd_settime(handle, 0, &continuous_timer, &our_timer->saved_timer);
|
|
our_timer->is_continuous = 1;
|
|
ao2_unlock(our_timer);
|
|
ao2_ref(our_timer, -1);
|
|
return res;
|
|
}
|
|
|
|
static int timerfd_timer_disable_continuous(int handle)
|
|
{
|
|
int res;
|
|
struct timerfd_timer *our_timer, find_helper = {
|
|
.handle = handle,
|
|
};
|
|
|
|
if (!(our_timer = ao2_find(timerfd_timers, &find_helper, OBJ_POINTER))) {
|
|
ast_log(LOG_ERROR, "Couldn't find timer with handle %d\n", handle);
|
|
return -1;
|
|
}
|
|
ao2_lock(our_timer);
|
|
|
|
if(!our_timer->is_continuous) {
|
|
/* No reason to do anything if we're not
|
|
* in continuous mode
|
|
*/
|
|
ao2_ref(our_timer, -1);
|
|
return 0;
|
|
}
|
|
|
|
res = timerfd_settime(handle, 0, &our_timer->saved_timer, NULL);
|
|
our_timer->is_continuous = 0;
|
|
memset(&our_timer->saved_timer, 0, sizeof(our_timer->saved_timer));
|
|
ao2_unlock(our_timer);
|
|
ao2_ref(our_timer, -1);
|
|
return res;
|
|
}
|
|
|
|
static enum ast_timer_event timerfd_timer_get_event(int handle)
|
|
{
|
|
enum ast_timer_event res;
|
|
struct timerfd_timer *our_timer, find_helper = {
|
|
.handle = handle,
|
|
};
|
|
|
|
if (!(our_timer = ao2_find(timerfd_timers, &find_helper, OBJ_POINTER))) {
|
|
ast_log(LOG_ERROR, "Couldn't find timer with handle %d\n", handle);
|
|
return -1;
|
|
}
|
|
ao2_lock(our_timer);
|
|
|
|
if (our_timer->is_continuous) {
|
|
res = AST_TIMING_EVENT_CONTINUOUS;
|
|
} else {
|
|
res = AST_TIMING_EVENT_EXPIRED;
|
|
}
|
|
|
|
ao2_unlock(our_timer);
|
|
ao2_ref(our_timer, -1);
|
|
return res;
|
|
}
|
|
|
|
static unsigned int timerfd_timer_get_max_rate(int handle)
|
|
{
|
|
return TIMERFD_MAX_RATE;
|
|
}
|
|
|
|
static int load_module(void)
|
|
{
|
|
int fd;
|
|
|
|
/* Make sure we support the necessary clock type */
|
|
if ((fd = timerfd_create(CLOCK_MONOTONIC, 0)) < 0) {
|
|
ast_log(LOG_ERROR, "timerfd_create() not supported by the kernel. Not loading.\n");
|
|
return AST_MODULE_LOAD_DECLINE;
|
|
}
|
|
|
|
close(fd);
|
|
|
|
if (!(timerfd_timers = ao2_container_alloc(TIMERFD_TIMER_BUCKETS, timerfd_timer_hash, timerfd_timer_cmp))) {
|
|
return AST_MODULE_LOAD_DECLINE;
|
|
}
|
|
|
|
if (!(timing_funcs_handle = ast_register_timing_interface(&timerfd_timing))) {
|
|
ao2_ref(timerfd_timers, -1);
|
|
return AST_MODULE_LOAD_DECLINE;
|
|
}
|
|
|
|
return AST_MODULE_LOAD_SUCCESS;
|
|
}
|
|
|
|
static int unload_module(void)
|
|
{
|
|
int res;
|
|
|
|
if (!(res = ast_unregister_timing_interface(timing_funcs_handle))) {
|
|
ao2_ref(timerfd_timers, -1);
|
|
timerfd_timers = NULL;
|
|
}
|
|
|
|
return res;
|
|
}
|
|
|
|
AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_LOAD_ORDER, "Timerfd Timing Interface",
|
|
.load = load_module,
|
|
.unload = unload_module,
|
|
.load_pri = AST_MODPRI_CHANNEL_DEPEND,
|
|
);
|