Kevin Harwell 553306548c AST-2017-014: res_pjsip - Missing contact header can cause crash ...

Those SIP messages that create dialogs require a contact header to be present.
If the contact header was missing from the message it could cause Asterisk to
crash.

This patch checks to make sure SIP messages that create a dialog contain the
contact header. If the message does not and it is required Asterisk now returns
a "400 Missing Contact header" response. Also added NULL checks when retrieving
the contact header that were missing as a "just in case".

ASTERISK-27480 #close

Change-Id: I1810db87683fc637a9e3e1384a746037fec20afe

2017-12-22 15:34:39 -06:00

..

ael

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

ari

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

parking

Fix Common Typo's.

2017-12-20 12:40:01 -05:00

res_pjsip

AST-2017-014: res_pjsip - Missing contact header can cause crash

2017-12-22 15:34:39 -06:00

snmp

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

srtp

res_srtp: Add support for libsrtp2 with AES-GCM.

2017-10-18 03:34:56 -05:00

stasis

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

stasis_recording

stasis_recording: Correct ast_asprintf error checking

2017-05-30 16:09:50 -05:00

ari.make

…

Makefile

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_adsi.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_ael_share.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_ael_share.exports.in

…

res_agi.c

utils: Add convenience function for setting fd flags

2017-12-08 13:28:04 -06:00

res_agi.exports.in

…

res_ari_applications.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_asterisk.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_bridges.c

ari/bridge: Add mute, dtmf suppression controls

2017-10-11 08:23:05 -04:00

res_ari_channels.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_device_states.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_endpoints.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_events.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_mailboxes.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_model.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_ari_model.exports.in

…

res_ari_playbacks.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_recordings.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_sounds.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari.c

Merge "Add missing menuselect dependencies."

2017-11-06 09:26:18 -06:00

res_ari.exports.in

…

res_calendar_caldav.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_calendar_ews.c

res_calendar*, res_smdi: Move to "extended" support

2017-09-05 07:51:56 -05:00

res_calendar_exchange.c

res_calendar*, res_smdi: Move to "extended" support

2017-09-05 07:51:56 -05:00

res_calendar_icalendar.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_calendar.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_calendar.exports.in

…

res_chan_stats.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_clialiases.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_clioriginate.c

manager: Restore Originate failure behavior from Asterisk 11

2017-02-10 18:04:41 -05:00

res_config_curl.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_config_ldap.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_config_odbc.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_config_pgsql.c

Merge "res_config_pgsql: Fix removed support to previous for versions PostgreSQL 9.1"

2017-09-22 05:42:43 -05:00

res_config_sqlite3.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_config_sqlite.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_convert.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_corosync.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_crypto.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_crypto.exports.in

…

res_curl.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_endpoint_stats.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_fax_spandsp.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_fax.c

Fix Common Typo's.

2017-12-20 12:40:01 -05:00

res_fax.exports.in

…

res_format_attr_celt.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_g729.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_h263.c

Loader: Remove unneeded load_pri declarations.

2017-11-20 13:17:55 -06:00

res_format_attr_h264.c

Loader: Remove unneeded load_pri declarations.

2017-11-20 13:17:55 -06:00

res_format_attr_ilbc.c

codecs: Add iLBC 20.

2016-07-22 10:09:08 +02:00

res_format_attr_opus.c

Fix Common Typo's.

2017-12-20 12:40:01 -05:00

res_format_attr_silk.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_format_attr_siren7.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_siren14.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_vp8.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_hep_pjsip.c

Loader: Remove unneeded load_pri declarations.

2017-11-20 13:17:55 -06:00

res_hep_rtcp.c

Loader: Remove unneeded load_pri declarations.

2017-11-20 13:17:55 -06:00

res_hep.c

Merge changes from topic 'faster-aco'

2017-12-18 14:41:41 -06:00

res_hep.exports.in

res_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded

2016-06-08 12:32:02 -05:00

res_http_media_cache.c

Loader: Remove unneeded load_pri declarations.

2017-11-20 13:17:55 -06:00

res_http_post.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_http_websocket.c

utils: Add convenience function for setting fd flags

2017-12-08 13:28:04 -06:00

res_http_websocket.exports.in

…

res_limit.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_manager_devicestate.c

…

res_manager_presencestate.c

…

res_monitor.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_monitor.exports.in

…

res_musiconhold.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_mutestream.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_mwi_external_ami.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_mwi_external.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_mwi_external.exports.in

…

res_odbc_transaction.c

res_odbc_transaction: add dep on generic_odbc

2016-08-21 18:56:01 -05:00

res_odbc_transaction.exports.in

…

res_odbc.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_odbc.exports.in

…

res_parking.c

aco: Minimize use of regex.

2017-12-15 10:14:31 -05:00

res_phoneprov.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_phoneprov.exports.in

…

res_pjproject.c

res_pjproject.c: Fix ast_strdup() alloc failure.

2017-11-07 08:11:32 -05:00

res_pjproject.exports.in

…

res_pjsip_acl.c

…

res_pjsip_authenticator_digest.c

res_pjsip_authenticator_digest.c: Fix sorcery's immutable contract violation.

2017-02-20 22:24:31 -06:00

res_pjsip_caller_id.c

res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacy

2017-10-05 07:53:03 -05:00

res_pjsip_config_wizard.c

res_pjsip_config_wizard: Fix leaks and add check for malloc failure.

2017-11-06 18:44:01 -05:00

res_pjsip_dialog_info_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 11:25:07 -05:00

res_pjsip_diversion.c

res_pjsip: Fix known compact header issues

2016-12-31 20:00:46 -06:00

res_pjsip_dlg_options.c

res_pjsip: Assign support levels to a few modules

2017-12-12 11:07:33 -06:00

res_pjsip_dtmf_info.c

res_pjsip_empty_info: Respond to empty SIP INFO packets

2016-05-19 09:08:37 -03:00

res_pjsip_empty_info.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_pjsip_endpoint_identifier_anonymous.c

Loader: Remove unneeded load_pri declarations.

2017-11-20 13:17:55 -06:00

res_pjsip_endpoint_identifier_ip.c

res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.

2017-10-25 18:14:03 +00:00

res_pjsip_endpoint_identifier_user.c

res_pjsip: Use reasonable buffer lengths for endpoint identification

2017-11-17 11:22:04 -05:00

res_pjsip_exten_state.c

res_pjsip_exten_state: Check for vector append failure.

2017-11-06 18:48:06 -05:00

res_pjsip_exten_state.exports.in

…

res_pjsip_header_funcs.c

res_pjsip: Add clarifying documentation to PJSIP_HEADER help text

2016-05-27 12:43:54 -05:00

res_pjsip_history.c

res_pjsip_history: Fix multiple leaks on vector append failure.

2017-11-07 22:31:12 -05:00

res_pjsip_logger.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_pjsip_messaging.c

res_pjsip: Use ast_sip_is_content_type() where appropriate

2017-09-22 10:05:23 -05:00

res_pjsip_mwi_body_generator.c

res_pjsip_mwi_body_generator: Re-order the body items

2016-05-30 19:31:26 -05:00

res_pjsip_mwi.c

Merge "res_pjsip_mwi: update unsolicited MWI subscriptions on updating contact"

2017-06-22 16:01:52 -05:00

res_pjsip_nat.c

res/res_pjsip: Standardize/fix localnet checks across pjsip.

2017-09-05 09:17:32 -05:00

res_pjsip_notify.c

aco: Minimize use of regex.

2017-12-15 10:14:31 -05:00

res_pjsip_one_touch_record_info.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_outbound_authenticator_digest.c

res_pjsip_outbound_authenticator_digest: Add context to log messages

2017-04-28 11:04:57 -05:00

res_pjsip_outbound_publish.c

res_pjsip: Assign support levels to a few modules

2017-12-12 11:07:33 -06:00

res_pjsip_outbound_publish.exports.in

…

res_pjsip_outbound_registration.c

res_pjsip_outbound_registration: Fix leak on vector add failure.

2017-11-06 18:55:00 -05:00

res_pjsip_path.c

res_pjsip: Add ignore_uri_user_options option.

2016-09-09 17:13:02 -05:00

res_pjsip_phoneprov_provider.c

res_pjsip: Assign support levels to a few modules

2017-12-12 11:07:33 -06:00

res_pjsip_pidf_body_generator.c

res_pjsip_pidf_eyebeam_body_supplement: Correct status presentation

2017-08-01 15:42:38 -06:00

res_pjsip_pidf_digium_body_supplement.c

…

res_pjsip_pidf_eyebeam_body_supplement.c

res_pjsip_pidf_eyebeam_body_supplement: Correct status presentation

2017-08-01 15:42:38 -06:00

res_pjsip_publish_asterisk.c

res_pjsip: Assign support levels to a few modules

2017-12-12 11:07:33 -06:00

res_pjsip_pubsub.c

AST-2017-014: res_pjsip - Missing contact header can cause crash

2017-12-22 15:34:39 -06:00

res_pjsip_pubsub.exports.in

…

res_pjsip_refer.c

res_pjsip_refer: Prevent unload except during shutdown.

2017-10-18 14:37:57 -04:00

res_pjsip_registrar_expire.c

res_pjsip_registrar_expire.c: Remove extra linefeed in debug message.

2016-11-10 16:59:41 -05:00

res_pjsip_registrar.c

res_pjsip_registrar.c: Fix AOR and pjproject group deadlock.

2017-11-07 13:01:25 -05:00

res_pjsip_rfc3326.c

…

res_pjsip_sdp_rtp.c

res_pjsip_sdp_rtp: Add NULL check in add_crypto_to_stream

2017-12-14 13:05:23 -07:00

res_pjsip_send_to_voicemail.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_session.c

Fix Common Typo's.

2017-12-20 12:40:01 -05:00

res_pjsip_session.exports.in

res_pjsip: Add REF_DEBUG info to module references.

2017-10-04 12:00:47 -04:00

res_pjsip_sips_contact.c

…

res_pjsip_t38.c

res_pjsip_t38: Better error checking for t38_create_media_state.

2017-11-07 12:34:19 -05:00

res_pjsip_transport_management.c

res_pjsip: PJSIP Transport state monitor refactor.

2017-08-10 12:18:58 -05:00

res_pjsip_transport_websocket.c

res_pjsip_transport_websocket: Give transport a meaningful description

2017-11-16 17:29:11 -05:00

res_pjsip_xpidf_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 11:25:07 -05:00

res_pjsip.c

AST-2017-014: res_pjsip - Missing contact header can cause crash

2017-12-22 15:34:39 -06:00

res_pjsip.exports.in

res_pjsip: Add REF_DEBUG info to module references.

2017-10-04 12:00:47 -04:00

res_pktccops.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_pktccops.exports.in

…

res_realtime.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_resolver_unbound.c

aco: Minimize use of regex.

2017-12-15 10:14:31 -05:00

res_rtp_asterisk.c

res_rtp_asterisk: Avoid close the rtp/rtcp fd twice.

2017-12-19 10:39:55 +08:00

res_rtp_multicast.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_rtp_multicast.exports.in

multicast RTP: Add dialing options

2016-05-27 11:00:09 -05:00

res_sdp_translator_pjmedia.c

res_sdp_translator_pjmedia: Fix test unregistration.

2017-10-05 20:55:31 -04:00

res_security_log.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_smdi.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_smdi.exports.in

…

res_snmp.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_sorcery_astdb.c

astdb: Improve prefix searches in astdb

2017-12-10 12:51:16 -06:00

res_sorcery_config.c

sorcery: Add ast_sorcery_retrieve_by_prefix()

2017-11-13 15:15:33 -05:00

res_sorcery_memory_cache.c

sorcery: Add ast_sorcery_retrieve_by_prefix()

2017-11-13 15:15:33 -05:00

res_sorcery_memory.c

sorcery: Add ast_sorcery_retrieve_by_prefix()

2017-11-13 15:15:33 -05:00

res_sorcery_realtime.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_speech.c

res_stasis and res_speech: Fix load order.

2017-12-07 19:39:04 -06:00

res_speech.exports.in

…

res_srtp.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_srtp.exports.in

…

res_stasis_answer.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_stasis_answer.exports.in

…

res_stasis_device_state.c

res_stasis_device_state.c: Optimize stasis_app_device_states_to_json()

2017-11-03 12:43:11 -05:00

res_stasis_device_state.exports.in

…

res_stasis_mailbox.c

res_stasis_mailbox.c: Fix leak of mailbox container.

2017-11-03 12:18:08 -05:00

res_stasis_mailbox.exports.in

…

res_stasis_playback.c

res_stasis_playback: Check for failure to append vector.

2017-11-06 18:38:35 -05:00

res_stasis_playback.exports.in

…

res_stasis_recording.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_stasis_recording.exports.in

…

res_stasis_snoop.c

res/res_stasis_snoop: generate silence when audiohook returns null

2017-07-13 09:46:53 -05:00

res_stasis_snoop.exports.in

…

res_stasis_test.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_stasis_test.exports.in

…

res_stasis.c

res_stasis and res_speech: Fix load order.

2017-12-07 19:39:04 -06:00

res_stasis.exports.in

…

res_statsd.c

aco: Minimize use of regex.

2017-12-15 10:14:31 -05:00

res_statsd.exports.in

…

res_stun_monitor.c

res_stun_monitor: Don't fail to load if DNS resolution fails

2017-04-14 16:55:03 -05:00

res_timing_dahdi.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_timing_kqueue.c

…

res_timing_pthread.c

Remove as much trailing whitespace as possible.

2017-12-22 09:23:22 -05:00

res_timing_timerfd.c

…

res_xmpp.c

aco: Minimize use of regex.

2017-12-15 10:14:31 -05:00

res_xmpp.exports.in

…

res.xml

build_tools: Add ability to download variants to download_externals

2016-09-25 13:40:23 -05:00