Commit Graph

199 Commits

Author SHA1 Message Date
Jason Parker
bc21189921 Fix a crash that could occur in cdr_csv when mutliple threads tried to close the same file.
Do we actually need the locking here?  What happens if you open the same file twice, and
 two threads try to write to it at the same time?  Is fputs() going to write out the entire
 line at once?  I suspect that it could be possible for the second fopen to run during the
 first fputs, so the position could be in the middle of the previously written line...

Issue 10347, initial patch by explidous (but I removed all of the paranoia stuff..)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82344 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-13 20:11:40 +00:00
Tilghman Lesher
34f8812c64 Portability fix for devmode compiling (closes bug #10382)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-05 14:18:00 +00:00
Joshua Colp
c28511d8ba (closes issue #10310)
Reported by: prashant_jois
Patches:
      cdr_pgsql.patch uploaded by prashant (license 114)
Finish the Postgresql connection after the log messages are printed so we don't access invalid memory.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-27 17:04:08 +00:00
Mark Michelson
e9c7f6f4f2 Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77318 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-26 18:30:29 +00:00
Steve Murphy
a0e2381888 Merged revisions 70804 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r70804 | murf | 2007-06-21 13:13:17 -0600 (Thu, 21 Jun 2007) | 1 line

it was pointed out that the cdr_custom config load could get a lock, and under certain circumstances, would never release it. I also noted that the situation where more than one mapping spec was warned about, but did not ignore further mappings as it had promised. I think I have fixed both situations.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70841 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 20:19:36 +00:00
Jason Parker
b035606357 Fix some potential memory leaks in cdr_pgsql.
Issue 10020, patch by my, with credit to prashant_jois for pointing out the problem.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70612 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:32:39 +00:00
Jason Parker
b7447818de Fix a stupid mistake in my last cdr_pgsql race condition fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 22:55:21 +00:00
Jason Parker
6fd76e7bc3 Fix a race condition in cdr_pgsql that can occur when reloading the module.
Issue 10022, patch by me, with credit to prashant_jois for finding the bug.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 22:31:35 +00:00
Russell Bryant
cbdc6b5b2d To prevent 92138749238754 more reports of "I have unixodbc installed, but
still can't build *_odbc.so!", check for ltdl directly, instead of just listing
it as another library to include in the unixodbc check in the configure script.
This also makes ltdl show up as a dependency in menuselect so people know what
to go install.  (related to issue #9989, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69702 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 16:35:02 +00:00
Kevin P. Fleming
ae82d97c6d use ast_localtime() in every place localtime_r() was being used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 21:50:40 +00:00
Russell Bryant
5aea57eed1 Fix a memory leak pointed out by prashant_jois in #asterisk-bugs. PQclear() was
not called on the result structure after doing a PQexec().  Also, fix up some
formatting in passing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:40:17 +00:00
Steve Murphy
55f4eb3e3d a)In chan_zap, set the clid, src fields in channel_alloc call. b)in the channel_alloc func, set the cid_num and name fields from the arglist[blush]. c) don't update the channel app & app data fields if you are in the 'h' extension. d)the load_module func in cdr_radius needs to return DECLINE, SUCCESS.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-02 17:10:50 +00:00
Tilghman Lesher
55ccc79050 Merged revisions 59301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r59301 | tilghman | 2007-03-29 11:04:46 -0500 (Thu, 29 Mar 2007) | 3 lines

Issue 9415 - No point to getting a diagnostic field if we aren't doing anything with the information.
(Plus, it tends to crash the Postgres ODBC driver.)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59302 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-29 16:07:05 +00:00
Jason Parker
4ed22c8198 Reverse some logic in cdr_manager, which made it fail to load if the config file existed.
Issue 8777


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50346 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-10 16:45:36 +00:00
Joshua Colp
595f01984f Merged revisions 47583 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47583 | file | 2006-11-13 16:26:36 -0500 (Mon, 13 Nov 2006) | 2 lines

Initialize global pointers for connection and result to NULL. (issue #8356 reported by james)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 21:28:57 +00:00
Kevin P. Fleming
ce4b0afb73 apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 14:32:08 +00:00
Joshua Colp
7a0a5b1480 Merged revisions 45927 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r45927 | file | 2006-10-22 20:25:28 -0400 (Sun, 22 Oct 2006) | 2 lines

Don't leak memory mmmk?

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-23 00:27:39 +00:00
Tilghman Lesher
b727a4bde3 Merged revisions 43409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r43409 | tilghman | 2006-09-21 11:18:19 -0500 (Thu, 21 Sep 2006) | 2 lines

TDS 0.64 updates

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43410 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 16:31:59 +00:00
Tilghman Lesher
8e81e20658 One last forgotten constified file
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 21:14:33 +00:00
Russell Bryant
cb268c0228 resolve compiler warnings from constification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 21:08:32 +00:00
Joshua Colp
e8b820e743 Magical eightball says warnings be gone.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 21:03:37 +00:00
Tilghman Lesher
70af28270d Constify the result of a config retrieval function, to avoid mutilation (issue 7983).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43364 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 20:40:39 +00:00
Russell Bryant
eb3db2fc15 fix some breakage, MOG DID IT!!!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 21:50:55 +00:00
Matt O'Gorman
05a695af72 everything that loads a config that needs a config file to run
now reports AST_MODULE_LOAD_DECLINE when loading if config file
is not there, also fixed an error in res_config_pgsql where it 
had a non static function when it should.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41633 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 21:00:20 +00:00
Kevin P. Fleming
d12f54f90b GNU make already knows how to quietly ignore non-existent files in 'include' directives
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41209 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-26 23:58:47 +00:00
Kevin P. Fleming
0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00
Kevin P. Fleming
000ba592b2 more Makefile cleanup and consistency stuff
don't reuse LIBS variable from top-level Makefile (oops)
build Asterisk binary after subdirs (preparing for embedded modules)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37661 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-15 19:59:35 +00:00
Kevin P. Fleming
748431f7b6 move rules file to prepare for generic rules file
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37222 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-06 21:04:28 +00:00
Kevin P. Fleming
dbf099cdb8 update dependency information to match new names for dependencies
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37085 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-05 20:12:29 +00:00
Kevin P. Fleming
98a465fc09 move FreeTDS version check into configure script
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36255 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-29 07:50:01 +00:00
Kevin P. Fleming
a579371f43 use new (separate) dependencies file from menuselect
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-25 08:50:14 +00:00
Kevin P. Fleming
e61d3d91f3 The Eurostar Commit! (it's amazing how much work you can get done on a 150 minute train ride from Paris to London <G>)
support the new location for zaptel.h and tonezone.h
use the dependency information output by menuselect to build Makefile rules for each module for header files and libraries
combine the common rules into a top-level Makefile.rules file
remove all (now) unnecessary stuff from subdir Makefiles
change translator API so that the newpvt() callback returns an int instead of a pointer (it no longer allocates memory)
alphabetize --with-<foo> options in configure script
enhance Net-SNMP support in configure script to provide a --with-netsnmp option
fix support for --with-pq so that if pg-config is not found when --with-pq is specified, an error will be generated
add 'optional package' usage to modules now that menuselect can output it
allow res_snmp to build by default, since the new loader changes coming soon will solve the function naming problem (and users can disable it via menuselect anyway)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-24 19:43:31 +00:00
Russell Bryant
48ae9f0d4f - convert the 'uninstall' target to use separate targets to process each
subdirectory instead of a for loop
- remove the FORCE target from the main Makefile and add the couple places
  I used it to the .PHONY target.  .PHONY does the same thing and is a built-in
  more efficient way of doing it.
- add a bunch more targets to .PHONY ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35503 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 15:38:13 +00:00
Russell Bryant
55e8a60363 - specify that 'depend' is a .PHONY target
- use separate targets instead of a for loop for doing 'make depend' for
  each sub directory


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 15:08:08 +00:00
Russell Bryant
9db0520ff9 - specify that 'all' is a .PHONY target
- add a copyright header to the build_tools Makefile
- remove 'depend' from the 'all' target in agi/ and utils/ since it is handled
  by the main Makefile already


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35479 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 14:09:18 +00:00
Russell Bryant
c399a06450 add the 'clean', 'clean-depend', and 'dist-clean' targets as .PHONY targets
since they are targets that do not have resulting files and are never listed
as prerequisites to real targets.  Using .PHONY in this manner improves make
performance by never having to check for resulting files.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@35415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-22 11:27:03 +00:00
Russell Bryant
9f2a6516cf don't blow up in the sub Makefiles if menuselect.makeopts is not present. This
is valid in some cases, such as "make clean".


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34738 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 00:14:16 +00:00
Russell Bryant
b6147a21b9 remove "depend" from the "all" targets in sub Makefiles. The main Makefile
already calls "make depend" for each of the subdirectories


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-16 16:54:00 +00:00
Kevin P. Fleming
8d88bf549d there is no reason to define our own 'maximum path length' when the POSIX headers already define one for us
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 20:40:10 +00:00
Kevin P. Fleming
472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Russell Bryant
503f99e2e8 remove the need to have to re-run make after a default menuselect.makeopts
file is generated.  This allows a fresh checkout of asterisk to be built
and installed with the standard "./configure && make && make install".


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 16:03:31 +00:00
Kevin P. Fleming
e856010714 use module names, not file names, in menuselect
work around XML parsing bug in menuselect for default sounds package


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-05 20:46:27 +00:00
Russell Bryant
a8c1284633 change a warning message to a debug message
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31226 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 00:15:25 +00:00
Russell Bryant
b0ee67ebdc remove a bunch of duplicated log messages. There is a warning that gets
logged when this function returns an error


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-30 11:23:48 +00:00
Russell Bryant
1fcc86d905 Add support for logging CDR recrods to a radius server (issue #6639, phsultan)
- with contributions from miconda, jcollie, and sb
 - branch maintained by oej
Thanks everyone!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 22:30:05 +00:00
Russell Bryant
d8f4a04acc remove an unused variable, and default the user to asterisk if not specified
in the config file (issue #7153, Mithraen)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28936 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 01:35:12 +00:00
Russell Bryant
f1a97c3b3f various fixes regarding coding guidelines issues
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 01:29:08 +00:00
Russell Bryant
0523e82f46 if a hostname is not specified, connect over a unix socket instead of
connecting to localhost (issue #7145, Mithraen)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 00:57:04 +00:00
Kevin P. Fleming
d7aead737d Merged revisions 23673 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r23673 | kpfleming | 2006-04-30 09:27:56 -0500 (Sun, 30 Apr 2006) | 2 lines

allow top-level OPTIMIZE setting to affect builds in these subdirectories too

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@23674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-30 14:28:25 +00:00
Kevin P. Fleming
574e14cbea Thanks to the fine work of Russell Bryant and Dancho Lazarov, we now have autoconf and menuselect tools for Asterisk!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-24 17:11:45 +00:00