Commit Graph

20253 Commits

Author SHA1 Message Date
Eliel C. Sardanons
7eafb1a763 When creating a conference for a unit test, it is not mandatory to open a
dahdi pseudo channel, so if we fail doing it, continue creating the conference.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-10 20:49:30 +00:00
Russell Bryant
fcaac09507 Make indentation consistent, move some queue features to the queue section.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-10 14:48:03 +00:00
Russell Bryant
405d6cdf31 Add support for devices with less than 3 lines on the LCD.
(closes issue #17600)
Reported by: minaguib
Patches:
      ast_unistim_height_v2.patch uploaded by minaguib (license 1078)
Tested by: minaguib


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-10 14:44:18 +00:00
Russell Bryant
b4ba8548e1 Fix some issues related to dynamic feature groups in features.conf.
The bridge handling code did not properly consider feature groups when setting
parameters that would affect whether or not a native bridge would be attempted.
If DYNAMIC_FEATURES only include a feature group, a native bridge would occur
that may prevent features from working.

Fix a bug in verbose output that would show the key mapping as empty if it was
using the default mapping and not a custom mapping in the feature group.

Add feature groups to the output of "features show".

Adjust the feature execution logic to match that of the logic when executing
a feature that was not configured through a feature group.

Update features.conf.sample to show that an '=' is still required if using
the default key mapping from [applicationmap].

Finally, clean up a little bit of formatting to better coform to coding
guidelines while in the area.

(closes issue #17589)
Reported by: lmadsen
Patches:
      issue_17589.rev4.txt uploaded by russell (license 2)
Tested by: russell, lmadsen


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 21:57:21 +00:00
Mark Michelson
7b1e28c6a1 Fix error in parsing SIP registry strings from ASTdb.
It was essentially an off-by-one error. The easiest way
to fix this was to use the handy-dandy AST_NONSTANDARD_RAW_ARGS
macro to parse the pieces of the registration string out. Tested
and it works wonderfully.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275385 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 20:58:52 +00:00
Tilghman Lesher
2fdf43f9fc Get more information about the Bamboo test failures
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 20:01:01 +00:00
Russell Bryant
eaaeb7a1bc Add missing ao2_iterator_destroy().
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275310 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 19:58:06 +00:00
Russell Bryant
c5476ecb69 Fix compile error.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275309 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 19:56:41 +00:00
Mark Michelson
e46325f18c Fix port parsing in check_via.
If a Via header contained an IPv6 address, we would not properly parse
the port. We would instead get the information after the first colon in
the address.

(closes issue #17614)
Reported by: oej
Patches: 
      diff uploaded by sperreault (license 252)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275308 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 19:46:20 +00:00
Paul Belanger
d348c9aa1e Include rdnis in msgXXXX.txt file.
(closes issue #17566)
Reported by: outcast
Patches:
      voicemail-rdnis.patch uploaded by outcast (license 1071)
Tested by: outcast


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 19:32:47 +00:00
Mark Michelson
7e6f9b4e2d Fix an issue where the port for p->ourip was being set to 0.
This should fix all the CDR tests that were not passing. When they would
originate a call, all fields in the INVITE that contained the source port would
have the port set to 0. Most troubling of these was the Contact header. Tests
are passing locally now and should also pass on the bamboo build agents.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 19:29:30 +00:00
Paul Belanger
d2872c60e4 Merged revisions 275241 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r275241 | pabelanger | 2010-07-09 15:20:00 -0400 (Fri, 09 Jul 2010) | 8 lines
  
  Fix logging message for stale nonce.
  
  (closes issue #17582)
  Reported by: kenner
  Patches:
        chan_sip.c.diff uploaded by kenner (license 1040)
  Tested by: lmadsen
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 19:21:27 +00:00
Tilghman Lesher
d6011adab4 Weird, no output and Bamboo still fails...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275227 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 18:55:02 +00:00
Matthew Nicholson
7f145eeb1b Merged revisions 275182 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r275182 | mnicholson | 2010-07-09 13:23:23 -0500 (Fri, 09 Jul 2010) | 2 lines
  
  give a better error message when attempting to unload a module that is not loaded
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 18:24:03 +00:00
Tilghman Lesher
384681e182 Add some diagnostic feedback to our data tests
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275172 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 18:21:39 +00:00
Russell Bryant
2d63b5735c Move parking lot sample config out from the middle of dynamic features sample config.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275147 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 18:11:13 +00:00
Matthew Nicholson
3fd53f575c Merged revisions 275143 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r275143 | mnicholson | 2010-07-09 12:50:05 -0500 (Fri, 09 Jul 2010) | 2 lines
  
  don't unload modules that returned AST_MODULE_LOAD_DECLINE when they were loaded
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275144 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 17:50:45 +00:00
Tilghman Lesher
da8450323f Kill some startup warnings and errors and make some messages more helpful in tracking down the source.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275105 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 17:00:22 +00:00
Mark Michelson
5f92aed2ba Return logic of sip_debug_test_addr() to its original functionality.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 16:39:16 +00:00
Matthew Nicholson
759872902a Merged revisions 275027 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r275027 | mnicholson | 2010-07-09 11:04:21 -0500 (Fri, 09 Jul 2010) | 8 lines
  
  Clear the AST_CDR_FLAG_DIALED flag for channels going into the pbx via the G option in app_dial
  
  (closes issue #17592)
  Reported by: jamicque
  Patches:
        G-flag-cdr-fix1.diff uploaded by mnicholson (license 96)
  Tested by: jamicque, mnicholson
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 16:05:58 +00:00
Russell Bryant
9aa4771a8d Merged revisions 275021 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r275021 | russell | 2010-07-09 10:33:08 -0500 (Fri, 09 Jul 2010) | 4 lines
  
  Document that a leading and trailing slash is expected for test categories.
  
  Also, emit a warning if a test is registered without one of these.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@275022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 15:35:53 +00:00
Mark Michelson
0cc20f86ba Fix sip_uri_parse test comparison.
Part of the change with the IPv6 changes is to treat a host:port as
a single 'domain' entity. This test was not updated to have the correct
expectation after calling parse_uri().



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274984 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 14:27:07 +00:00
53071af180 Copy the address into the peer structure after we set the default port
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 13:30:37 +00:00
21dc81bb31 Sadly we can't dereference a pointer cast and use it as an lvalue without getting this
warning (at least with gcc 4.4.4):

netsock2.c:492: warning: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules

So we're back to using memcpy()...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 12:56:18 +00:00
Russell Bryant
e10dcd165b Extend length limit on country name in indications.conf.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274907 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 12:48:25 +00:00
Olle Johansson
28cbe2f75e Make it possible to disable individual cdr files per accountcode in cdr_csv
Review: https://reviewboard.asterisk.org/r/678/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-09 11:06:19 +00:00
Richard Mudgett
c0fd67750b Fix calls of ast_sockaddr_from_sin() from IPv6 integration.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 23:46:20 +00:00
Richard Mudgett
9d81fc3273 Fix compile of chan_ooh323.c from IPv6 integration.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 23:23:17 +00:00
Mark Michelson
9bd88923f6 And the automerge property.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 22:16:16 +00:00
Mark Michelson
f565ab8071 Delete properties I merged during v6-new merge.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 22:15:25 +00:00
Mark Michelson
cd4ebd336f Add IPv6 to Asterisk.
This adds a generic API for accommodating IPv6 and IPv4 addresses
within Asterisk. While many files have been updated to make use of the
API, chan_sip and the RTP code are the files which actually support
IPv6 addresses at the time of this commit. The way has been paved for
easier upgrading for other files in the near future, though.

Big thanks go to Simon Perrault, Marc Blanchet, and Jean-Philippe Dionne
for their hard work on this.

(closes issue #17565)
Reported by: russell
Patches: 
      asteriskv6-test-report.pdf uploaded by russell (license 2)

Review: https://reviewboard.asterisk.org/r/743



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 22:08:07 +00:00
Richard Mudgett
816f26c16c Generate a correct AstData string for ast_callerid.cid_ton
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 22:05:40 +00:00
Richard Mudgett
25a3c313b5 Fix trunk compile.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 19:12:55 +00:00
Eliel C. Sardanons
a1b89a6a50 Implement AstData API data providers as part of the GSOC 2010 project,
midterm evaluation.

Review: https://reviewboard.asterisk.org/r/757/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274727 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-08 14:48:42 +00:00
David Vossel
21f8c77934 Fixes some ref count issues introduced by r274539
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 20:09:00 +00:00
Richard Mudgett
fd3297a272 Add missing conditional around chan_dahdi mfcr2_skip_category config parameter.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 18:32:35 +00:00
Richard Mudgett
d20ca64e70 Merged revisions 274579 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r274579 | rmudgett | 2010-07-07 13:12:41 -0500 (Wed, 07 Jul 2010) | 1 line
  
  Close the DAHDI FD on error when processing chan_dahdi toneduration config parameter.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 18:20:00 +00:00
Matthew Nicholson
f03b3691ea Set proper FAXOPT(status), FAXOPT(statusstr), and FAXOPT(error) values where possible. Previously some failure cases did not result in proper FAXOPT values.
FAX-203


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 16:40:19 +00:00
Mark Michelson
d6f8dd67f7 Use the relatedpeer field of a sip_pvt during INVITE processing.
Review: https://reviewboard.asterisk.org/r/629



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 16:21:53 +00:00
TransNexus OSP Development
d6a70b619c Changed OSP TCP port from 1080 to 5045.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 07:07:08 +00:00
Tilghman Lesher
1eaa09a0a2 Also run the externnotify script when the pollmailboxes thread notices a change.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 06:32:39 +00:00
Tilghman Lesher
c722342660 Merged revisions 274417 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r274417 | tilghman | 2010-07-07 01:13:54 -0500 (Wed, 07 Jul 2010) | 8 lines
  
  Correct how 100, 200, 300, etc. is said.  Also add the crazy British numbers.
  
  (closes issue #16102)
   Reported by: Delvar
   Patches: 
         say.conf.fix.patch uploaded by Delvar (license 908)
         (plus a few additional fixes and simplifications by me)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-07 06:15:43 +00:00
Jeff Peeler
6652749c39 Merged revisions 274283 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r274283 | jpeeler | 2010-07-06 17:15:21 -0500 (Tue, 06 Jul 2010) | 7 lines
  
  Correct sip.conf.sample comments for prematuremedia option.
  
  (closes issue #17513)
  Reported by: festr
  Patches: 
        patch uploaded by festr (license 443)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 22:23:35 +00:00
Terry Wilson
745f4edbd5 Merged revisions 274280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r274280 | twilson | 2010-07-06 17:08:20 -0500 (Tue, 06 Jul 2010) | 9 lines
  
  Add option to not do a call forward on 482 Loop Detected
  
  Asterisk has always set up a forwarded call when receiving a 482 Loop Detected.
  This prevents handling the call failure by just continuing on in the dialplan.
  Since this would be a change in behavior, the new option to disable this
  behavior is forwardloopdetected which defaults to 'yes'.
  
  Review: https://reviewboard.asterisk.org/r/764/
........

(no option for trunk, just changing the behavior)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274284 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 22:15:27 +00:00
Tilghman Lesher
5754933045 Status shows all non-CRC4 lines as "yellow", even if "yellow" was not in the bitfield.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274281 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 22:09:23 +00:00
Matthew Nicholson
390d5781cf Properly detect and report invalid maxrate and maxrate values in the FAXOPT dialplan function. Also make fax_rate_str_to_int() return an unsigned int and return 0 instead of -1 in the event of an error.
FAX-202


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 19:53:04 +00:00
Mark Michelson
41cdf6a720 Merged revisions 274157 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r274157 | mmichelson | 2010-07-06 09:29:23 -0500 (Tue, 06 Jul 2010) | 16 lines
  
  Fix problem with RFC 2833 DTMF not being accepted.
  
  A recent check was added to ensure that we did not erroneously
  detect duplicate DTMF when we received packets out of order.
  The problem was that the check did not account for the fact that
  the seqno of an RTP stream will roll over back to 0 after hitting
  65535. Now, we have a secondary check that will ensure that the
  seqno rolling over will not cause us to stop accepting DTMF.
  
  (closes issue #17571)
  Reported by: mdeneen
  Patches: 
        rtp_seqno_rollover.patch uploaded by mmichelson (license 60)
  Tested by: richardf, maxochoa, JJCinAZ
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274164 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 14:31:13 +00:00
Matthew Nicholson
b0c366d1cd Blocked revisions 274093 via svnmerge
........
  r274093 | mnicholson | 2010-07-06 08:52:28 -0500 (Tue, 06 Jul 2010) | 2 lines
  
  Make get_member_status return QUEUE_NO_MEMBERS instead of QUEUE_NO_REACHABLE_MEMBERS to make joinempty=no work again.  This regression was introduced in 273639.  Also fixed whitespace.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 13:52:56 +00:00
Tilghman Lesher
8fe8d98dba Uh, yeah.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@274053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-06 06:01:37 +00:00
Tilghman Lesher
73c617efd3 Blocked revisions 273981 via svnmerge
........
  r273981 | tilghman | 2010-07-05 14:48:42 -0500 (Mon, 05 Jul 2010) | 2 lines
  
  Command 'stop gracefully' doesn't.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@273982 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-05 20:00:48 +00:00