Commit Graph

33925 Commits

Author SHA1 Message Date
George Joseph
378166230a .github: Updates for AsteriskReleaser 2023-06-30 07:02:18 -06:00
Mike Bradeen
5f01983abd app_voicemail: fix imap compilation errors
Fixes two compilation errors in app_voicemail_imap, one due to an unsed
variable and one due to a new variable added in the incorrect location
in _163.

Resolves: #174
2023-06-29 16:08:11 +00:00
Mike Bradeen
98d8e9b943 res_musiconhold: avoid moh state access on unlocked chan
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
2023-06-29 15:15:06 +00:00
Mike Bradeen
a0ce65e999 utils: add lock timestamps for DEBUG_THREADS
Adds last locked and unlocked timestamps as well as a
counter for the number of times the lock has been
attempted (vs locked/unlocked) to debug output printed
using the DEBUG_THREADS option.

Resolves: #110
2023-06-29 15:13:47 +00:00
George Joseph
398a77894c .github: Back out triggering PROpenedOrUpdated by label 2023-06-29 09:07:00 -06:00
George Joseph
58098d248b .github: Move publish docs to new file CreateDocs.yml 2023-06-27 12:18:46 -06:00
George Joseph
812156edfd rest-api: Updates for new documentation site
The new documentation site uses traditional markdown instead
of the Confluence flavored version.  This required changes in
the mustache templates and the python that generates the files.
2023-06-27 08:34:09 -06:00
George Joseph
248b0637ff .github: Remove result check from PROpenUpdateGateTests 2023-06-27 05:18:08 -06:00
George Joseph
3c0dd827d1 .github: Fix use of 'contains' 2023-06-26 08:45:36 -06:00
George Joseph
458312a24f .github: Add recheck label test to additional jobs 2023-06-26 07:46:17 -06:00
George Joseph
5866e09654 .github: Fix recheck label typos 2023-06-26 07:22:03 -06:00
George Joseph
58eeb907dd .github: Fix recheck label manipulation 2023-06-26 07:11:52 -06:00
George Joseph
f747de39f4 .github: Allow PR submit checks to be re-run by label 2023-06-26 07:08:01 -06:00
Olaf Titz
3b23ee4203 app_voicemail_imap: Fix message count when IMAP server is unavailable
Some callers of __messagecount did not correctly handle error return,
instead returning a -1 message count.
This caused a notification with "Messages-Waiting: yes" and
"Voice-Message: -1/0 (0/0)" if the IMAP server was unavailable.

Fixes: #64
2023-06-26 13:03:20 +00:00
Sean Bright
897bb03de2 res_pjsip_rfc3326: Prefer Q.850 cause code over SIP.
Resolves: #116
2023-06-21 13:24:57 +00:00
Ben Ford
23c4d21d1b res_pjsip_session: Added new function calls to avoid ABI issues.
Added two new functions (ast_sip_session_get_dialog and
ast_sip_session_get_pjsip_inv_state) that retrieve the dialog and the
pjsip_inv_state respectively from the pjsip_inv_session on the
ast_sip_session struct. This is due to pjproject adding a new field to
the pjsip_inv_session struct that caused crashes when trying to access
fields that were no longer where they were expected to be if a module
was compiled against a different version of pjproject.

Resolves: #145
2023-06-13 17:59:03 +00:00
Nathan Bruning
c88a8aa8b0 app_queue: Add force_longest_waiting_caller option.
This adds an option 'force_longest_waiting_caller' which changes the
global behavior of the queue engine to prevent queue callers from
'jumping ahead' when an agent is in multiple queues.

Resolves: #108

Also closes old asterisk issues:
- ASTERISK-17732
- ASTERISK-17570

Change-Id: I0f84e27903fefbe2018d0afa2d67b23aa0b321ce
2023-06-12 18:20:30 +00:00
Sean Bright
c3abc4d536 pjsip_transport_events.c: Use %zu printf specifier for size_t.
Partially resolves #143.
2023-06-12 17:20:28 +00:00
Sean Bright
e06bb85ad3 res_crypto.c: Gracefully handle potential key filename truncation.
Partially resolves #143.
2023-06-12 17:20:28 +00:00
Sean Bright
a36af23f20 configure: Remove obsolete and deprecated constructs.
These were uncovered when trying to run `bootstrap.sh` with Autoconf
2.71:

* AC_CONFIG_HEADER() is deprecated in favor of AC_CONFIG_HEADERS().
* AC_HEADER_TIME is obsolete.
* $as_echo is deprecated in favor of AS_ECHO() which requires an update
  to ax_pthread.m4.

Note that the generated artifacts in this commit are from Autoconf 2.69.

Resolves #139
2023-06-12 17:19:55 +00:00
zhou_jiajian
e1f8dac6be res_fax_spandsp.c: Clean up a spaces/tabs issue 2023-06-12 17:19:25 +00:00
Sean Bright
03ba015f2e ast-db-manage: Synchronize revisions between comments and code.
In a handful of migrations, the comment header that indicates the
current and previous revisions has drifted from the identifiers
revision and down_revision variables. This updates the comment headers
to match the code.
2023-06-12 14:40:12 +00:00
George Joseph
b096474f00 test_statis_endpoints: Fix channel_messages test again 2023-06-12 08:37:50 -06:00
Sean Bright
0642f4cb1d res_crypto.c: Avoid using the non-portable ALLPERMS macro.
ALLPERMS is not POSIX and it's trivial enough to not jump through
autoconf hoops to check for it.

Fixes #149.
2023-06-12 14:22:49 +00:00
Jaco Kroon
4e657b6181 tcptls: when disabling a server port, we should set the accept_fd to -1.
If we don't set this to -1 if the structure can be potentially re-used
later then it's possible that we'll issue a close() on an unrelated file
descriptor, breaking asterisk in other interesting ways.

I believe this to be an unlikely scenario, but it costs nothing to be
safe.

Signed-off-by: Jaco Kroon <jaco@uls.co.za>
2023-06-12 14:07:29 +00:00
Jiajian Zhou
84b48b6af1 AMI: Add parking position parameter to Park action
Add a parking space extension parameter (ParkingSpace) to the Park action.
Park action will attempt to park the call to that extension.
If the extension is already in use, then execution will continue at the next priority.

UserNote: New ParkingSpace parameter has been added to AMI action Park.
2023-06-12 13:56:32 +00:00
George Joseph
833543df0d test_stasis_endpoints.c: Make channel_messages more stable
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
2023-06-09 23:28:03 +00:00
George Joseph
acb18c1fc4 build: Fix a few gcc 13 issues
* gcc 13 is now catching when a function is declared as returning
  an enum but defined as returning an int or vice versa.  Fixed
  a few in app.h, loader.c, stasis_message.c.

* gcc 13 is also now (incorrectly) complaining of dangling pointers
  when assigning a pointer to a local char array to a char *. Had
  to change that to an ast_alloca.

Resolves: #155
2023-06-09 18:19:46 +00:00
George Joseph
b3ded75e17 .github: Rework for merge approval 2023-06-08 13:34:45 -06:00
Sean Bright
84d266d4f4 ast-db-manage: Fix alembic branching error caused by #122.
Fixes #147.
2023-06-06 10:14:06 +00:00
alex2grad
591351d4ad app_followme: fix issue with enable_callee_prompt=no (#88)
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326
2023-06-05 13:07:35 -06:00
Sean Bright
ade23d24a0 sounds: Update download URL to use HTTPS.
Related to #136
2023-06-05 18:44:55 +00:00
Miguel Angel Nubla
4c2f035a35 configure: Makefile downloader enable follow redirects.
If curl is used for building, any download such as a sounds package
will fail to follow HTTP redirects and will download wrong data.

Resolves: #136
2023-06-05 18:38:13 +00:00
Naveen Albert
2b302e30e4 res_musiconhold: Add option to loop last file.
Adds the loop_last option to res_musiconhold,
which allows the last audio file in the directory
to be looped perpetually once reached, rather than
circling back to the beginning again.

Resolves: #122
ASTERISK-30462

UserNote: The loop_last option in musiconhold.conf now
allows the last file in the directory to be looped once reached.
2023-06-05 18:35:57 +00:00
Naveen Albert
3260434b96 chan_dahdi: Fix Caller ID presentation for FXO ports.
Currently, the presentation for incoming channels is
always available, because it is never actually set,
meaning the channel presentation can be nonsensical.
If the presentation from the incoming Caller ID spill
is private or unavailable, we now update the channel
presentation to reflect this.

Resolves: #120
ASTERISK-30333
ASTERISK-21741
2023-06-05 18:34:10 +00:00
Ben Ford
d6d77dc1fb AMI: Add CoreShowChannelMap action.
Adds a new AMI action (CoreShowChannelMap) that takes in a channel name
and provides a list of all channels that are connected to that channel,
following local channel connections as well.

Resolves: #104

UserNote: New AMI action CoreShowChannelMap has been added.
2023-06-05 18:30:41 +00:00
Naveen Albert
f56477a604 sig_analog: Add fuller Caller ID support.
A previous change, ASTERISK_29991, made it possible
to send additional Caller ID parameters that were
not previously supported.

This change adds support for analog DAHDI channels
to now be able to receive these parameters for
on-hook Caller ID, in order to enhance the usability
of CPE that support these parameters.

Resolves: #94
ASTERISK-30331

UserNote: Additional Caller ID properties are now supported on
incoming calls to FXS stations, namely the
redirecting reason and call qualifier.
2023-06-05 18:28:59 +00:00
Joe Searle
d417ab86e1 res_stasis.c: Add new type 'sdp_label' for bridge creation.
Add new type 'sdp_label' when creating a bridge using the ARI. This will
add labels to the SDP for each stream, the label is set to the
corresponding channel id.

Resolves: #91

UserNote: When creating a bridge using the ARI the 'type' argument now
accepts a new value 'sdp_label' which will configure the bridge to add
labels for each stream in the SDP with the corresponding channel id.
2023-06-05 18:27:17 +00:00
Niklas Larsson
12fb5d8589 app_queue: Preserve reason for realtime queues
When Asterisk is restarted it does not preserve paused reason for
members of realtime queues. This was fixed for non-realtime queues in
ASTERISK_25732

Resolves: #66

UpgradeNote: Add a new column to the queue_member table:
reason_paused VARCHAR(80) so the reason can be preserved.

UserNote: Make paused reason in realtime queues persist an
Asterisk restart. This was fixed for non-realtime
queues in ASTERISK_25732.
2023-06-05 18:20:21 +00:00
George Joseph
4128a922e0 .github: Fix issues with cherry-pick-reminder 2023-06-05 10:38:25 -06:00
Mike Bradeen
4aa213d408 indications: logging changes
Increase verbosity to indicate failure due to missing country
and to specify default on CLI dump

Resolves: #89
2023-06-05 13:31:55 +00:00
George Joseph
1ba39efc9e .github Ignore error when adding reviewrs to PR 2023-06-05 07:16:38 -06:00
George Joseph
a2280e1767 .github: Update field descriptions for AsteriskReleaser 2023-05-26 08:51:57 -06:00
Naveen Albert
8a03ed6877 callerid: Allow specifying timezone for date/time.
The Caller ID generation routine currently is hardcoded
to always use the system time zone. This makes it possible
to optionally specify any TZ-format time zone.

Resolves: #98
ASTERISK-30330
2023-05-25 16:47:46 +00:00
Maximilian Fridrich
a4cd452246 chan_pjsip: Allow topology/session refreshes in early media state
With this change, session modifications in the early media state are
possible if the SDP was sent reliably and confirmed by a PRACK. For
details, see RFC 6337, escpecially section 3.2.

Resolves: #73
2023-05-25 15:16:01 +00:00
Naveen Albert
d496544d7b chan_dahdi: Fix broken hidecallerid setting.
The hidecallerid setting in chan_dahdi.conf currently
is broken for a couple reasons.

First, the actual code in sig_analog to "allow" or "block"
Caller ID depending on this setting improperly used
ast_set_callerid instead of updating the presentation.
This issue was mostly fixed in ASTERISK_29991, and that
fix is carried forward to this code as well.

Secondly, the hidecallerid setting is set on the DAHDI
pvt but not carried forward to the analog pvt properly.
This is because the chan_dahdi config loading code improperly
set permhidecallerid to permhidecallerid from the config file,
even though hidecallerid is what is actually set from the config
file. (This is done correctly for call waiting, a few lines above.)
This is fixed to read the proper value.

Thirdly, in sig_analog, hidecallerid is set to permhidecallerid
only on hangup. This can lead to potential security vulnerabilities
as an allowed Caller ID from an initial call can "leak" into subsequent
calls if no hangup occurs between them. This is fixed by setting
hidecallerid to permcallerid when calls begin, rather than when they end.
This also means we don't need to also set hidecallerid in chan_dahdi.c
when copying from the config, as we would have to otherwise.

Fourthly, sig_analog currently only allows dialing *67 or *82 if
that would actually toggle the presentation. A comment is added
clarifying that this behavior is okay.

Finally, a couple log messages are updated to be more accurate.

Resolves: #100
ASTERISK-30349 #close
2023-05-25 14:50:04 +00:00
George Joseph
714cb00504 .github: Change title of AsteriskReleaser job 2023-05-23 08:04:59 -06:00
Naveen Albert
67d20b8fd8 asterisk.c: Fix option warning for remote console.
Commit 09e989f972
categorized the T option as not being compatible
with remote consoles, but they do affect verbose
messages with remote console. This fixes this.

Resolves: #102
2023-05-22 19:01:01 +00:00
George Joseph
fd98c6cd10 .github: Don't add cherry-pick reminder if it's already present 2023-05-22 12:55:01 -06:00
George Joseph
2c7304e416 .github: Fix quoting in PROpenedOrUpdated 2023-05-16 16:11:58 -06:00