Luigi Rizzo
9ddef9890a
small simplifications and localization of variables.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47667 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:17:07 +00:00
Luigi Rizzo
b588fc320e
new-style "core show channels"
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47665 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:05:55 +00:00
Luigi Rizzo
db923f638e
more changes to new style of "module load" and "load".
...
Under FreeBSD, the filename_completion used in the above commands does
not work. Not sure why, but on passing i note that the function is
part of readline and is not reentrant, so it needs to be fixed one way
or another.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47664 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 16:39:38 +00:00
Luigi Rizzo
f28f07e1b2
move another deprecated command to the new style
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 16:20:23 +00:00
Luigi Rizzo
0e9753f401
move "core set debug" to the new style, and remove duplicated
...
code for the deprecated handler.
On passing fix a long standing bug in find_cli() which would not
find the longest match - this part (trivial, basically
just update matchlen on a match) must go in 1.4 and possibly 1.2 as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 16:13:30 +00:00
Luigi Rizzo
6edcca7b8d
one more step cleaning the internal CLI interface:
...
the NEW_CLI macro now supports extra arguments (to deprecate other commands).
use this to implement unload and reload, and remove some unused functions.
usual completion fixes (as these function accept multiple arguments).
The summary is still a bit inconsistent.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47654 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 15:02:56 +00:00
Luigi Rizzo
1781f41b3b
update the internal cli api following comments from kevin.
...
This change basically simplifies the interface of the
new-style handler removing almost all the tricks used in
the previous implementation to achieve backward compatibility
(which is still present and guaranteed.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 14:11:28 +00:00
Joshua Colp
993c6823e6
Merged revisions 47645 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47645 | file | 2006-11-14 23:45:24 -0500 (Tue, 14 Nov 2006) | 2 lines
If NAT detection is turned on or already detected then say NAT is active when setting the remote RTP peer when doing early bridging. (issue #8365 reported by marcelbarbulescu)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 04:47:52 +00:00
Kevin P. Fleming
f04ac0ad7e
Merged revisions 47641 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47641 | kpfleming | 2006-11-14 18:19:05 -0600 (Tue, 14 Nov 2006) | 2 lines
more formatting cleanup, and avoid running off the end of the string
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 00:19:35 +00:00
Joshua Colp
5861048fb6
Merged revisions 47639 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47639 | file | 2006-11-14 19:14:07 -0500 (Tue, 14 Nov 2006) | 2 lines
Turn notice about unknown RTCP packet type into a debug message instead.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47640 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 00:15:38 +00:00
Luigi Rizzo
fbcc8f4de2
add missing casts and remove an unused function.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47630 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 22:08:20 +00:00
Luigi Rizzo
3d86c80c15
fix completion for "module reload mod_1 mod_2 ... "
...
(should do the same for the other similar commands, "reload", "module unload" and so on.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47620 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 17:00:39 +00:00
Luigi Rizzo
a9259cd8f4
partly convert to new style set-verbose, with completion fixes
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47619 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 16:55:27 +00:00
Luigi Rizzo
6e4ed956bc
replace two deprecated functions with calls to the standard ones,
...
with fixes to argc/argv
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 16:38:35 +00:00
Luigi Rizzo
dfd4448412
remove duplicated implementation for a deprecated function, use the
...
original one instead with appropriate changes in argc/argv.
This is not always applicable, but in some simple cases it is.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 16:31:57 +00:00
Luigi Rizzo
abdb8002df
new-style for 'core show uptime', include 'complete' support and better error checking
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 16:09:08 +00:00
Luigi Rizzo
7d38228d6e
apply previous fix to old-style cli entries as well.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47608 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 15:55:18 +00:00
Luigi Rizzo
ff5160e35c
fix "core set debug atleast ",
...
and fix the simple case where a command can have multiple completions,
the first ones coming from keywords in previous CLI entries.
There is no solution yet for the complex case of N1 completions
from a CLI entry, followed by N2 from the next one, and so on,
because the _complete() handlers do not tell us how many matches
it generates, so we don't know how many to skip when interrogating
the other handlers.
The only solution is to avoid, as much as possible, multiple
CLI entries with the same prefix.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 15:39:03 +00:00
Luigi Rizzo
fbb143b829
Bring in the improved internal API for the CLI.
...
WATCH OUT: this changes the binary interface (ABI) for modules,
so e.g. users of g729 codecs need a rebuilt module (but read below).
The new way to write CLI handlers is described in detail in cli.h,
and there are a few converted handlers in cli.c, look for NEW_CLI.
After converting a couple of commands i am convinced that
it is reasonably convenient to use, and it makes it easier to fix the
pending CLI issues.
On passing, note a bug with the current 'complete' architecture:
if a command is a prefix of multiple CLI entries, we miss some
of the possible options. As an example, "core set debug" can
continue with "channel" from one CLI entry, and "off" or "atleast"
from another one.
We address this problem in a separate commit
(when i have figured out a fix, that is).
ABI issues:
I asked Kevin if it was ok to make this change and he said yes.
While it would have been possible to make the change without breaking
the module ABI, the code would have been more convoluted.
I am happy to restore the old ABI (while still being able
to use the "new style" handlers) if there is demand.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 15:23:35 +00:00
Matt O'Gorman
43aefe9116
fix bytesize to 5.3kb for g723 codec and add support for multimode of tc400p
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47586 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 22:01:43 +00:00
Steve Murphy
cd74836d3a
This solves bug 8342, whereby a crash occurs under certain circumstances while reading a config file with comments-- a call to CB_ADD shouldn't happen if withcomments is zero
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:15:45 +00:00
Joshua Colp
209628c6e2
Return module show to a working state. (issue #8353 reported by jserve)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 16:41:45 +00:00
Luigi Rizzo
06c9ef6411
stop looking for new entries when we know we are done.
...
there is no functional change, so it is not necessary to
bother merging this to 1.4 now.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47537 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 12:04:05 +00:00
Luigi Rizzo
b2e2f3f957
free memory when unregistering an entry.
...
needs to be merged to 1.4
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 12:01:25 +00:00
Russell Bryant
f575b7e25d
Merged revisions 47492 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47492 | russell | 2006-11-11 10:18:02 -0500 (Sat, 11 Nov 2006) | 2 lines
Tweak the formatting of this new function to better conform to coding guidelines.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-11 15:22:08 +00:00
Matt O'Gorman
b025702287
safe terminal output is sweet.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-11 02:12:27 +00:00
Joshua Colp
0282cc1a4d
A trunk that builds is a productive trunk.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 19:51:15 +00:00
Tilghman Lesher
691363656f
Merged revisions 47436 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47436 | tilghman | 2006-11-10 10:51:55 -0600 (Fri, 10 Nov 2006) | 2 lines
Discussion of these CLI changes resulted in more consistency (Bug 8236)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 17:01:06 +00:00
Russell Bryant
2b2693499d
Add the ability to specify multiple prompts to the Read() dialplan application,
...
similar to Background() and Playback().
(issue #7897 , jsmith, with some modifications)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47408 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 03:59:48 +00:00
Joshua Colp
0efd51e1d2
This should already be called while locked.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47404 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 03:34:13 +00:00
Russell Bryant
7209032ffe
Merged revisions 47377 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47377 | russell | 2006-11-09 11:28:15 -0500 (Thu, 09 Nov 2006) | 2 lines
fix tab completion for "core debug channel" and "core no debug channel"
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 16:30:06 +00:00
Russell Bryant
adf6bb1d9a
Merged revisions 47375 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47375 | russell | 2006-11-09 11:24:02 -0500 (Thu, 09 Nov 2006) | 3 lines
Fix "core show channel". Also, fix tab completion for both "core show channel"
and "core show channels".
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47376 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 16:26:47 +00:00
Russell Bryant
2ea9bb223f
Merged revisions 47372 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47372 | russell | 2006-11-09 11:18:33 -0500 (Thu, 09 Nov 2006) | 3 lines
Fix "core debug channel <whatever>". I guess someone needs to go through and
audit every CLI command that changed number of arguments ...
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 16:20:43 +00:00
Russell Bryant
f3c0a35b6e
Merged revisions 47366 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47366 | russell | 2006-11-09 10:49:39 -0500 (Thu, 09 Nov 2006) | 3 lines
Fix another CLI command, "core show uptime" ...
(issue #8323 , reported by johnlange, fixed by myself)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47367 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 15:51:15 +00:00
Russell Bryant
843a348841
Merged revisions 47352 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47352 | russell | 2006-11-09 01:31:37 -0500 (Thu, 09 Nov 2006) | 3 lines
fix "core show version" to reflect the new number of arguments for this
CLI command (issue #8316 , kshumard)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47353 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 06:35:05 +00:00
Steve Murphy
2e375b388e
This mod via bug 7531
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 23:17:27 +00:00
Kevin P. Fleming
cf1203c496
restore display of G.722 codec
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 21:59:51 +00:00
Joshua Colp
c5780b19c8
Display CID matching information when using dialplan show. (issue #8279 reported by caio1982)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 18:26:52 +00:00
Luigi Rizzo
bdc0180292
fix "core show profile" parsing.
...
Needs to go in 1.4 too, but ENOTIME now
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47300 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 23:14:04 +00:00
Steve Murphy
908f176cf3
A fair number of changes for the sake of bug 7506
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 21:47:49 +00:00
Luigi Rizzo
403135f646
explain why ast_carefulwrite is written the way it is,
...
and also that it doesn't really work as claimed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 08:34:26 +00:00
Joshua Colp
980ce017ec
Add support for manager hooks, so you could fire off manager events over IRC if you were crazy enough. (issue #5161 reported by anthm with mods by moi)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47229 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-06 17:05:04 +00:00
Russell Bryant
18693a45dc
Merged revisions 47196 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47196 | russell | 2006-11-04 13:10:22 -0500 (Sat, 04 Nov 2006) | 2 lines
Fix another bug in "core set debug" ...
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 18:12:31 +00:00
Russell Bryant
9297a1a8f9
Merged revisions 47195 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47195 | russell | 2006-11-04 12:59:39 -0500 (Sat, 04 Nov 2006) | 2 lines
Really fix the "core set debug" and "core set verbose" CLI commands.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47197 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 18:11:18 +00:00
Russell Bryant
7ee7429cf7
Merged revisions 47192 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47192 | russell | 2006-11-04 12:38:24 -0500 (Sat, 04 Nov 2006) | 3 lines
fix the "atleast" option to the "core set verbose" and "core set debug"
CLI commands
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47193 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 17:40:42 +00:00
Luigi Rizzo
ce68e30a07
remove many unnecessary casts
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 01:34:59 +00:00
Luigi Rizzo
84c8e348ba
remove a useless cast
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 01:32:31 +00:00
Luigi Rizzo
0bf4235ff1
add a new cli/manager.conf option "debug" to enable/disable
...
debugging code in the manager.
At the moment the debugging code is very lightweight, if the option
is enabled manager messages also carry a sequence number and
the info where they have been generated e.g.
SequenceNumber: 10
File: chan_sip.c
Line: 11927
Func: handle_response_register
It is not worthwhile having this as a compile time option
right now, because the extra work involved at runtime is
just checking one variable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47132 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-03 18:53:26 +00:00
Luigi Rizzo
55f22da63f
Fix "core show channels" and "core show modules".
...
Not sure it applies like this to 1.4 because of
deprecate versions of the same command(s).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-03 18:13:26 +00:00
Tilghman Lesher
79f75ec09a
Merged revisions 47053 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47053 | tilghman | 2006-11-02 17:49:13 -0600 (Thu, 02 Nov 2006) | 2 lines
More changes making the CLI more consistent with "category verb arguments" (continuation of issue 8236)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47054 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:55:59 +00:00