Russell Bryant
92bd7f19f7
Merge team/russell/ast_verbose_threadstorage
...
- instead of defining a free() wrapper in a bunch of files, define it as
ast_free() in utils.h and remove the copies from all the files.
- centralize and abstract the code used for doing thread storage. The code
lives in threadstorage.h, with one function being implemented in utils.c.
This new API includes generic thread storage as well as special functions
for handling thread local dynamic length string buffers.
- update ast_inet_ntoa() to use the new threadstorage API
- update ast_state2str() to use the new threadstorage API
- update ast_cli() to use the new threadstorage API
- Modify manager_event() to use thread storage. Instead of using a buffer of
4096 characters as the workspace for building the manager event, use a thread
local dynamic string. Now there is no length limitation on the length of the
body of a manager event.
- Significantly simplify the handling of ast_verbose() ...
- Instead of using a static char buffer and a lock to make sure only one
thread can be using ast_verbose() at a time, use a thread local dynamic
string as the workspace for preparing the verbose message. Instead of
locking around the entire function, the only locking done now is when the
message has been built and is being deliviered to the list of registered
verbose message handlers.
- This function was doing a strdup() on every message passed to it and
keeping a queue of the last 200 messages in memory. This has been
completely removed. The only place this was used was that if there were
any messages in the verbose queue when a verbose handler was registered,
all of the messages in the queue would be fed to it. So, I just made sure
that the console verbose handler and the network verbose handler (for
remote asterisk consoles) were registered before any verbose messages.
pbx_gtkconsole and pbx_kdeconsole will now lose a few verbose messages at
startup, but I didn't feel the performance hit of this message queue was
worth saving the initial verbose output for these very rarely used modules.
- I have removed the last three arguments to the verbose handlers, leaving
only the string itself because they aren't needed anymore. For example,
ast_verbose had some logic for telling the verbose handler to add
a newline if the buffer was completely full. Now that the buffer can grow
as needed, this doesn't matter anymore.
- remove unused function, ast_verbose_dmesg() which was to dispatch the
message queue
- Convert the list of verbose handlers to use the linked list macros.
- add missing newline characters to a few ast_verbose() calls
- convert the list of log channels to use the linked list macros in logger.c
- fix close_logger() to close all of the files it opened for logging
- update ast_log() to use a thread local dynamic string for its workspace
for preparing log messages instead of a buffer of size BUFSIZ (8kB on my
system) allocated on the stack. The dynamic string in this case is limited
to only growing to a maximum size of BUFSIZ.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39272 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-08 06:32:04 +00:00
Russell Bryant
b04f059b4a
As discussed and decided on the asterisk-dev mailing list ...
...
- Fix some breakage I introduced a while ago that made the timestamps option
not functional for CLI verbose output.
- Remove the use of the timestamps option for log output, since it was not
functional.
- clarify text referring to the timestamps option so that it is clear that it
only applies to CLI verbose output
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-28 19:17:56 +00:00
Russell Bryant
8dad7e730e
slightly simplify a loop and replace an open coded version of ast_skip_blanks
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@38068 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-21 23:58:14 +00:00
Kevin P. Fleming
8d88bf549d
there is no reason to define our own 'maximum path length' when the POSIX headers already define one for us
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 20:40:10 +00:00
Kevin P. Fleming
472c1ca282
simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Joshua Colp
9b18892314
Add ability to disable log / verbose output to remote consoles (issue #6524 reported by mavetju)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30603 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-26 19:48:17 +00:00
Joshua Colp
519ee25110
Merged revisions 30033 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r30033 | file | 2006-05-24 16:14:01 -0300 (Wed, 24 May 2006) | 2 lines
Fix deadlock caused by a race condition in the logger when reloading (issue #7195 reported and fixed by softins)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30034 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-24 19:16:07 +00:00
Russell Bryant
04ecb29d03
remove almost all of the checks of the result from ast_strdupa() or alloca().
...
As it turns out, all of these checks were useless, because alloca will never
return NULL.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@26451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-10 13:22:15 +00:00
BJ Weschke
569ecaf5a2
use pid_t instead of long for pid variables. #7099 (casper)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@25488 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 12:32:44 +00:00
Russell Bryant
442785f3e2
conversions to allocation wrappers and coding guidelines fixes (issue #6592 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@11232 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-27 01:43:42 +00:00
Tilghman Lesher
83f3233f5f
Merged revisions 11165 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r11165 | tilghman | 2006-02-26 10:26:39 -0600 (Sun, 26 Feb 2006) | 2 lines
Bug 5950 - reenable queue log rotation; also, eliminate redundant code
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@11166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-26 16:40:39 +00:00
Kevin P. Fleming
a3580ffdeb
use a symbolic constant instead of a magic number (tholo!)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-22 21:53:56 +00:00
Tilghman Lesher
9a55cf9bc1
Typo: should have been changed to a constant
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-22 21:20:28 +00:00
Matt O'Gorman
3d394586da
changed LOG_WARNING to LOG_DEBUG for backtrace
...
messages (issue #6497 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@10195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 17:37:57 +00:00
Matt O'Gorman
5f0de64f78
Merged revisions 9232 via svnmerge from
...
https://svn.digium.com/svn/asterisk/branches/1.2
........
r9232 | mogorman | 2006-02-08 16:12:34 -0600 (Wed, 08 Feb 2006) | 4 lines
Make logger report error,warning,notice if logger.conf
not found, also updated chan_oss to give correct
error message if its config file is not found.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@9239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-08 23:14:17 +00:00
Olle Johansson
ad5eaa9aca
More doxygen updates
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-20 00:18:42 +00:00
Matt O'Gorman
f2b231daf6
Merged revisions 7963 via svnmerge from
...
https://svn.digium.com/svn/asterisk/branches/1.2
........
r7963 | mogorman | 2006-01-10 22:38:07 -0600 (Tue, 10 Jan 2006) | 2 lines
Minor typo refrenced in 6191
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-17 16:58:09 +00:00
Russell Bryant
a725468381
update doxygen docs to specify authors
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-30 21:18:06 +00:00
Tilghman Lesher
cdab512c9f
Bug 5183 - Inline stack backtraces
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-27 06:24:28 +00:00
Russell Bryant
ec05153ac4
convert most of the option_*'s to a single ast_flags structure. Also, fix some
...
formatting, remove some unnecessary casts, and other little code cleanups.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7331 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-04 20:40:46 +00:00
Kevin P. Fleming
2c65582b66
remove extraneous svn:executable properties
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Russell Bryant
3453e3efa5
Doxygen documentation update from oej (issue #5505 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Kevin P. Fleming
130bf3b9e0
use thread ID instead of process ID in logger messages (issue #5349 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-05 00:21:56 +00:00
Kevin P. Fleming
852bf07caa
ensure that if the verbose buffer is full, we send it out even if it's not complete (issue #5263 , patch modified to actually compile)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-26 15:43:16 +00:00
Kevin P. Fleming
1a0ceef2db
correct accidental logic reversal
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 14:27:14 +00:00
Kevin P. Fleming
f94a1d47d6
clean up ast_verbose(), don't hold the lock any longer than needed
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 23:56:50 +00:00
Kevin P. Fleming
5da915dcfd
update MANY more files with proper copyright/license info (thanks Ian!)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 20:46:50 +00:00
Kevin P. Fleming
9614adc056
make DEBUG_THREADS have more visible logging
...
make DEBUG_THREADS able to catch locks being unlocked by threads that did not own them
add proper wrappers for pthread_cond_wait() and pthread_cond_timedwait() for DEBUG_THREADS mode
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-31 02:43:44 +00:00
Kevin P. Fleming
dffade452c
add a LOG_DTMF logging channel and send all bridged DTMF events out that channel (issue #4835 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6358 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-22 21:19:59 +00:00
Mark Spencer
b353b1d6fb
Allow Asterisk to start even when eventlog is turned off (bug #4938 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6337 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-15 19:35:25 +00:00
Russell Bryant
edbc500b77
more ast_copy_string conversions
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6073 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-10 22:56:21 +00:00
Kevin P. Fleming
750e8abd46
ensure that filesize-triggered reloads don't recurse (bug #4621 , with mods)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6031 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-05 20:31:34 +00:00
Kevin P. Fleming
2b8338cb52
more file version tags
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 22:12:19 +00:00
Kevin P. Fleming
0e6762dd5f
remove experimental module version tags
...
add per-file revision tags and 'show version files' CLI command
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 20:27:51 +00:00
Kevin P. Fleming
4f299de252
major Makefile and build process improvements, including removal of all hardcoded paths (modules must now use run-time paths as they should) (bug #4116 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5855 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 03:04:58 +00:00
Kevin P. Fleming
dd0c01fc2f
clarify comments even more
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5749 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-20 13:58:39 +00:00
Kevin P. Fleming
e65df4cc67
add a little comment to keep someone else from having the same misunderstanding I had :-)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-20 03:52:27 +00:00
Mark Spencer
ebd2196ab7
Revert improper patch from bug #4294
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5744 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-19 20:33:55 +00:00
Kevin P. Fleming
3e7675e728
properly check for debug and verbose messages to suppress (bug #4294 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-19 02:54:23 +00:00
Mark Spencer
251e6bc2ed
Fix logger check (bug #4260 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-14 23:28:47 +00:00
Mark Spencer
00bcbaaa05
Fix gethostname calls (bug #4198 , with mods)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-08 16:44:25 +00:00
Kevin P. Fleming
199add9567
phase 1 of header include cleanup (bug #4067 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5498 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-22 13:11:34 +00:00
Kevin P. Fleming
1f9ab2380a
use double-quotes instead of angle-brackets for non-system include files (bug #4058 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-21 06:02:45 +00:00
Kevin P. Fleming
6ae8903fd8
fix obvious coding error from yesterday's fix
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-03 21:25:45 +00:00
Kevin P. Fleming
71f2c0c6ec
don't unnecessarily open-code strchr()
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-02 23:20:11 +00:00
Kevin P. Fleming
4f0e5637a9
strip color code sequences from verbose messages being sent to files/syslog (bug #3929 , with mods)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-01 23:49:57 +00:00
Kevin P. Fleming
2059316463
Put syslog facility/level name into filename field, so it will show in 'logger show channels' (bug #3916 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-01 16:09:21 +00:00
Mark Spencer
642059b2e4
Make logger respond better to lack of disk space and add "logger show channels" CLI (bug #3909 with minor mods)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-03-31 19:08:51 +00:00
Mark Spencer
bf940e8928
No need for sizeof (bug #3887 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-03-28 20:57:59 +00:00
Mark Spencer
dbd42a645f
Apply queuelog patch and perform final test of "test patches" system
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-03-11 08:49:01 +00:00