Commit Graph

7 Commits

Author SHA1 Message Date
Sean Bright
cb8e3aa590 contrib: rc.archlinux.asterisk uses invalid redirect.
`rc.archlinux.asterisk`, which explicitly requests bash in its
shebang, uses the following command syntax:

  ${DAEMON} -rx "core stop now" > /dev/null 2&>1

The intent of which is to execute:

  ${DAEMON} -rx "core stop now"

While sending both stdout and stderr to `/dev/null`. Unfortunately,
because the `&` is in the wrong place, bash is interpreting the `2` as
just an additional argument to the `$DAEMON` command and not as a file
descriptor and proceeds to use the bashism `&>` to send stderr and
stdout to a file named `1`.

So we clean it up and just use bash's shortcut syntax.

Issue raised and a fix suggested (but not used) by peutch on GitHub¹.

ASTERISK-30449 #close

1. https://github.com/asterisk/asterisk/pull/31

Change-Id: Ie279bf4efb4d95cbf507313483d316e977303d19
2023-03-06 12:13:24 -06:00
Matthew Jordan
a3e7a77a82 Update init.d scripts to handle stderr; readd splash screen for remote consoles
When r376428 was commited to re-order start up sequences to be more tolerant of
forking with thread primitives, a few items were changed that caused changes
in behavior on some distros. This includes:
 * Not displaying the splash screen on a remote console.
 * Displaying an error message on stderr when a remote console cannot connect
   to a running instance of Asterisk.

In the first case, the splash screen was re-added (thanks to Michael L. Young).
In the second case, the various init.d scripts were modified to pipe stderr
to /dev/null, as the error message is useful - if you execute a remote
console or a remote console command execution and it fail, it should tell
you. Note that the error message was always present, it just failed to be
printed prior to r376428.

Much thanks to the folks who quickly reported this problem, provided solutions,
and promptly tested the various init.d scripts on a variety of distros.

(closes issue ASTERISK-20945)
Reported by: Warren Selby
Tested by: Michael L. Young, Jamuel Starkey, kaldemar, Danny Nicholas, mjordan
patches:
  asterisk-20945-remote-intro-msg.diff uploaded by elguero (license 5026)
  ASTERISK-20945-1.8-mjordan.diff uploaded by mjordan (license 6283)
........

Merged revisions 379760 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 379777 from http://svn.asterisk.org/svn/asterisk/branches/10
........

Merged revisions 379790 from http://svn.asterisk.org/svn/asterisk/branches/11


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@379791 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2013-01-21 20:41:12 +00:00
Gregory Nietsky
6a0fa4e321 Merged revisions 337902 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/10

................
  r337902 | irroot | 2011-09-23 21:18:14 +0200 (Fri, 23 Sep 2011) | 10 lines
  
  Merged revisions 337898 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.8
  
  ........
    r337898 | irroot | 2011-09-23 21:14:30 +0200 (Fri, 23 Sep 2011) | 4 lines
    
    
    Spelling fix
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@337910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-09-23 19:20:41 +00:00
Tilghman Lesher
dd0ab33cb2 Add LSB headers to init scripts.
(closes issue #14864)
 Reported by: lathama
 Patches: 
       lsb-init-info-debian.diff uploaded by pkempgen (license 169)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-11 23:53:32 +00:00
Michiel van Baak
5b497da128 set ASTVARRUNDIR=$(localstatedir)/run/asterisk as default path
When running asterisk as non-root and without this patch the pidfile wants
to go into /var/run/asterisk.pid. This directory is not writable for
the non-root user and changing permissions is not an option.
Putting it in /var/run/asterisk/asterisk.pid makes it possible
to set permissions on the /var/run/asterisk dir so everything
works as it should be.

Patched committed is based on pabelanger's patch.

(closes issue #13153)
Reported by: pabelanger
Patches:
      2009012900_bug13153-nonrootscripts.diff.txt uploaded by mvanbaak (license 7)

Review: http://reviewboard.digium.com/r/139/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@177852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-02-21 13:13:35 +00:00
Jason Parker
7478e5ecd0 Make this executable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18 21:03:12 +00:00
Jason Parker
493e903892 Add init script for ArchLinux
(closes issue #13667)
Reported by: sherif
Patches:
      archlinux_rc_makefile.patch uploaded by sherif (license 591)
      archlinux_rc_makefile-2.patch uploaded by mvanbaak (license 7)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157460 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-18 21:01:46 +00:00