mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-03 11:25:35 +00:00
_ys pointed out in #asterisk-bugs that he was experiencing
a memory leak when running the astobj2 test CLI command. After searching, it appears the leak was in the command handler itself. Each object was allocated (recount = 1) and then linked into a container (refounct = 2). Then at the end of the function, the container was unreffed, causing all the objects to have their refcount decremented by one, leaving the refcount for all objects allocated in that function at 1. I've now added an extra unref to the mix so that the refcount equals zero when the container is unreffed. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -930,6 +930,12 @@ static char *handle_astobj2_test(struct ast_cli_entry *e, int cmd, struct ast_cl
|
||||
ast_cli(a->fd, "object %d allocated as %p\n", i, obj);
|
||||
sprintf(obj, "-- this is obj %d --", i);
|
||||
ao2_link(c1, obj);
|
||||
/* At this point, the refcount on obj is 2 due to the allocation
|
||||
* and linking. We can go ahead and reduce the refcount by 1
|
||||
* right here so that when the container is unreffed later, the
|
||||
* objects will be freed
|
||||
*/
|
||||
ao2_t_ref(obj, -1, test);
|
||||
}
|
||||
ast_cli(a->fd, "testing callbacks\n");
|
||||
ao2_t_callback(c1, 0, print_cb, &a->fd,"test callback");
|
||||
|
Reference in New Issue
Block a user