diff --git a/main/app.c b/main/app.c index 526927140a..0054c4cdeb 100644 --- a/main/app.c +++ b/main/app.c @@ -30,10 +30,15 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") #ifdef HAVE_SYS_STAT_H #include #endif -#include -#include /* added this to allow to compile, sorry! */ -#include +#include /* for regcomp(3) */ +#include /* for flock(2) */ +#include /* for pthread_sigmask(3) */ #include /* for closefrom(3) */ +#include +#include /* for waitpid(2) */ +#ifndef HAVE_CLOSEFROM +#include /* for opendir(3) */ +#endif #ifdef HAVE_CAP #include #endif /* HAVE_CAP */ @@ -52,6 +57,41 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") AST_THREADSTORAGE_PUBLIC(ast_str_thread_global_buf); +static pthread_t shaun_of_the_dead_thread = AST_PTHREADT_NULL; + +struct zombie { + pid_t pid; + AST_LIST_ENTRY(zombie) list; +}; + +static AST_LIST_HEAD_STATIC(zombies, zombie); + +static void *shaun_of_the_dead(void *data) +{ + struct zombie *cur; + int status; + for (;;) { + if (!AST_LIST_EMPTY(&zombies)) { + /* Don't allow cancellation while we have a lock. */ + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL); + AST_LIST_LOCK(&zombies); + AST_LIST_TRAVERSE_SAFE_BEGIN(&zombies, cur, list) { + if (waitpid(cur->pid, &status, WNOHANG) != 0) { + AST_LIST_REMOVE_CURRENT(list); + ast_free(cur); + } + } + AST_LIST_TRAVERSE_SAFE_END + AST_LIST_UNLOCK(&zombies); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL); + } + pthread_testcancel(); + /* Wait for 60 seconds, without engaging in a busy loop. */ + ast_poll(NULL, 0, AST_LIST_FIRST(&zombies) ? 5000 : 60000); + } + return NULL; +} + #define AST_MAX_FORMATS 10 @@ -2061,6 +2101,21 @@ int ast_safe_fork(int stop_reaper) if (pid != 0) { /* Fork failed or parent */ pthread_sigmask(SIG_SETMASK, &old_set, NULL); + if (!stop_reaper && pid > 0) { + struct zombie *cur = ast_calloc(1, sizeof(*cur)); + if (cur) { + cur->pid = pid; + AST_LIST_LOCK(&zombies); + AST_LIST_INSERT_TAIL(&zombies, cur, list); + AST_LIST_UNLOCK(&zombies); + if (shaun_of_the_dead_thread == AST_PTHREADT_NULL) { + if (ast_pthread_create_background(&shaun_of_the_dead_thread, NULL, shaun_of_the_dead, NULL)) { + ast_log(LOG_ERROR, "Shaun of the Dead wants to kill zombies, but can't?!!\n"); + shaun_of_the_dead_thread = AST_PTHREADT_NULL; + } + } + } + } return pid; } else { /* Child */