kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-02 19:16:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_stir_shaken: Test for missing semicolon in Identity header.

Browse Source 
ast_stir_shaken_vs_verify() now makes sure there's a semicolon in
the Identity header to prevent a possible segfault.

Resolves: #GHSA-mrq5-74j5-f5cr
This commit is contained in:
George Joseph
2025-07-31 08:36:27 -06:00
parent fefb2aa2a7
commit f538370365
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
res/res_stir_shaken/verification.c
View File

@@ -908,6 +908,11 @@ enum ast_stir_shaken_vs_response_code
} }
p = strchr(ctx->identity_hdr, ';'); p = strchr(ctx->identity_hdr, ';');
if (ast_strlen_zero(p)) {
SCOPE_EXIT_LOG_RTN_VALUE(AST_STIR_SHAKEN_VS_INVALID_HEADER,
LOG_ERROR, "%s: Malformed identity header\n", ctx->tag);
}
len = p - ctx->identity_hdr + 1; len = p - ctx->identity_hdr + 1;
jwt_encoded = ast_malloc(len); jwt_encoded = ast_malloc(len);
if (!jwt_encoded) { if (!jwt_encoded) {
@@ -918,7 +923,11 @@ enum ast_stir_shaken_vs_response_code
memcpy(jwt_encoded, ctx->identity_hdr, len); memcpy(jwt_encoded, ctx->identity_hdr, len);
jwt_encoded[len - 1] = '\0'; jwt_encoded[len - 1] = '\0';
jwt_decode(&jwt, jwt_encoded, NULL, 0); rc = jwt_decode(&jwt, jwt_encoded, NULL, 0);
if (rc != 0) {
SCOPE_EXIT_RTN_VALUE(AST_STIR_SHAKEN_VS_INVALID_HEADER, "%s: %s\n",
ctx->tag, vs_response_code_to_str(AST_STIR_SHAKEN_VS_INVALID_HEADER));
}
ppt_header = jwt_get_header(jwt, "ppt"); ppt_header = jwt_get_header(jwt, "ppt");
if (!ppt_header || strcmp(ppt_header, STIR_SHAKEN_PPT)) { if (!ppt_header || strcmp(ppt_header, STIR_SHAKEN_PPT)) {