kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-05 12:16:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Go ahead and make this write unconditional. Making it conditional is more work

Browse Source 
in both the append and non-append modes.  Also, always truncating the partial
write makes the behavior of the function more consistent, where in any type of
write, no partial result is left in the buffer.

Thanks for the feedback, luigi


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48109 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant
2006-11-29 17:37:31 +00:00
parent d44b349211
commit eaf98f31e8
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
main/utils.c
View File

@@ -997,16 +997,8 @@ int ast_dynamic_str_thread_build_va(struct ast_dynamic_str **buf, size_t max_len
return AST_DYNSTR_BUILD_FAILED;
(*buf)->len = need;
/* Truncate the previous attempt. This is only needed for the
* append operation because if the write is from the beginning,
* it will get automatically overwritten when this function
* gets called again. When appending, if this was not done,
* this function would be called over and over again, because
* each attempt would be appending more and more partial
* strings, never having enough space to finish.
*/
if (append)
(*buf)->str[offset] = '\0';
/* Truncate the partial write. */
(*buf)->str[offset] = '\0';
if (ts)
pthread_setspecific(ts->key, *buf);