kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-02 20:08:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable warnings on atypical conditions for the FILTER function (suggested by mmichelson on the -dev list).

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@246022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Tilghman Lesher
2010-02-10 15:36:57 +00:00
parent 5b86e43b30
commit eaea15aa02
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
funcs/func_strings.c
View File

@@ -603,6 +603,10 @@ static int filter(struct ast_channel *chan, const char *cmd, char *parse, char *
return -1;
}
if (args.allowed[0] == '"' && !ast_opt_dont_warn) {
ast_log(LOG_WARNING, "FILTER allowed characters includes the quote (\") character. This may not be what you want.\n");
}
/* Expand ranges */
for (; *(args.allowed) && allowedlen < sizeof(allowed); ) {
char c1 = 0, c2 = 0;
@@ -617,6 +621,10 @@ static int filter(struct ast_channel *chan, const char *cmd, char *parse, char *
c2 = -1;
args.allowed += consumed + 1;
if ((c2 < c1 || c2 == -1) && !ast_opt_dont_warn) {
ast_log(LOG_WARNING, "Range wrapping in FILTER(%s,%s). This may not be what you want.\n", parse, args.string);
}
/*!\note
* Looks a little strange, until you realize that we can overflow
* the size of a char.