kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-23 21:19:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve SDP offer/answer RFC compliance

Browse Source 
Asterisk should not accept SDP offers that contain unknown RTP profiles (for
audio/video streams) or unknown top-level media types. When it does, it answers
with an SDP that does not match the offer properly, and this will nearly
always result in a broken call. This patch causes such offers to be rejected.

Review: https://reviewboard.asterisk.org/r/1811/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@368269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Kevin P. Fleming
2012-06-01 20:42:10 +00:00
parent 66e5c30716
commit dd02d976f5
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
channels/chan_sip.c
View File

@@ -9225,7 +9225,8 @@ static int process_sdp(struct sip_pvt *p, struct sip_request *req, int t38action
secure_audio = 1;
} else if (strcmp(protocol, "AVP")) {
ast_log(LOG_WARNING, "Unknown RTP profile in audio offer: %s\n", m);
continue;
res = -1;
goto process_sdp_cleanup;
}
if (p->offered_media[SDP_AUDIO].order_offered) {
@@ -9277,7 +9278,8 @@ static int process_sdp(struct sip_pvt *p, struct sip_request *req, int t38action
secure_video = 1;
} else if (strcmp(protocol, "AVP")) {
ast_log(LOG_WARNING, "Unknown RTP profile in video offer: %s\n", m);
continue;
res = -1;
goto process_sdp_cleanup;
}
if (p->offered_media[SDP_VIDEO].order_offered) {
@@ -9398,7 +9400,8 @@ static int process_sdp(struct sip_pvt *p, struct sip_request *req, int t38action
}
} else {
ast_log(LOG_WARNING, "Unsupported top-level media type in offer: %s\n", m);
continue;
res = -1;
goto process_sdp_cleanup;
}
/* Media stream specific parameters */