kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-03 11:25:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_resolver_unbound: Test for NULL ub_result in unbound_resolver_callback

Browse Source 
The ub_result pointer passed to unbound_resolver_callback by
libunbound can be NULL if the query was for something malformed
like `.1` or `[.1]`.  If it is, we now set a 'ns_r_formerr' result
and return instead of crashing with a SEGV.  This causes pjproject
to simply cancel the transaction with a "No answer record in the DNS
response" error.  The existing "off nominal" unit test was also
updated to check this condition.

Although not necessary for this fix, we also made
ast_dns_resolver_completed() tolerant of a NULL result.

Resolves: GHSA-v428-g3cw-7hv9
(cherry picked from commit d2d0c507ff)
This commit is contained in:
George Joseph
2024-08-12 11:58:12 -06:00
committed by Asterisk Development Team
parent 78f8b00267
commit b506faaa2d
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
main/dns_core.c
View File

@@ -598,7 +598,9 @@ static void sort_result(int rr_type, struct ast_dns_result *result)
void ast_dns_resolver_completed(struct ast_dns_query *query)
{
sort_result(ast_dns_query_get_rr_type(query), query->result);
if (query->result) {
sort_result(ast_dns_query_get_rr_type(query), query->result);
}
query->callback(query);
}