Go through and fix a bunch of places where character strings were being interpreted as format strings. Most of these changes are solely to make compiling with -Wsecurity and -Wformat=2 happy, and were not

actual problems, per se.  I also added format attributes to any printf wrapper functions I found that didn't have them.  -Wsecurity and -Wmissing-format-attribute added to --enable-dev-mode.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@109447 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Terry Wilson
2008-03-18 15:43:34 +00:00
parent 760fc3403c
commit b02bc230af
31 changed files with 137 additions and 127 deletions

View File

@@ -141,7 +141,8 @@ static void del_chan(char *name)
AST_LIST_TRAVERSE_SAFE_END;
}
static void fdprintf(int fd, char *fmt, ...)
static void __attribute__((format (printf, 2, 3))) fdprintf(int fd, char *fmt, ...)
{
char stuff[4096];
va_list ap;
@@ -406,7 +407,8 @@ static struct message *wait_for_response(int timeout)
return NULL;
}
static int manager_action(char *action, char *fmt, ...)
static int __attribute__((format (printf, 2, 3))) manager_action(char *action, char *fmt, ...)
{
struct ast_mansession *s;
char tmp[4096];
@@ -465,7 +467,7 @@ static int hide_doing(void)
static void try_status(void)
{
struct message *m;
manager_action("Status", "");
manager_action("Status", "%s", "");
m = wait_for_response(10000);
if (!m) {
show_message("Status Failed", "Timeout waiting for response");