kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-03 03:20:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

more strncpy -> ast_copy_string conversions, fixing some buglets along the way

Browse Source 
add recommendation to CODING-GUIDELINES to use ast_copy_string instead of strncpy in new code


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Kevin P. Fleming
2005-05-15 23:26:45 +00:00
parent eaececc920
commit 9bf21dbf58
4 changed files with 237 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
doc/CODING-GUIDELINES
View File

@@ -164,6 +164,11 @@ if (name && (len = strlen(name) + strlen(prefix) + strlen(postfix) + 3) && (newn
Use const on pointers which your function will not be modifying, as this
allows the compiler to make certain optimizations.
Don't use strncpy for copying whole strings; it does not guarantee that the
output buffer will be null-terminated. Use ast_copy_string instead, which
is also slightly more efficient (and allows passing the actual buffer
size, which makes the code clearer).
== CLI Commands ==
New CLI commands should be named using the module's name, followed by a verb
@@ -190,5 +195,5 @@ Applications are registered and invoked using the
ast_register_application function; see the apps/app_skel.c file for an
example.
Functions are registered using 'struct ast_custom_function_obj'
Functions are registered using 'struct ast_custom_function'
structures and the ast_custom_function_register function.