mirror of
https://github.com/asterisk/asterisk.git
synced 2025-11-02 20:08:17 +00:00
Clean up and ensure proper usage of alloca()
This replaces all calls to alloca() with ast_alloca() which calls gcc's __builtin_alloca() to avoid BSD semantics and removes all NULL checks on memory allocated via ast_alloca() and ast_strdupa(). (closes issue ASTERISK-20125) Review: https://reviewboard.asterisk.org/r/2032/ Patch-by: Walter Doekes (wdoekes) ........ Merged revisions 370642 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 370643 from http://svn.asterisk.org/svn/asterisk/branches/10 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -1041,7 +1041,7 @@ int ast_pthread_create_stack(pthread_t *thread, pthread_attr_t *attr, void *(*st
|
||||
#endif
|
||||
|
||||
if (!attr) {
|
||||
attr = alloca(sizeof(*attr));
|
||||
attr = ast_alloca(sizeof(*attr));
|
||||
pthread_attr_init(attr);
|
||||
}
|
||||
|
||||
@@ -1089,7 +1089,7 @@ int ast_pthread_create_detached_stack(pthread_t *thread, pthread_attr_t *attr, v
|
||||
int res;
|
||||
|
||||
if (!attr) {
|
||||
attr = alloca(sizeof(*attr));
|
||||
attr = ast_alloca(sizeof(*attr));
|
||||
pthread_attr_init(attr);
|
||||
attr_destroy = 1;
|
||||
}
|
||||
@@ -1982,7 +1982,7 @@ int ast_mkdir(const char *path, int mode)
|
||||
int len = strlen(path), count = 0, x, piececount = 0;
|
||||
char *tmp = ast_strdupa(path);
|
||||
char **pieces;
|
||||
char *fullpath = alloca(len + 1);
|
||||
char *fullpath = ast_alloca(len + 1);
|
||||
int res = 0;
|
||||
|
||||
for (ptr = tmp; *ptr; ptr++) {
|
||||
@@ -1991,7 +1991,7 @@ int ast_mkdir(const char *path, int mode)
|
||||
}
|
||||
|
||||
/* Count the components to the directory path */
|
||||
pieces = alloca(count * sizeof(*pieces));
|
||||
pieces = ast_alloca(count * sizeof(*pieces));
|
||||
for (ptr = tmp; *ptr; ptr++) {
|
||||
if (*ptr == '/') {
|
||||
*ptr = '\0';
|
||||
|
||||
Reference in New Issue
Block a user