From 8e4a09f71162ebc1e4bb2159dfc638aa2328047c Mon Sep 17 00:00:00 2001 From: Asterisk Development Team Date: Thu, 17 Oct 2024 15:52:14 +0000 Subject: [PATCH] Update for 22.0.0 --- .version | 2 +- CHANGES.md | 2 +- ChangeLogs/ChangeLog-22.0.0-rc2.md | 105 ------------------ ...eLog-22.0.0-rc1.md => ChangeLog-22.0.0.md} | 79 +++++++++++-- 4 files changed, 73 insertions(+), 115 deletions(-) delete mode 100644 ChangeLogs/ChangeLog-22.0.0-rc2.md rename ChangeLogs/{ChangeLog-22.0.0-rc1.md => ChangeLog-22.0.0.md} (77%) diff --git a/.version b/.version index 9b05560b2c..1d975bef24 100644 --- a/.version +++ b/.version @@ -1 +1 @@ -22.0.0-rc2 +22.0.0 diff --git a/CHANGES.md b/CHANGES.md index 6146ebd26e..0e78048661 120000 --- a/CHANGES.md +++ b/CHANGES.md @@ -1 +1 @@ -ChangeLogs/ChangeLog-22.0.0-rc2.md \ No newline at end of file +ChangeLogs/ChangeLog-22.0.0.md \ No newline at end of file diff --git a/ChangeLogs/ChangeLog-22.0.0-rc2.md b/ChangeLogs/ChangeLog-22.0.0-rc2.md deleted file mode 100644 index 31fcffe9c5..0000000000 --- a/ChangeLogs/ChangeLog-22.0.0-rc2.md +++ /dev/null @@ -1,105 +0,0 @@ - -## Change Log for Release asterisk-22.0.0-rc2 - -### Links: - - - [Full ChangeLog](https://downloads.asterisk.org/pub/telephony/asterisk/releases/ChangeLog-22.0.0-rc2.md) - - [GitHub Diff](https://github.com/asterisk/asterisk/compare/22.0.0-rc1...22.0.0-rc2) - - [Tarball](https://downloads.asterisk.org/pub/telephony/asterisk/asterisk-22.0.0-rc2.tar.gz) - - [Downloads](https://downloads.asterisk.org/pub/telephony/asterisk) - -### Summary: - -- Commits: 3 -- Commit Authors: 1 -- Issues Resolved: 3 -- Security Advisories Resolved: 0 - -### User Notes: - - -### Upgrade Notes: - - -### Commit Authors: - -- George Joseph: (3) - -## Issue and Commit Detail: - -### Closed Issues: - - - 884: [bug]: A ':' at the top of in stir_shaken.conf make Asterisk producing a core file when starting - - 889: [bug]: res_stir_shaken/verification.c has a stale include for jansson.h that can cause compilation to fail - - 904: [bug]: stir_shaken: attest_level isn't being propagated correctly from attestation to profile to tn - -### Commits By Author: - -- #### George Joseph (3): - - res_stir_shaken.c: Fix crash when stir_shaken.conf is invalid - - res_stir_shaken: Remove stale include for jansson.h in verification.c - - stir_shaken: Fix propagation of attest_level and a few other values - - -### Commit List: - -- stir_shaken: Fix propagation of attest_level and a few other values -- res_stir_shaken: Remove stale include for jansson.h in verification.c -- res_stir_shaken.c: Fix crash when stir_shaken.conf is invalid - -### Commit Details: - -#### stir_shaken: Fix propagation of attest_level and a few other values - Author: George Joseph - Date: 2024-09-24 - - attest_level, send_mky and check_tn_cert_public_url weren't - propagating correctly from the attestation object to the profile - and tn. - - * In the case of attest_level, the enum needed to be changed - so the "0" value (the default) was "NOT_SET" instead of "A". This - now allows the merging of the attestation object, profile and tn - to detect when a value isn't set and use the higher level value. - - * For send_mky and check_tn_cert_public_url, the tn default was - forced to "NO" which always overrode the profile and attestation - objects. Their defaults are now "NOT_SET" so the propagation - happens correctly. - - * Just to remove some redundant code in tn_config.c, a bunch of calls to - generate_sorcery_enum_from_str() and generate_sorcery_enum_to_str() were - replaced with a single call to generate_acfg_common_sorcery_handlers(). - - Resolves: #904 - -#### res_stir_shaken: Remove stale include for jansson.h in verification.c - Author: George Joseph - Date: 2024-09-17 - - verification.c had an include for jansson.h left over from previous - versions of the module. Since res_stir_shaken no longer has a - dependency on jansson, the bundled version wasn't added to GCC's - include path so if you didn't also have a jansson development package - installed, the compile would fail. Removing the stale include - was the only thing needed. - - Resolves: #889 - -#### res_stir_shaken.c: Fix crash when stir_shaken.conf is invalid - Author: George Joseph - Date: 2024-09-13 - - * If the call to ast_config_load() returns CONFIG_STATUS_FILEINVALID, - check_for_old_config() now returns LOAD_DECLINE instead of continuing - on with a bad pointer. - - * If CONFIG_STATUS_FILEMISSING is returned, check_for_old_config() - assumes the config is being loaded from realtime and now returns - LOAD_SUCCESS. If it's actually not being loaded from realtime, - sorcery will catch that later on. - - * Also refactored the error handling in load_module() a bit. - - Resolves: #884 - diff --git a/ChangeLogs/ChangeLog-22.0.0-rc1.md b/ChangeLogs/ChangeLog-22.0.0.md similarity index 77% rename from ChangeLogs/ChangeLog-22.0.0-rc1.md rename to ChangeLogs/ChangeLog-22.0.0.md index 13296a1405..2414d77138 100644 --- a/ChangeLogs/ChangeLog-22.0.0-rc1.md +++ b/ChangeLogs/ChangeLog-22.0.0.md @@ -1,18 +1,18 @@ -## Change Log for Release asterisk-22.0.0-rc1 +## Change Log for Release asterisk-22.0.0 ### Links: - - [Full ChangeLog](https://downloads.asterisk.org/pub/telephony/asterisk/releases/ChangeLog-22.0.0-rc1.md) - - [GitHub Diff](https://github.com/asterisk/asterisk/compare/22.0.0-pre1...22.0.0-rc1) - - [Tarball](https://downloads.asterisk.org/pub/telephony/asterisk/asterisk-22.0.0-rc1.tar.gz) + - [Full ChangeLog](https://downloads.asterisk.org/pub/telephony/asterisk/releases/ChangeLog-22.0.0.md) + - [GitHub Diff](https://github.com/asterisk/asterisk/compare/22.0.0-pre1...22.0.0) + - [Tarball](https://downloads.asterisk.org/pub/telephony/asterisk/asterisk-22.0.0.tar.gz) - [Downloads](https://downloads.asterisk.org/pub/telephony/asterisk) ### Summary: -- Commits: 19 +- Commits: 22 - Commit Authors: 8 -- Issues Resolved: 10 +- Issues Resolved: 13 - Security Advisories Resolved: 1 - [GHSA-v428-g3cw-7hv9](https://github.com/asterisk/asterisk/security/advisories/GHSA-v428-g3cw-7hv9): A malformed Contact or Record-Route URI in an incoming SIP request can cause Asterisk to crash when res_resolver_unbound is used @@ -34,7 +34,7 @@ ### Commit Authors: - Alexei Gradinari: (2) -- George Joseph: (7) +- George Joseph: (10) - Gibbz00: (1) - Joshua C. Colp: (2) - Mike Bradeen: (2) @@ -57,6 +57,9 @@ - 861: [bug]: ChanSpy unable to read audiohook read direction frame when no packet lost on both side of the call - 876: [bug]: ChanSpy unable to write whisper_audiohook when set flag OPTION_READONLY - 879: [bug]: res_stir_shaken/verification.c: Getting verification errors when global_disable=yes + - 884: [bug]: A ':' at the top of in stir_shaken.conf make Asterisk producing a core file when starting + - 889: [bug]: res_stir_shaken/verification.c has a stale include for jansson.h that can cause compilation to fail + - 904: [bug]: stir_shaken: attest_level isn't being propagated correctly from attestation to profile to tn ### Commits By Author: @@ -64,12 +67,15 @@ - res_pjsip_sdp_rtp fix leaking astobj2 ast_format - autoservice: Do not sleep if autoservice_stop is called within autoservice thr.. -- #### George Joseph (5): +- #### George Joseph (8): - stir_shaken.conf.sample: Fix bad references to private_key_path - security_agreements.c: Refactor the to_str functions and fix a few other bugs - app_voicemail: Use ast_asprintf to create mailbox SQL query - res_resolver_unbound: Test for NULL ub_result in unbound_resolver_callback - res_stir_shaken: Check for disabled before param validation + - res_stir_shaken.c: Fix crash when stir_shaken.conf is invalid + - res_stir_shaken: Remove stale include for jansson.h in verification.c + - stir_shaken: Fix propagation of attest_level and a few other values - #### Mike Bradeen (1): - res_pjsip_sdp_rtp: Use negotiated DTMF Payload types on bitrate mismatch @@ -92,6 +98,9 @@ - Revert "app_record: Add RECORD_TIME output variable." - feat: ARI "ChannelToneDetected" event - Update version for Asterisk 22 +- stir_shaken: Fix propagation of attest_level and a few other values +- res_stir_shaken: Remove stale include for jansson.h in verification.c +- res_stir_shaken.c: Fix crash when stir_shaken.conf is invalid - res_stir_shaken: Check for disabled before param validation - app_chanspy.c: resolving the issue writing frame to whisper audiohook. - res_resolver_unbound: Test for NULL ub_result in unbound_resolver_callback @@ -159,6 +168,60 @@ Date: 2024-08-14 +#### stir_shaken: Fix propagation of attest_level and a few other values + Author: George Joseph + Date: 2024-09-24 + + attest_level, send_mky and check_tn_cert_public_url weren't + propagating correctly from the attestation object to the profile + and tn. + + * In the case of attest_level, the enum needed to be changed + so the "0" value (the default) was "NOT_SET" instead of "A". This + now allows the merging of the attestation object, profile and tn + to detect when a value isn't set and use the higher level value. + + * For send_mky and check_tn_cert_public_url, the tn default was + forced to "NO" which always overrode the profile and attestation + objects. Their defaults are now "NOT_SET" so the propagation + happens correctly. + + * Just to remove some redundant code in tn_config.c, a bunch of calls to + generate_sorcery_enum_from_str() and generate_sorcery_enum_to_str() were + replaced with a single call to generate_acfg_common_sorcery_handlers(). + + Resolves: #904 + +#### res_stir_shaken: Remove stale include for jansson.h in verification.c + Author: George Joseph + Date: 2024-09-17 + + verification.c had an include for jansson.h left over from previous + versions of the module. Since res_stir_shaken no longer has a + dependency on jansson, the bundled version wasn't added to GCC's + include path so if you didn't also have a jansson development package + installed, the compile would fail. Removing the stale include + was the only thing needed. + + Resolves: #889 + +#### res_stir_shaken.c: Fix crash when stir_shaken.conf is invalid + Author: George Joseph + Date: 2024-09-13 + + * If the call to ast_config_load() returns CONFIG_STATUS_FILEINVALID, + check_for_old_config() now returns LOAD_DECLINE instead of continuing + on with a bad pointer. + + * If CONFIG_STATUS_FILEMISSING is returned, check_for_old_config() + assumes the config is being loaded from realtime and now returns + LOAD_SUCCESS. If it's actually not being loaded from realtime, + sorcery will catch that later on. + + * Also refactored the error handling in load_module() a bit. + + Resolves: #884 + #### res_stir_shaken: Check for disabled before param validation Author: George Joseph Date: 2024-09-11