kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-22 20:56:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

officially deprecate the 'roundrobin' queue strategy in favor of 'rrmemory'

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30837 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Kevin P. Fleming
2006-05-30 17:52:49 +00:00
parent f35b95e516
commit 7e84433270
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
UPGRADE.txt
View File

@@ -119,6 +119,11 @@ Applications:
record conversations queue members are having with queue callers. Please record conversations queue members are having with queue callers. Please
see configs/queues.conf.sample for more information on this option. see configs/queues.conf.sample for more information on this option.
* The app_queue application strategy called 'roundrobin' has been deprecated
for this release. Users are encouraged to use 'rrmemory' instead, since it
provides more 'true' round-robin call delivery. For the Asterisk 1.6 release,
'rrmemory' will be renamed 'roundrobin'.
* app_meetme: The 'm' option (monitor) is renamed to 'l' (listen only), and * app_meetme: The 'm' option (monitor) is renamed to 'l' (listen only), and
the 'm' option now provides the functionality of "initially muted". the 'm' option now provides the functionality of "initially muted".
In practice, most existing dialplans using the 'm' flag should not notice In practice, most existing dialplans using the 'm' flag should not notice

16
apps/app_queue.c
View File

@@ -395,6 +395,16 @@ static AST_LIST_HEAD_STATIC(queues, ast_call_queue);
static int set_member_paused(char *queuename, char *interface, int paused); static int set_member_paused(char *queuename, char *interface, int paused);
static void rr_dep_warning(void)
{
static unsigned int warned = 0;
if (!warned) {
ast_log(LOG_NOTICE, "The 'roundrobin' queue strategy is deprecated. Please use the 'rrmemory' strategy instead.\n");
warned = 1;
}
}
static void set_queue_result(struct ast_channel *chan, enum queue_result res) static void set_queue_result(struct ast_channel *chan, enum queue_result res)
{ {
int i; int i;
@@ -1028,6 +1038,9 @@ static struct ast_call_queue *find_queue_by_name_rt(const char *queuename, struc
v = v->next; v = v->next;
} }
if (q->strategy == QUEUE_STRATEGY_ROUNDROBIN)
rr_dep_warning();
/* Temporarily set non-dynamic members dead so we can detect deleted ones. */ /* Temporarily set non-dynamic members dead so we can detect deleted ones. */
m = q->members; m = q->members;
while (m) { while (m) {
@@ -3692,6 +3705,9 @@ static void reload_queues(void)
} }
} }
if (q->strategy == QUEUE_STRATEGY_ROUNDROBIN)
rr_dep_warning();
if (new) { if (new) {
AST_LIST_INSERT_HEAD(&queues, q, list); AST_LIST_INSERT_HEAD(&queues, q, list);
} else } else