mirror of
				https://github.com/asterisk/asterisk.git
				synced 2025-10-31 02:37:10 +00:00 
			
		
		
		
	Fix many issues from the NULL_RETURNS Coverity report
Most of the changes here are trivial NULL checks. There are a couple optimizations to remove the need to check for NULL and outboundproxy parsing in chan_sip.c was rewritten to avoid use of strtok. Additionally, a bug was found and fixed with the parsing of outboundproxy when "outboundproxy=," was set. (Closes issue ASTERISK-19654) ........ Merged revisions 365398 from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged revisions 365399 from http://svn.asterisk.org/svn/asterisk/branches/10 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@365400 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
		| @@ -114,6 +114,10 @@ static int aes_helper(struct ast_channel *chan, const char *cmd, char *data, | ||||
| 	ast_aes_set_encrypt_key((unsigned char *) args.key, &ecx);   /* encryption:  plaintext -> encryptedtext -> base64 */ | ||||
| 	ast_aes_set_decrypt_key((unsigned char *) args.key, &dcx);   /* decryption:  base64 -> encryptedtext -> plaintext */ | ||||
| 	tmp = ast_calloc(1, len);                     /* requires a tmp buffer for the base64 decode */ | ||||
| 	if (!tmp) { | ||||
| 		ast_log(LOG_ERROR, "Unable to allocate memory for data\n"); | ||||
| 		return -1; | ||||
| 	} | ||||
| 	tmpP = tmp; | ||||
| 	encrypt = strcmp("AES_DECRYPT", cmd);           /* -1 if encrypting, 0 if decrypting */ | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user