kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-06 12:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some resolved or obsolete BUGBUG comments.

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@396401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Richard Mudgett
2013-08-08 17:51:26 +00:00
parent 33e7b76d1d
commit 73b3c70a5f
4 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/asterisk/bridge_features.h
View File

@@ -86,7 +86,6 @@ enum ast_bridge_builtin_feature {
* parking slot to which it was parked. * parking slot to which it was parked.
*/ */
AST_BRIDGE_BUILTIN_PARKCALL, AST_BRIDGE_BUILTIN_PARKCALL,
/* BUGBUG does Monitor and/or MixMonitor require a two party bridge? MixMonitor is used by ConfBridge so maybe it doesn't. */
/*! /*!
* DTMF one-touch-record toggle using Monitor app. * DTMF one-touch-record toggle using Monitor app.
* *
@@ -174,7 +173,6 @@ enum ast_bridge_hook_type {
AST_BRIDGE_HOOK_TYPE_TALK, AST_BRIDGE_HOOK_TYPE_TALK,
}; };
/* BUGBUG Need to be able to selectively remove DTMF, hangup, and interval hooks. */
/*! \brief Structure that is the essence of a feature hook. */ /*! \brief Structure that is the essence of a feature hook. */
struct ast_bridge_hook { struct ast_bridge_hook {
/*! Callback that is called when hook is tripped */ /*! Callback that is called when hook is tripped */

2
main/bridge.c
View File

@@ -1482,7 +1482,6 @@ int ast_bridge_join(struct ast_bridge *bridge,
ao2_ref(bridge_channel, -1); ao2_ref(bridge_channel, -1);
join_exit:; join_exit:;
/* BUGBUG this is going to cause problems for DTMF atxfer attended bridge between B & C. Maybe an ast_bridge_join_internal() that does not do the after bridge goto for this case. */
ast_bridge_run_after_callback(chan); ast_bridge_run_after_callback(chan);
if (!(ast_channel_softhangup_internal_flag(chan) & AST_SOFTHANGUP_ASYNCGOTO) if (!(ast_channel_softhangup_internal_flag(chan) & AST_SOFTHANGUP_ASYNCGOTO)
&& !ast_bridge_setup_after_goto(chan)) { && !ast_bridge_setup_after_goto(chan)) {
@@ -1960,7 +1959,6 @@ int bridge_do_move(struct ast_bridge *dst_bridge, struct ast_bridge_channel *bri
int was_in_bridge; int was_in_bridge;
int res = 0; int res = 0;
/* BUGBUG need bridge move stasis event and a success/fail event. */
if (bridge_channel->swap) { if (bridge_channel->swap) {
ast_debug(1, "Moving %p(%s) into bridge %s swapping with %s\n", ast_debug(1, "Moving %p(%s) into bridge %s swapping with %s\n",
bridge_channel, ast_channel_name(bridge_channel->chan), dst_bridge->uniqueid, bridge_channel, ast_channel_name(bridge_channel->chan), dst_bridge->uniqueid,

1
main/channel_internal_api.c
View File

@@ -193,7 +193,6 @@ struct ast_channel {
unsigned short transfercapability; /*!< ISDN Transfer Capability - AST_FLAG_DIGITAL is not enough */ unsigned short transfercapability; /*!< ISDN Transfer Capability - AST_FLAG_DIGITAL is not enough */
/* BUGBUG the bridge pointer must change to an ast_channel_bridge pointer because it will never change while the channel is in the bridging system whereas the bridge could change. */
struct ast_bridge *bridge; /*!< Bridge this channel is participating in */ struct ast_bridge *bridge; /*!< Bridge this channel is participating in */
struct ast_bridge_channel *bridge_channel;/*!< The bridge_channel this channel is linked with. */ struct ast_bridge_channel *bridge_channel;/*!< The bridge_channel this channel is linked with. */
struct ast_timer *timer; /*!< timer object that provided timingfd */ struct ast_timer *timer; /*!< timer object that provided timingfd */

2
main/features.c
View File

@@ -792,7 +792,7 @@ static int setup_bridge_features_dynamic(struct ast_bridge_features *features, s
return res; return res;
} }
/* BUGBUG this really should be made a private function of bridging_basic.c after struct ast_call_feature is made an ao2 object. */ /* BUGBUG this really should be made a private function of bridge_basic.c after struct ast_call_feature is made an ao2 object. */
int ast_bridge_channel_setup_features(struct ast_bridge_channel *bridge_channel) int ast_bridge_channel_setup_features(struct ast_bridge_channel *bridge_channel)
{ {
int res = 0; int res = 0;