From 6b03d60c7d047c80328e89f0b35dac3530f0f0c7 Mon Sep 17 00:00:00 2001 From: Mike Bradeen Date: Fri, 18 Nov 2022 18:24:38 -0700 Subject: [PATCH] res_monitor: Remove deprecated module. ASTERISK-30303 Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50 --- README-SERIOUSLY.bestpractices.md | 8 +- apps/Makefile | 2 +- apps/app_meetme.c | 6 +- apps/app_mixmonitor.c | 3 - apps/app_queue.c | 48 +- bridges/bridge_builtin_features.c | 217 +--- channels/Makefile | 4 - configs/samples/features.conf.sample | 12 +- configs/samples/queues.conf.sample | 33 +- configs/samples/stasis.conf.sample | 2 - doc/UPGRADE-staging/res_monitor_removal.txt | 13 + include/asterisk/bridge_features.h | 17 +- include/asterisk/channel.h | 17 - include/asterisk/doxygen/architecture.h | 1 - include/asterisk/features_config.h | 6 +- include/asterisk/monitor.h | 66 -- include/asterisk/stasis_channels.h | 16 - main/asterisk.dynamics | 1 - main/bridge_basic.c | 1 - main/bridge_channel.c | 2 - main/channel.c | 92 +- main/channel_internal_api.c | 9 - main/features.c | 37 - main/features_config.c | 29 +- main/manager_channels.c | 49 - main/stasis.c | 2 - main/stasis_channels.c | 6 - menuselect/example_menuselect-tree | 2 - menuselect/test/menuselect-tree | 3 - pbx/Makefile | 2 +- pbx/ael/ael-test/ael-test2/apptest.ael2 | 1 - pbx/ael/ael-test/ael-test4/apptest.ael2 | 1 - pbx/ael/ael-test/ael-test5/extensions.ael | 16 - pbx/ael/ael-test/ael-test6/extensions.ael | 16 - res/res_monitor.c | 1019 ------------------- res/res_monitor.exports.in | 11 - 36 files changed, 50 insertions(+), 1720 deletions(-) create mode 100644 doc/UPGRADE-staging/res_monitor_removal.txt delete mode 100644 include/asterisk/monitor.h delete mode 100644 res/res_monitor.c delete mode 100644 res/res_monitor.exports.in diff --git a/README-SERIOUSLY.bestpractices.md b/README-SERIOUSLY.bestpractices.md index f021f9d7d8..fa4b0a6fa2 100644 --- a/README-SERIOUSLY.bestpractices.md +++ b/README-SERIOUSLY.bestpractices.md @@ -83,10 +83,10 @@ the FILTER() dialplan function. The CALLERID(num) and CALLERID(name) values are other commonly used values that are sources of data potentially supplied by outside sources. If you use these -values as parameters to the System(), MixMonitor(), or Monitor() applications -or the SHELL() dialplan function, you can allow injection of arbitrary operating -system command execution. The FILTER() dialplan function is available to remove -dangerous characters from untrusted strings to block the command injection. +values as parameters to the System() or MixMonitor() applications or the SHELL() +dialplan function, you can allow injection of arbitrary operating system command +execution. The FILTER() dialplan function is available to remove dangerous +characters from untrusted strings to block the command injection. ### Strict Pattern Matching diff --git a/apps/Makefile b/apps/Makefile index 02b705ddb2..50b3fccc8f 100644 --- a/apps/Makefile +++ b/apps/Makefile @@ -58,6 +58,6 @@ app_voicemail_imap.o: _ASTCFLAGS+=$(AST_NO_FORMAT_TRUNCATION) -DIMAP_STORAGE app_while.o: _ASTCFLAGS+=$(AST_NO_FORMAT_TRUNCATION) ifneq ($(findstring $(OSARCH), mingw32 cygwin ),) - LIBS+= -lres_ael_share.so -lres_monitor.so -lres_speech.so + LIBS+= -lres_ael_share.so -lres_speech.so LIBS+= -lres_smdi.so endif diff --git a/apps/app_meetme.c b/apps/app_meetme.c index 812b8176e2..0d5bdc2570 100644 --- a/apps/app_meetme.c +++ b/apps/app_meetme.c @@ -3678,7 +3678,7 @@ static int conf_run(struct ast_channel *chan, struct ast_conference *conf, struc ast_func_write(chan, "DENOISE(rx)", "on"); } - retrydahdi = (strcasecmp(ast_channel_tech(chan)->type, "DAHDI") || (ast_channel_audiohooks(chan) || ast_channel_monitor(chan)) ? 1 : 0); + retrydahdi = (strcasecmp(ast_channel_tech(chan)->type, "DAHDI") || (ast_channel_audiohooks(chan)) ? 1 : 0); user->dahdichannel = !retrydahdi; dahdiretry: @@ -4196,14 +4196,14 @@ static int conf_run(struct ast_channel *chan, struct ast_conference *conf, struc if (c) { char dtmfstr[2] = ""; - if (ast_channel_fd(c, 0) != origfd || (user->dahdichannel && (ast_channel_audiohooks(c) || ast_channel_monitor(c)))) { + if (ast_channel_fd(c, 0) != origfd || (user->dahdichannel && ast_channel_audiohooks(c))) { if (using_pseudo) { /* Kill old pseudo */ close(fd); using_pseudo = 0; } ast_debug(1, "Ooh, something swapped out under us, starting over\n"); - retrydahdi = (strcasecmp(ast_channel_tech(c)->type, "DAHDI") || (ast_channel_audiohooks(c) || ast_channel_monitor(c)) ? 1 : 0); + retrydahdi = (strcasecmp(ast_channel_tech(c)->type, "DAHDI") || ast_channel_audiohooks(c) ? 1 : 0); user->dahdichannel = !retrydahdi; goto dahdiretry; } diff --git a/apps/app_mixmonitor.c b/apps/app_mixmonitor.c index 3ce1a76bb7..332e9b854a 100644 --- a/apps/app_mixmonitor.c +++ b/apps/app_mixmonitor.c @@ -183,10 +183,7 @@ function FILTER(). - Monitor StopMixMonitor - PauseMonitor - UnpauseMonitor AUDIOHOOK_INHERIT diff --git a/apps/app_queue.c b/apps/app_queue.c index 4b6b72bad7..c5b7d10162 100644 --- a/apps/app_queue.c +++ b/apps/app_queue.c @@ -41,7 +41,6 @@ * - Position announcement * - Abandoned/completed call counters * - Failout timer passed as optional app parameter - * - Optional monitoring of calls, started when call is answered * * Patch Version 1.07 2003-12-24 01 * @@ -63,7 +62,6 @@ */ /*** MODULEINFO - res_monitor core ***/ @@ -88,7 +86,6 @@ #include "asterisk/cli.h" #include "asterisk/manager.h" #include "asterisk/config.h" -#include "asterisk/monitor.h" #include "asterisk/utils.h" #include "asterisk/causes.h" #include "asterisk/astdb.h" @@ -222,14 +219,6 @@ - -