kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-03 03:20:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_rtp_asterisk: Check remote ICE reset and reset local ice attrb

Browse Source 
This change will check is the remote ICE session got reset or not by
checking the offered ufrag and password with session. If the remote ICE
reset session then Asterisk reset its local ufrag and password to reject
binding request with Old ufrag and Password.

ASTERISK-29266

Change-Id: I9c55e79a7af98a8fbb497d336b828ba41bc34eeb
This commit is contained in:
Salah Ahmed
2021-01-27 14:01:01 -06:00
committed by Joshua Colp
parent 48ed4f670f
commit 5d42dd2e6a
2 changed files with 57 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
res/res_rtp_asterisk.c
View File

@@ -273,6 +273,8 @@ struct ast_ice_host_candidate {
/*! \brief List of ICE host candidate mappings */
static AST_RWLIST_HEAD_STATIC(host_candidates, ast_ice_host_candidate);
static char *generate_random_string(char *buf, size_t size);
#endif
#define FLAG_3389_WARNING (1 << 0)
@@ -766,14 +768,27 @@ static void ast_rtp_ice_candidate_destroy(void *obj)
static void ast_rtp_ice_set_authentication(struct ast_rtp_instance *instance, const char *ufrag, const char *password)
{
struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);
int ice_attrb_reset = 0;
if (!ast_strlen_zero(ufrag)) {
if (!ast_strlen_zero(rtp->remote_ufrag) && strcmp(ufrag, rtp->remote_ufrag)) {
ice_attrb_reset = 1;
}
ast_copy_string(rtp->remote_ufrag, ufrag, sizeof(rtp->remote_ufrag));
}
if (!ast_strlen_zero(password)) {
if (!ast_strlen_zero(rtp->remote_passwd) && strcmp(password, rtp->remote_passwd)) {
ice_attrb_reset = 1;
}
ast_copy_string(rtp->remote_passwd, password, sizeof(rtp->remote_passwd));
}
/* If the remote ufrag or passwd changed, local ufrag and passwd need to regenerate */
if (ice_attrb_reset) {
generate_random_string(rtp->local_ufrag, sizeof(rtp->local_ufrag));
generate_random_string(rtp->local_passwd, sizeof(rtp->local_passwd));
}
}
static int ice_candidate_cmp(void *obj, void *arg, int flags)