kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-06 12:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use backslash as an escape character, unless it really is an escape character.

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Tilghman Lesher
2007-12-13 17:46:04 +00:00
parent a19a3f493c
commit 5d23b05a92
1 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
cdr/cdr_adaptive_odbc.c
View File

@@ -327,6 +327,12 @@ static int odbc_log(struct ast_cdr *cdr)
lensql = snprintf(sql, sizesql, "INSERT INTO %s (", tableptr->table); lensql = snprintf(sql, sizesql, "INSERT INTO %s (", tableptr->table);
lensql2 = snprintf(sql2, sizesql2, " VALUES ("); lensql2 = snprintf(sql2, sizesql2, " VALUES (");
/* No need to check the connection now; we'll handle any failure in prepare_and_execute */
if (!(obj = ast_odbc_request_obj(tableptr->connection, 0))) {
ast_log(LOG_WARNING, "cdr_adaptive_odbc: Unable to retrieve database handle for '%s:%s'. CDR failed: %s\n", tableptr->connection, tableptr->table, sql);
continue;
}
AST_LIST_TRAVERSE(&(tableptr->columns), entry, list) { AST_LIST_TRAVERSE(&(tableptr->columns), entry, list) {
/* Check if we have a similarly named variable */ /* Check if we have a similarly named variable */
ast_cdr_getvar(cdr, entry->cdrname, &colptr, colbuf, sizeof(colbuf), 0, ast_cdr_getvar(cdr, entry->cdrname, &colptr, colbuf, sizeof(colbuf), 0,
@@ -369,7 +375,7 @@ static int odbc_log(struct ast_cdr *cdr)
if (*tmp == '\'') { if (*tmp == '\'') {
strcpy(sql2 + lensql2, "''"); strcpy(sql2 + lensql2, "''");
lensql2 += 2; lensql2 += 2;
} else if (*tmp == '\\') { } else if (*tmp == '\\' && ast_odbc_backslash_is_escape(obj)) {
strcpy(sql2 + lensql2, "\\\\"); strcpy(sql2 + lensql2, "\\\\");
lensql2 += 2; lensql2 += 2;
} else { } else {
@@ -552,21 +558,16 @@ static int odbc_log(struct ast_cdr *cdr)
strcat(sql + lensql, sql2); strcat(sql + lensql, sql2);
ast_verb(11, "[%s]\n", sql); ast_verb(11, "[%s]\n", sql);
/* No need to check the connection now; we'll handle any failure in prepare_and_execute */
obj = ast_odbc_request_obj(tableptr->connection, 0); stmt = ast_odbc_prepare_and_execute(obj, generic_prepare, sql);
if (obj) { if (stmt) {
stmt = ast_odbc_prepare_and_execute(obj, generic_prepare, sql); SQLRowCount(stmt, &rows);
if (stmt) { SQLFreeHandle(SQL_HANDLE_STMT, stmt);
SQLRowCount(stmt, &rows);
SQLFreeHandle(SQL_HANDLE_STMT, stmt);
}
if (rows == 0) {
ast_log(LOG_WARNING, "cdr_adaptive_odbc: Insert failed on '%s:%s'. CDR failed: %s\n", tableptr->connection, tableptr->table, sql);
}
ast_odbc_release_obj(obj);
} else {
ast_log(LOG_WARNING, "cdr_adaptive_odbc: Unable to retrieve database handle for '%s:%s'. CDR failed: %s\n", tableptr->connection, tableptr->table, sql);
} }
if (rows == 0) {
ast_log(LOG_WARNING, "cdr_adaptive_odbc: Insert failed on '%s:%s'. CDR failed: %s\n", tableptr->connection, tableptr->table, sql);
}
ast_odbc_release_obj(obj);
} }
AST_RWLIST_UNLOCK(&odbc_tables); AST_RWLIST_UNLOCK(&odbc_tables);