mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-20 19:53:10 +00:00
add a minor allocation/zeroing guideline
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -192,6 +192,28 @@ output buffer will be null-terminated. Use ast_copy_string instead, which
|
|||||||
is also slightly more efficient (and allows passing the actual buffer
|
is also slightly more efficient (and allows passing the actual buffer
|
||||||
size, which makes the code clearer).
|
size, which makes the code clearer).
|
||||||
|
|
||||||
|
When allocating/zeroing memory for a structure, try to use code like this:
|
||||||
|
|
||||||
|
struct foo *tmp;
|
||||||
|
|
||||||
|
...
|
||||||
|
|
||||||
|
tmp = malloc(sizeof(*tmp));
|
||||||
|
if (tmp)
|
||||||
|
memset(tmp, 0, sizeof(*tmp));
|
||||||
|
|
||||||
|
This eliminates duplication of the 'struct foo' identifier, which makes the
|
||||||
|
code easier to read and also ensures that if it is copy-and-pasted it won't
|
||||||
|
require as much editing. In fact, you can even use:
|
||||||
|
|
||||||
|
struct foo *tmp;
|
||||||
|
|
||||||
|
...
|
||||||
|
|
||||||
|
tmp = calloc(1, sizeof(*tmp));
|
||||||
|
|
||||||
|
This will allocate and zero the memory in a single operation.
|
||||||
|
|
||||||
== CLI Commands ==
|
== CLI Commands ==
|
||||||
|
|
||||||
New CLI commands should be named using the module's name, followed by a verb
|
New CLI commands should be named using the module's name, followed by a verb
|
||||||
|
Reference in New Issue
Block a user