kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-05 20:20:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash in res_pjsip_outbound_registration when the remote server can not be resolved.

Browse Source 
This crash was caused by decrementing the reference count of a newly created message when
it should not be. This change fixes that but also fixes all other cases where this was
incorrectly done.

(closes issue ASTERISK-22188)
Reported by: Kinsey Moore


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@396319 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Joshua Colp
2013-08-06 12:39:27 +00:00
parent 07d3705b42
commit 5b3441ae55
4 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
res/res_pjsip_exten_state.c
View File

@@ -250,7 +250,6 @@ static void create_send_notify(struct exten_state_subscription *exten_state_sub,
if (ast_sip_subscription_send_request(exten_state_sub->sip_sub, tdata) != PJ_SUCCESS) { if (ast_sip_subscription_send_request(exten_state_sub->sip_sub, tdata) != PJ_SUCCESS) {
ast_log(LOG_WARNING, "Unable to send NOTIFY request\n"); ast_log(LOG_WARNING, "Unable to send NOTIFY request\n");
pjsip_tx_data_dec_ref(tdata);
} }
} }

1
res/res_pjsip_messaging.c
View File

@@ -484,7 +484,6 @@ static int msg_send(void *data)
update_from(tdata, mdata->from); update_from(tdata, mdata->from);
vars_to_headers(mdata->msg, tdata); vars_to_headers(mdata->msg, tdata);
if (ast_sip_send_request(tdata, NULL, endpoint)) { if (ast_sip_send_request(tdata, NULL, endpoint)) {
pjsip_tx_data_dec_ref(tdata);
ast_log(LOG_ERROR, "SIP MESSAGE - Could not send request\n"); ast_log(LOG_ERROR, "SIP MESSAGE - Could not send request\n");
return -1; return -1;
} }

1
res/res_pjsip_notify.c
View File

@@ -440,7 +440,6 @@ static int notify_contact(void *obj, void *arg, int flags)
data->build_notify(tdata, data->info); data->build_notify(tdata, data->info);
if (ast_sip_send_request(tdata, NULL, data->endpoint)) { if (ast_sip_send_request(tdata, NULL, data->endpoint)) {
pjsip_tx_data_dec_ref(tdata);
ast_log(LOG_ERROR, "SIP NOTIFY - Unable to send request for " ast_log(LOG_ERROR, "SIP NOTIFY - Unable to send request for "
"contact %s\n", contact->uri); "contact %s\n", contact->uri);
return -1; return -1;

1
res/res_pjsip_outbound_registration.c
View File

@@ -221,7 +221,6 @@ static int handle_client_registration(void *data)
ao2_ref(client_state, +1); ao2_ref(client_state, +1);
if (pjsip_regc_send(client_state->client, tdata) != PJ_SUCCESS) { if (pjsip_regc_send(client_state->client, tdata) != PJ_SUCCESS) {
ao2_ref(client_state, -1); ao2_ref(client_state, -1);
pjsip_tx_data_dec_ref(tdata);
} }
return 0; return 0;