kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-06 12:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

ast_careful_fwrite to support EPIPE gracefully

Browse Source 
When a reading end of the network socket is closed by an AMI manager,
the EPIPE is signaled when writing to our end, resulting in the
spurious log error message

  ast_careful_fwrite: fwrite() returned error: Broken pipe

Previously EPIPE was handled in ast_carefulwrite() a few lines above,
but not in this function.

ASTERISK-26753

Change-Id: I6a67335cd6526608bb9b78f796c626b1677664b8
This commit is contained in:
kkm
2017-01-17 18:46:43 -08:00
parent 3410000948
commit 555e8cd2ba
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
main/utils.c
View File

@@ -1453,7 +1453,9 @@ int ast_careful_fwrite(FILE *f, int fd, const char *src, size_t len, int timeout
if (ferror(f) && errno != EINTR && errno != EAGAIN) { if (ferror(f) && errno != EINTR && errno != EAGAIN) {
/* fatal error from fwrite() */ /* fatal error from fwrite() */
if (!feof(f)) { if (errno == EPIPE) {
ast_debug(1, "fwrite() failed due to reading end being closed: EPIPE\n");
} else if (!feof(f)) {
/* Don't spam the logs if it was just that the connection is closed. */ /* Don't spam the logs if it was just that the connection is closed. */
ast_log(LOG_ERROR, "fwrite() returned error: %s\n", strerror(errno)); ast_log(LOG_ERROR, "fwrite() returned error: %s\n", strerror(errno));
} }
@@ -1486,8 +1488,12 @@ int ast_careful_fwrite(FILE *f, int fd, const char *src, size_t len, int timeout
continue; continue;
} }
if (errno && !feof(f)) { if (errno && !feof(f)) {
/* Don't spam the logs if it was just that the connection is closed. */ if (errno == EPIPE) {
ast_log(LOG_ERROR, "fflush() returned error: %s\n", strerror(errno)); ast_debug(1, "fflush() failed due to reading end being closed: EPIPE\n");
} else {
/* Don't spam the logs if it was just that the connection is closed. */
ast_log(LOG_ERROR, "fflush() returned error: %s\n", strerror(errno));
}
} }
n = -1; n = -1;
break; break;