mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-03 03:20:57 +00:00
res_stasis: Fix crash on a hanging up channel.
* Give the struct stasis_app_control ao2 object a ref to the channel held in the object. Now the channel will still be around if a thread needs to post a stasis message instead of crash because the topic was destroyed. * Moved stopping any lingering silence generator out of the struct stasis_app_control destructor and made it a part of exiting the Stasis application. Who knows which thread the destructor will be called under so it cannot affect the channel's silence generator. Not only was the channel unprotected when the silence generator was stopped, stasis may no longer even control the channel. ASTERISK-25882 Change-Id: I21728161b5fe638cef7976fa36a605043a7497e4
This commit is contained in:
@@ -1371,6 +1371,9 @@ int stasis_app_exec(struct ast_channel *chan, const char *app_name, int argc,
|
||||
remove_stasis_end_published(chan);
|
||||
}
|
||||
|
||||
/* Stop any lingering silence generator */
|
||||
control_silence_stop_now(control);
|
||||
|
||||
/* There's an off chance that app is ready for cleanup. Go ahead
|
||||
* and clean up, just in case
|
||||
*/
|
||||
|
Reference in New Issue
Block a user