mirror of
https://github.com/asterisk/asterisk.git
synced 2025-09-02 11:06:31 +00:00
Remove redundant module checks and references.
This removes references that are no longer needed due to automatic references created by module dependencies. In addition this removes most calls to ast_module_check as they were checking modules which are listed as dependencies. Change-Id: I332a6e8383d4c72c8e89d988a184ab8320c4872e
This commit is contained in:
@@ -266,7 +266,6 @@ static int unload_module(void)
|
||||
ast_ari_websocket_events_event_websocket_dtor();
|
||||
{{/has_websocket}}
|
||||
{{/apis}}
|
||||
stasis_app_unref();
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -274,43 +273,37 @@ static int load_module(void)
|
||||
{
|
||||
int res = 0;
|
||||
|
||||
CHECK_ARI_MODULE_LOADED();
|
||||
|
||||
{{#apis}}
|
||||
{{#operations}}
|
||||
{{#has_websocket}}
|
||||
/* This is scoped to not conflict with CHECK_ARI_MODULE_LOADED */
|
||||
{
|
||||
struct ast_websocket_protocol *protocol;
|
||||
struct ast_websocket_protocol *protocol;
|
||||
|
||||
if (ast_ari_websocket_{{c_name}}_{{c_nickname}}_init() == -1) {
|
||||
return AST_MODULE_LOAD_DECLINE;
|
||||
}
|
||||
if (ast_ari_websocket_{{c_name}}_{{c_nickname}}_init() == -1) {
|
||||
return AST_MODULE_LOAD_DECLINE;
|
||||
}
|
||||
|
||||
{{full_name}}.ws_server = ast_websocket_server_create();
|
||||
if (!{{full_name}}.ws_server) {
|
||||
ast_ari_websocket_events_event_websocket_dtor();
|
||||
return AST_MODULE_LOAD_DECLINE;
|
||||
}
|
||||
{{full_name}}.ws_server = ast_websocket_server_create();
|
||||
if (!{{full_name}}.ws_server) {
|
||||
ast_ari_websocket_events_event_websocket_dtor();
|
||||
return AST_MODULE_LOAD_DECLINE;
|
||||
}
|
||||
|
||||
protocol = ast_websocket_sub_protocol_alloc("{{websocket_protocol}}");
|
||||
if (!protocol) {
|
||||
ao2_ref({{full_name}}.ws_server, -1);
|
||||
{{full_name}}.ws_server = NULL;
|
||||
ast_ari_websocket_events_event_websocket_dtor();
|
||||
return AST_MODULE_LOAD_DECLINE;
|
||||
}
|
||||
protocol->session_attempted = ast_ari_{{c_name}}_{{c_nickname}}_ws_attempted_cb;
|
||||
protocol->session_established = ast_ari_{{c_name}}_{{c_nickname}}_ws_established_cb;
|
||||
protocol = ast_websocket_sub_protocol_alloc("{{websocket_protocol}}");
|
||||
if (!protocol) {
|
||||
ao2_ref({{full_name}}.ws_server, -1);
|
||||
{{full_name}}.ws_server = NULL;
|
||||
ast_ari_websocket_events_event_websocket_dtor();
|
||||
return AST_MODULE_LOAD_DECLINE;
|
||||
}
|
||||
protocol->session_attempted = ast_ari_{{c_name}}_{{c_nickname}}_ws_attempted_cb;
|
||||
protocol->session_established = ast_ari_{{c_name}}_{{c_nickname}}_ws_established_cb;
|
||||
{{/has_websocket}}
|
||||
{{#is_websocket}}
|
||||
res |= ast_websocket_server_add_protocol2({{full_name}}.ws_server, protocol);
|
||||
}
|
||||
res |= ast_websocket_server_add_protocol2({{full_name}}.ws_server, protocol);
|
||||
{{/is_websocket}}
|
||||
{{/operations}}
|
||||
{{/apis}}
|
||||
|
||||
stasis_app_ref();
|
||||
res |= ast_ari_add_handler(&{{root_full_name}});
|
||||
if (res) {
|
||||
unload_module();
|
||||
|
Reference in New Issue
Block a user