kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-05 04:11:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

ari endpoints: GET /ari/endpoints/{invalid-tech} should return a 404

Browse Source 
Implementation listing endpoints by technology returned an empty array if no
matching endpoints were found.  Fixed so a "404 Not Found" will be returned
instead.

(closes issue ASTERISK-22803)
Reported by: David M. Lee
........

Merged revisions 402787 from http://svn.asterisk.org/svn/asterisk/branches/12


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Kevin Harwell
2013-11-12 22:17:28 +00:00
parent 94f19c8218
commit 4be01b4598
3 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
res/ari/resource_endpoints.c
View File

@@ -89,8 +89,6 @@ void ast_ari_endpoints_list_by_tech(struct ast_variable *headers,
struct ao2_iterator i;
void *obj;
/* TODO - if tech isn't a recognized type of endpoint, it should 404 */
cache = ast_endpoint_cache();
if (!cache) {
ast_ari_response_error(
@@ -131,7 +129,12 @@ void ast_ari_endpoints_list_by_tech(struct ast_variable *headers,
}
ao2_iterator_destroy(&i);
ast_ari_response_ok(response, ast_json_ref(json));
if (ast_json_array_size(json)) {
ast_ari_response_ok(response, ast_json_ref(json));
} else {
ast_ari_response_error(response, 404, "Not Found",
"No Endpoints found with tech %s", args->tech);
}
}
void ast_ari_endpoints_get(struct ast_variable *headers,
struct ast_ari_endpoints_get_args *args,