mirror of
				https://github.com/asterisk/asterisk.git
				synced 2025-10-31 18:55:19 +00:00 
			
		
		
		
	Massive cleanups to applications for LOCAL_USER handling and some other things.
In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an application. An exception is if there is some *fast* setup code that might halt the execution of the application, such as checking to see if an argument exists. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
		| @@ -89,11 +89,13 @@ static int system_exec_helper(struct ast_channel *chan, void *data, int failmode | ||||
| { | ||||
| 	int res=0; | ||||
| 	struct localuser *u; | ||||
| 	if (!data) { | ||||
| 	 | ||||
| 	if (!data || ast_strlen_zero(data)) { | ||||
| 		ast_log(LOG_WARNING, "System requires an argument(command)\n"); | ||||
| 		pbx_builtin_setvar_helper(chan, chanvar, "FAILURE"); | ||||
| 		return failmode; | ||||
| 	} | ||||
|  | ||||
| 	LOCAL_USER_ADD(u); | ||||
|  | ||||
| 	/* Do our thing here */ | ||||
| @@ -120,6 +122,7 @@ static int system_exec_helper(struct ast_channel *chan, void *data, int failmode | ||||
| 	}  | ||||
|  | ||||
| 	LOCAL_USER_REMOVE(u); | ||||
|  | ||||
| 	return res; | ||||
| } | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user