kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-15 08:44:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_config_odbc: Prevent Realtime fallback on record-not-found (SQL_NO_DATA)

Browse Source 
This patch fixes an issue in the ODBC Realtime engine where Asterisk incorrectly
falls back to the next configured backend when the current one returns
SQL_NO_DATA (i.e., no record found).
This is a logical error and performance risk in multi-backend configurations.

Solution:
Introduced CONFIG_RT_NOT_FOUND ((void *)-1) as a special return marker.
ODBC Realtime backend now return CONFIG_RT_NOT_FOUND when no data is found.
Core engine stops iterating on this marker, avoiding unnecessary fallback.

Notes:
Other Realtime backends (PostgreSQL, LDAP, etc.) can be updated similarly.
This patch only covers ODBC.

Fixes: #1305
This commit is contained in:
Alexei Gradinari
2025-07-15 17:56:39 -04:00
committed by github-actions[bot]
parent 9820a62263
commit 3e178dcfd6
3 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
main/config.c
View File

@@ -3660,8 +3660,20 @@ struct ast_variable *ast_load_realtime_all_fields(const char *family, const stru
for (i = 1; ; i++) {
if ((eng = find_engine(family, i, db, sizeof(db), table, sizeof(table)))) {
if (eng->realtime_func && (res = eng->realtime_func(db, table, fields))) {
return res;
if (eng->realtime_func) {
res = eng->realtime_func(db, table, fields);
/* If a backend returns CONFIG_RT_NOT_FOUND, stop iteration and return NULL,
* indicating that the requested record does not exist and no failover should occur.
* Only continue iteration if the result is NULL and not CONFIG_RT_NOT_FOUND,
* which signals a backend failure.
*/
if (res == CONFIG_RT_NOT_FOUND) {
return NULL;
}
if (res) {
return res;
}
}
} else {
return NULL;