kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-05 12:16:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

strings.h: Ensure ast_str_buffer(…) returns a 0 terminated string.

Browse Source 
If a dynamic string is created with an initial length of 0,
`ast_str_buffer(…)` will return an invalid pointer.

This was a secondary discovery when fixing #65.
This commit is contained in:
Sean Bright
2024-02-17 14:41:38 -05:00
parent bbafb63bb5
commit 31fc2877cb
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/asterisk/strings.h
View File

@@ -753,7 +753,10 @@ char * attribute_pure ast_str_buffer(const struct ast_str *buf),
* being returned; eventually, it should become truly const * being returned; eventually, it should become truly const
* and only be modified via accessor functions * and only be modified via accessor functions
*/ */
return (char *) buf->__AST_STR_STR; if (__builtin_expect(buf->__AST_STR_LEN > 0, 1)) {
return (char *) buf->__AST_STR_STR;
}
return "";
} }
) )