kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-01 03:04:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change space-zero to now evaluate to false, as is expected by a great many.

Browse Source 
(Inspired by a post on the -users list)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Tilghman Lesher
2008-05-25 14:31:29 +00:00
parent 3c6eb61008
commit 316e334751
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
UPGRADE.txt
View File

@@ -59,6 +59,12 @@ Core:
* The silencethreshold used for various applications is now settable via a * The silencethreshold used for various applications is now settable via a
centralized config option in dsp.conf. centralized config option in dsp.conf.
* The logical value of spaces immediately preceding a standalone 0 previously
evaluated to true. It now evaluates to false. This has confused a good
many people in the past (typically because they failed to realize the space
had any significance). Since this violates the Principle of Least Surprise,
it has been changed.
Voicemail: Voicemail:
* The voicemail configuration values 'maxmessage' and 'minmessage' have * The voicemail configuration values 'maxmessage' and 'minmessage' have

10
main/pbx.c
View File

@@ -7959,12 +7959,14 @@ void pbx_builtin_clear_globals(void)
int pbx_checkcondition(const char *condition) int pbx_checkcondition(const char *condition)
{ {
if (ast_strlen_zero(condition)) /* NULL or empty strings are false */ int res;
if (ast_strlen_zero(condition)) { /* NULL or empty strings are false */
return 0; return 0;
else if (*condition >= '0' && *condition <= '9') /* Numbers are evaluated for truth */ } else if (sscanf(condition, "%d", &res) == 1) { /* Numbers are evaluated for truth */
return atoi(condition); return res;
else /* Strings are true */ } else { /* Strings are true */
return 1; return 1;
}
} }
static int pbx_builtin_gotoif(struct ast_channel *chan, void *data) static int pbx_builtin_gotoif(struct ast_channel *chan, void *data)