kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-04 03:50:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

strings.h: ast_str_to_upper() and _to_lower() are not pure.

Browse Source 
Because they modify their argument they are not pure functions and
should not be marked as such, otherwise the compiler may optimize
them away.

ASTERISK-29306 #close

Change-Id: Ibec03a08522dd39e8a137ece9bc6a3059dfaad5f
This commit is contained in:
Sean Bright
2021-03-08 15:06:00 -05:00
committed by Joshua Colp
parent df37b8181c
commit 30e509c2f9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/asterisk/strings.h
View File

@@ -1265,7 +1265,7 @@ static force_inline int attribute_pure ast_str_case_hash(const char *str)
* *
* \retval str for convenience * \retval str for convenience
*/ */
static force_inline char *attribute_pure ast_str_to_lower(char *str) static force_inline char *ast_str_to_lower(char *str)
{ {
char *str_orig = str; char *str_orig = str;
if (!str) { if (!str) {
@@ -1286,7 +1286,7 @@ static force_inline char *attribute_pure ast_str_to_lower(char *str)
* *
* \retval str for convenience * \retval str for convenience
*/ */
static force_inline char *attribute_pure ast_str_to_upper(char *str) static force_inline char *ast_str_to_upper(char *str)
{ {
char *str_orig = str; char *str_orig = str;
if (!str) { if (!str) {